scalafmt: code style for scala #184

claudio.atzori · 2022-01-12T09:56:28+01:00

claudio.atzori commented

2022-01-12 09:56:28 +01:00

This PR introduces a maven plugin to reformat automatically the scala classes available in the project. https://scalameta.org/scalafmt

<plugin>
	<groupId>org.antipathy</groupId>
	<artifactId>mvn-scalafmt_2.11</artifactId>
	<version>1.0.1640073709.733712b</version>
</plugin>

In order to support the automatic formatting across the different modules, the type definitions are stored in the dhp-code-stype submodule:

dhp-build/dhp-code-style/src/main/resources/scalafmt/scalafmt.conf

This PR introduces a maven plugin to reformat automatically the scala classes available in the project. https://scalameta.org/scalafmt ``` <plugin> <groupId>org.antipathy</groupId> <artifactId>mvn-scalafmt_2.11</artifactId> <version>1.0.1640073709.733712b</version> </plugin> ``` In order to support the automatic formatting across the different modules, the type definitions are stored in the `dhp-code-stype` submodule: ``` dhp-build/dhp-code-style/src/main/resources/scalafmt/scalafmt.conf ```

claudio.atzori added the

enhancement

label 2022-01-12 09:56:28 +01:00

sandro.labruzzo was assigned by claudio.atzori

2022-01-12 09:56:28 +01:00

claudio.atzori added 5 commits 2022-01-12 09:56:29 +01:00

4f212652ca scalafmt: code formatting

dcd282977c pulled from beta

0f2144b5e0 scalafmt: code formatting

b78d2b71f0 updated scala format configuration

57e2c4b749 formatted code

miriam.baglioni was assigned by claudio.atzori

2022-01-12 09:56:37 +01:00

sandro.labruzzo merged commit 1b9e8378b3 into beta

2022-01-12 09:58:40 +01:00

sandro.labruzzo deleted branch scalafmt

2022-01-12 09:58:40 +01:00

sandro.labruzzo referenced this issue from a commit

2022-01-12 09:58:40 +01:00

Merge pull request 'scalafmt: code style for scala' (#184) from scalafmt into beta

claudio.atzori commented

2022-01-12 17:26:53 +01:00

As a reference: in order to make the plugin work while compiling the project from the root, as well as on the individual module level (e.g. while oozie-packaging, deploying, running an oozie workflow) the reference to the scalafmt configuration file needed to be expressed as a remote location. I currently set it statically to

https://code-repo.d4science.org/D-Net/dnet-hadoop/raw/branch/beta/dhp-build/dhp-code-style/src/main/resources/scalafmt/scalafmt.conf

A better and more stable location will be updated later on.

As a reference: in order to make the plugin work while compiling the project from the root, as well as on the individual module level (e.g. while oozie-packaging, deploying, running an oozie workflow) the reference to the scalafmt configuration file needed to be expressed as a remote location. I currently set it statically to https://code-repo.d4science.org/D-Net/dnet-hadoop/raw/branch/beta/dhp-build/dhp-code-style/src/main/resources/scalafmt/scalafmt.conf A better and more stable location will be updated later on.

claudio.atzori referenced this pull request

2022-02-24 12:47:37 +01:00

promoting beta branch to master - March 2022 #197

Sign in to join this conversation.

No reviewers