gCubeSystem
/
threadlocal-vars-cleaner
14
1
Fork 1
Code Issues Pull Requests Releases Wiki Activity

Wrong extra return if session is null at check

This commit is contained in:
Mauro Mugnaini 2021-04-30 08:27:46 +02:00
parent 760448c7db
commit 99b38ef4b7
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/org/gcube/portal/threadlocalexec/SmartGearsPortalValve.java
View File

@ -74,12 +74,11 @@ public class SmartGearsPortalValve extends ValveBase {
// user cannot be null otherwise also the getCurrentUsername(request) returned null username in previous lines // user cannot be null otherwise also the getCurrentUsername(request) returned null username in previous lines
_log.debug("Getting current session"); _log.debug("Getting current session");
HttpSession session = request.getSession(false); HttpSession session = request.getSession(false);
if (session == null) { if (session != null) {
_log.debug("Session is null, cannot continue");
return;
} else {
OIDCUmaUtil.checkUMATicketAndProvideInThreadLocal(request, (HttpServletResponse) resp, user, OIDCUmaUtil.checkUMATicketAndProvideInThreadLocal(request, (HttpServletResponse) resp, user,
session, scope); session, scope);
} else {
_log.debug("Session is null, cannot continue");
} }
//_log.trace("Security token set OK for " + username + " in scope " + scope); //_log.trace("Security token set OK for " + username + " in scope " + scope);