From 99b38ef4b73b3e274c5497f9fe23302dec12e474 Mon Sep 17 00:00:00 2001
From: Mauro Mugnaini <mauro.mugnaini@nubisware.com>
Date: Fri, 30 Apr 2021 08:27:46 +0200
Subject: [PATCH] Wrong extra return if session is null at check

---
 .../portal/threadlocalexec/SmartGearsPortalValve.java      | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/gcube/portal/threadlocalexec/SmartGearsPortalValve.java b/src/main/java/org/gcube/portal/threadlocalexec/SmartGearsPortalValve.java
index 8197001..a67f742 100644
--- a/src/main/java/org/gcube/portal/threadlocalexec/SmartGearsPortalValve.java
+++ b/src/main/java/org/gcube/portal/threadlocalexec/SmartGearsPortalValve.java
@@ -74,12 +74,11 @@ public class SmartGearsPortalValve extends ValveBase {
                     // user cannot be null otherwise also the getCurrentUsername(request) returned null username in previous lines
                     _log.debug("Getting current session");
                     HttpSession session = request.getSession(false);
-                    if (session == null) {
-                        _log.debug("Session is null, cannot continue");
-                        return;
-                    } else {
+                    if (session != null) {
                         OIDCUmaUtil.checkUMATicketAndProvideInThreadLocal(request, (HttpServletResponse) resp, user,
                                 session, scope);
+                    } else {
+                        _log.debug("Session is null, cannot continue");
                     }
 
                     //_log.trace("Security token set OK for " + username + " in scope " + scope);