gCubeSystem
/
maven-parent
14
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

New requirements and some eclipse issues when using Eclipse #6

Manually merged
luca.frosini merged 5 commits from resolve-eclipse-requirements into master 2020-08-03 11:25:18 +02:00
Conversation 4 Commits 5 Files Changed 1 +184 -17
manuele.simi commented 2020-07-26 15:50:48 +02:00
Contributor
Copy Link

The branch addresses and fixes the following:

  • manage custom files to then store into WEB-INF and META-INF
  • some files were not copied anymore into WEB-INF/META-INF
  • warning from plugins without an explicit version in Eclipse
  • bring make-uberjar back
The branch addresses and fixes the following: * manage custom files to then store into WEB-INF and META-INF * some files were not copied anymore into WEB-INF/META-INF * warning from plugins without an explicit version in Eclipse * bring make-uberjar back
luca.frosini was assigned by manuele.simi 2020-07-26 15:50:57 +02:00
luca.frosini was unassigned by manuele.simi 2020-07-26 15:50:59 +02:00
luca.frosini was assigned by manuele.simi 2020-07-26 15:51:04 +02:00
luca.frosini was unassigned by manuele.simi 2020-07-26 15:51:09 +02:00
luca.frosini was assigned by manuele.simi 2020-07-26 15:51:10 +02:00
luca.frosini commented 2020-07-28 15:25:39 +02:00
Owner
Copy Link

I still have the following error on eclipse:

Cannot parse lifecycle mapping metadata for maven project MavenProject: org.gcube.tools:maven-parent:1.1.0 @ /home/lucafrosini/.m2/repository/org/gcube/tools/maven-parent/1.1.0/maven-parent-1.1.0.pom Cause: Unrecognised tag: 'version' (position: START_TAG seen ...</artifactId>\n        <version>... @8:18)

The error was get for document-store-lib branch feature/19115 but it is the same on all projects.

I still have the following error on eclipse: ``` Cannot parse lifecycle mapping metadata for maven project MavenProject: org.gcube.tools:maven-parent:1.1.0 @ /home/lucafrosini/.m2/repository/org/gcube/tools/maven-parent/1.1.0/maven-parent-1.1.0.pom Cause: Unrecognised tag: 'version' (position: START_TAG seen ...</artifactId>\n <version>... @8:18) ``` The error was get for document-store-lib branch feature/19115 but it is the same on all projects.
luca.frosini commented 2020-07-31 17:30:44 +02:00
Owner
Copy Link

I found that at row 814 there is tag in place of

As indicated here, the issue affect many other users. Moreover seems that versione range is the correct tag to use.
https://stackoverflow.com/questions/7409823/m2e-lifecycle-mapping-not-found

Using versionRange solve the issue.
I'll reject this pull request and fix the branch with this tag.

Now, it has been emerged another issue:

Plugin execution not covered by lifecycle configuration: org.codehaus.gmaven:groovy-maven-plugin:2.0:execute (execution: default, phase: process-classes)

Commenting the following section I have no issues:

			<plugin>
				<groupId>org.codehaus.gmaven</groupId>
				<artifactId>groovy-maven-plugin</artifactId>
				<version>2.0</version>
				<executions>
					<execution>
						<phase>process-classes</phase>
						<goals>
							<goal>execute</goal>
						</goals>
						<configuration>
							<defaults>
								<name>tag</name>
							</defaults>
							<source>
								def fileContents = new File("${project.basedir}/CHANGELOG.md").getText('UTF-8')
								matcher = (fileContents =~ /(?s).\[v$project.version\].*?/)
								if (!matcher.find()) {
									throw new IllegalArgumentException("Tag [v$project.version] not found in ${project.basedir}/CHANGELOG.md")
								}
								assert matcher[0][1]:  "Tag [v$project.version] not found in ${project.basedir}/CHANGELOG.md"
							</source>
						</configuration>
					</execution>
				</executions>
			</plugin>

The problem is that groovy-maven-plugin is not defined in pluginManagement section.

https://stackoverflow.com/questions/6352208/how-to-solve-plugin-execution-not-covered-by-lifecycle-configuration-for-sprin

Event this is not an error in command line the pom is not properly configured.

I found that at row 814 there is <version> tag in place of <versionRange> As indicated here, the issue affect many other users. Moreover seems that versione range is the correct tag to use. https://stackoverflow.com/questions/7409823/m2e-lifecycle-mapping-not-found Using versionRange solve the issue. I'll reject this pull request and fix the branch with this tag. Now, it has been emerged another issue: ``` Plugin execution not covered by lifecycle configuration: org.codehaus.gmaven:groovy-maven-plugin:2.0:execute (execution: default, phase: process-classes) ``` Commenting the following section I have no issues: ``` <plugin> <groupId>org.codehaus.gmaven</groupId> <artifactId>groovy-maven-plugin</artifactId> <version>2.0</version> <executions> <execution> <phase>process-classes</phase> <goals> <goal>execute</goal> </goals> <configuration> <defaults> <name>tag</name> </defaults> <source> def fileContents = new File("${project.basedir}/CHANGELOG.md").getText('UTF-8') matcher = (fileContents =~ /(?s).\[v$project.version\].*?/) if (!matcher.find()) { throw new IllegalArgumentException("Tag [v$project.version] not found in ${project.basedir}/CHANGELOG.md") } assert matcher[0][1]: "Tag [v$project.version] not found in ${project.basedir}/CHANGELOG.md" </source> </configuration> </execution> </executions> </plugin> ``` The problem is that groovy-maven-plugin is not defined in pluginManagement section. https://stackoverflow.com/questions/6352208/how-to-solve-plugin-execution-not-covered-by-lifecycle-configuration-for-sprin Event this is not an error in command line the pom is not properly configured.
manuele.simi commented 2020-07-31 21:35:48 +02:00
Author
Contributor
Copy Link

Can you please add push the following two commits to the branch:

  1. use versionRange instead of range.
  2. declare the gmaven plugin in the pluginManagement of the pom.
Can you please add push the following two commits to the branch: 1. use versionRange instead of range. 2. declare the gmaven plugin in the pluginManagement of the pom.
luca.frosini closed this pull request 2020-08-03 11:25:18 +02:00
luca.frosini commented 2020-08-03 11:29:38 +02:00
Owner
Copy Link

@manuele.simi I did not fix the eclipse issue of gmaven plugin in the pluginManagement because I'm not sure about to properly do it.
I just disabled the error in Eclipse.

As you can see, I have accepted the pull request.

@manuele.simi I did not fix the eclipse issue of gmaven plugin in the pluginManagement because I'm not sure about to properly do it. I just disabled the error in Eclipse. As you can see, I have accepted the pull request.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
luca.frosini
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gCubeSystem/maven-parent#6
No description provided.
Delete Branch "resolve-eclipse-requirements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?