gCubeCI
/
gCubeDepsWalker
5
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

feature/21176 #1

Merged
roberto.cirillo merged 10 commits from feature/21176 into master 2021-11-18 16:15:02 +01:00
Conversation 1 Commits 10 Files Changed 1 +46
roberto.cirillo commented 2021-11-09 16:47:52 +01:00
Owner
Copy Link

see: #21176

see: #21176
manuele.simi was assigned by roberto.cirillo 2021-11-09 16:47:53 +01:00
roberto.cirillo added 9 commits 2021-11-09 16:47:53 +01:00
manuele.simi requested changes 2021-11-09 17:51:01 +01:00
manuele.simi left a comment
First-time contributor
Copy Link

Few minor changes, see comments.

Few minor changes, see comments.
Jenkinsfile Outdated
@ -13,0 +16,4 @@
environment {
AGENT_ROOT_FOLDER = "${agent_root_folder}"
PIPELINE_BUILD_NUMBER = "${env.BUILD_NUMBER}"
WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.md"
manuele.simi commented 2021-11-09 17:42:33 +01:00
First-time contributor
Copy Link
  1. I'd use PIPELINE_BUILD_NUMBER instead of inputProject to make the notes' filename unique.
  2. I don't see any markdown formatting in the report, I'd change the extension to .txt.
1. I'd use `PIPELINE_BUILD_NUMBER` instead of `inputProject` to make the notes' filename unique. 2. I don't see any markdown formatting in the report, I'd change the extension to `.txt`.
roberto.cirillo commented 2021-11-10 09:52:50 +01:00
Author
Owner
Copy Link

Thanks Manuele for your feedback!

  1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers.
    In order to preserve an unique filename as you suggest, I can add to the current filename, the PIPELINE_BUILD_NUMBER.

WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"

  1. you're absolutely right. I'm going to change it:

WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"

Thanks Manuele for your feedback! 1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers. In order to preserve an unique filename as you suggest, I can add to the current filename, the `PIPELINE_BUILD_NUMBER`. `WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"` 2. you're absolutely right. I'm going to change it: `WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"`
manuele.simi commented 2021-11-10 15:17:43 +01:00
First-time contributor
Copy Link

Thanks Manuele for your feedback!

  1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers.
    In order to preserve an unique filename as you suggest, I can add to the current filename, the PIPELINE_BUILD_NUMBER.

Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename.

Neverthlees, adding the pipeline number will make it unique.

WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"

  1. you're absolutely right. I'm going to change it:

WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"

> Thanks Manuele for your feedback! > > 1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers. > In order to preserve an unique filename as you suggest, I can add to the current filename, the `PIPELINE_BUILD_NUMBER`. Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename. Neverthlees, adding the pipeline number will make it unique. > > `WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"` > > 2. you're absolutely right. I'm going to change it: > > `WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"`
roberto.cirillo commented 2021-11-10 15:34:52 +01:00
Author
Owner
Copy Link

Thanks Manuele for your feedback!

  1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers.
    In order to preserve an unique filename as you suggest, I can add to the current filename, the PIPELINE_BUILD_NUMBER.

Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename.

OK I'm going to remove the component name from the filename

> > Thanks Manuele for your feedback! > > > > 1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers. > > In order to preserve an unique filename as you suggest, I can add to the current filename, the `PIPELINE_BUILD_NUMBER`. > > Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename. OK I'm going to remove the component name from the filename
manuele.simi marked this conversation as resolved
Jenkinsfile
@ -72,0 +105,4 @@
subject: "[JenkinsDependenciesWalker D4S] build ${currentBuild.fullDisplayName} failed for component ${inputProject}",
body: "Something is wrong with ${env.BUILD_URL}"
}
}
manuele.simi commented 2021-11-09 17:50:41 +01:00
First-time contributor
Copy Link

Nice post block, it looks familiar...

Nice post block, it looks familiar...
😆 1
manuele.simi marked this conversation as resolved
Jenkinsfile
@ -147,1 +186,4 @@
}
def appendNotes(report) {
sh("""#!/bin/bash
manuele.simi commented 2021-11-09 17:41:43 +01:00
First-time contributor
Copy Link

You don't need the shebang here.

You don't need the shebang here.
roberto.cirillo commented 2021-11-10 09:57:05 +01:00
Author
Owner
Copy Link

Are you referring to the bash shell?

I've used the bash shell otherwise the echo -e option doesn't work.

Is there an easier way to do that?

Are you referring to the bash shell? I've used the bash shell otherwise the `echo -e` option doesn't work. Is there an easier way to do that?
manuele.simi commented 2021-11-10 15:15:34 +01:00
First-time contributor
Copy Link

echo (without -e) works for sure without the shebang.

But if it does work for you, leave like that. It's a detail.

`echo` (without -e) works for sure without the shebang. But if it does work for you, leave like that. It's a detail.
roberto.cirillo commented 2021-11-10 15:37:46 +01:00
Author
Owner
Copy Link

echo (without -e) works for sure without the shebang.

But if it does work for you, leave like that. It's a detail.

Yes it works but without the "-e" option the backslashes are not escapes. The result is an unreadable file.

> `echo` (without -e) works for sure without the shebang. > > But if it does work for you, leave like that. It's a detail. > Yes it works but without the "-e" option the backslashes are not escapes. The result is an unreadable file.
manuele.simi marked this conversation as resolved
roberto.cirillo added 1 commit 2021-11-18 16:10:55 +01:00
roberto.cirillo changed title from feature/21176 to WIP: feature/21176 2021-11-18 16:13:09 +01:00
roberto.cirillo commented 2021-11-18 16:14:38 +01:00
Author
Owner
Copy Link

Sprry for the delay.
Changes done. I'm going to merge it into master

Sprry for the delay. Changes done. I'm going to merge it into master
roberto.cirillo changed title from WIP: feature/21176 to feature/21176 2021-11-18 16:14:55 +01:00
roberto.cirillo merged commit e1d7dfb658 into master 2021-11-18 16:15:02 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
manuele.simi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gCubeCI/gCubeDepsWalker#1
No description provided.
Delete Branch "feature/21176"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?