D-Net
/
openaire-graph-docs
6
1
Fork 5
Code Issues 5 Pull Requests 3 Packages Projects Releases 45 Wiki Activity

update of the deduplication section #4

Merged
schatz merged 5 commits from deduplication into main 2022-11-09 12:12:25 +01:00
Conversation 3 Commits 5 Files Changed 9 +200 -54
michele.debonis commented 2022-11-04 16:40:09 +01:00
Member
Copy Link

The update includes all the decision trees adopted for the research products and the description of the whole deduplication process.
Organization deduplication is still incomplete.

The update includes all the decision trees adopted for the research products and the description of the whole deduplication process. Organization deduplication is still incomplete.
michele.debonis added 2 commits 2022-11-04 16:40:09 +01:00
michele.debonis added 1 commit 2022-11-07 11:02:01 +01:00
michele.debonis commented 2022-11-07 11:03:24 +01:00
Author
Member
Copy Link

The organization deduplication section have been revised and completed.

The organization deduplication section have been revised and completed.
michele.debonis changed title from WIP: update of the deduplication section to update of the deduplication section 2022-11-07 11:03:35 +01:00
claudio.atzori added 1 commit 2022-11-08 10:13:06 +01:00
claudio.atzori added 1 commit 2022-11-08 10:53:12 +01:00
schatz commented 2022-11-08 14:44:15 +01:00
Member
Copy Link

Nice work! I am fine for this to be merged. My only thought is if it would be better to add a color (e.g., light blue like in the "data model" page) in the edges of the schemas so that they are visible when choosing the dark theme.

Nice work! I am fine for this to be merged. My only thought is if it would be better to add a color (e.g., light blue like in the "data model" page) in the edges of the schemas so that they are visible when choosing the dark theme.
claudio.atzori requested review from claudio.atzori 2022-11-08 17:45:34 +01:00
claudio.atzori requested review from schatz 2022-11-08 17:45:34 +01:00
schatz approved these changes 2022-11-08 17:58:02 +01:00
schatz left a comment
Member
Copy Link

As I said abocve, my only comment is if we can make the figures more friendly when selecting the dark theme. I think that the edges are the problem there, so may be can change their color to a light blue or something similar.
But, overall this PR seems fine to me.

As I said abocve, my only comment is if we can make the figures more friendly when selecting the dark theme. I think that the edges are the problem there, so may be can change their color to a light blue or something similar. But, overall this PR seems fine to me.
claudio.atzori commented 2022-11-09 09:42:15 +01:00
Owner
Copy Link

As I said abocve, my only comment is if we can make the figures more friendly when selecting the dark theme. I think that the edges are the problem there, so may be can change their color to a light blue or something similar.
But, overall this PR seems fine to me.

I agree Serafeim, a slight change could make the images a lot better. I already asked @michele.debonis to encorporate the links to the image sources (google drawings) in the md file as a comment, so that we will all know how to edit them.

> As I said abocve, my only comment is if we can make the figures more friendly when selecting the dark theme. I think that the edges are the problem there, so may be can change their color to a light blue or something similar. > But, overall this PR seems fine to me. I agree Serafeim, a slight change could make the images a lot better. I already asked @michele.debonis to encorporate the links to the image sources (google drawings) in the md file as a comment, so that we will all know how to edit them.
schatz merged commit 3f967bed99 into main 2022-11-09 12:12:25 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
claudio.atzori
schatz
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/openaire-graph-docs#4
No description provided.
Delete Branch "deduplication"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?