enrichment #20

Merged
schatz merged 4 commits from enrichment into main 1 year ago
Collaborator

Thi PR referes to the first version of the documentation of the enrichment section regarding bulktagging and propagation

Thi PR referes to the first version of the documentation of the enrichment section regarding bulktagging and propagation
miriam.baglioni added 3 commits 1 year ago
schatz commented 1 year ago
Collaborator

Seems overall very good. I have the following minor comments:

  • Do we want to split the content in sub-pages for Mining, Bulk Tagging/Deduction, and Propagtion? If yes, we have already two sub-items of this page, namely Mining algorithms and Impact indicators. Any ideas on how we can restructure this? @claudio.atzori @thanasis.vergoulis
  • Images look very good but we had a comment from Androniki in the past that some figures do not look pretty when choosing the dark theme. The same holds for those; so if we want to support the option for the dark theme, we should probably change the (black) color of text without a background as well as the color of the edges with something else (e.g. ligh blue) as done in Deduplication.
Seems overall very good. I have the following minor comments: - Do we want to split the content in sub-pages for Mining, Bulk Tagging/Deduction, and Propagtion? If yes, we have already two sub-items of this page, namely Mining algorithms and Impact indicators. Any ideas on how we can restructure this? @claudio.atzori @thanasis.vergoulis - Images look very good but we had a comment from Androniki in the past that some figures do not look pretty when choosing the dark theme. The same holds for those; so if we want to support the option for the dark theme, we should probably change the (black) color of text without a background as well as the color of the edges with something else (e.g. ligh blue) as done in [Deduplication](http://snf-23385.ok-kno.grnetcloud.net/data-provision/deduplication/research-products).
Collaborator

We are not going to support dark theme. I think it is too much. Let's keep the diagrams unchanged.

Regarding the first subject: I would suggest to go with one layer of sub-pages: Mining, Bulg Tagging/Deduplication, Propagation, Impact indicators

All of them go under Enrichment. Right? What do you think? @claudio.atzori @schatz

We are not going to support dark theme. I think it is too much. Let's keep the diagrams unchanged. Regarding the first subject: I would suggest to go with one layer of sub-pages: Mining, Bulg Tagging/Deduplication, Propagation, Impact indicators All of them go under Enrichment. Right? What do you think? @claudio.atzori @schatz
Owner

We are not going to support dark theme. I think it is too much. Let's keep the diagrams unchanged.

I agree, we could postpone those changes for a later release.

Regarding the first subject: I would suggest to go with one layer of sub-pages: Mining, Bulg Tagging/Deduplication, Propagation, Impact indicators

All of them go under Enrichment. Right? What do you think? @claudio.atzori @schatz

Consider that most of the text currently available in the enrichment page under the mining section will be moved under the respective mining module page. So, all these new contributions describe enrichment processes, so IMO they would fit well in dedicated subpages. Moreover, doing so, the enrichment page could be autogenerated and provide the overview of the subsections.

So @miriam.baglioni could you please restructure the Bulk Tagging/Deduction and the Propagation into subpages?

> We are not going to support dark theme. I think it is too much. Let's keep the diagrams unchanged. I agree, we could postpone those changes for a later release. > Regarding the first subject: I would suggest to go with one layer of sub-pages: Mining, Bulg Tagging/Deduplication, Propagation, Impact indicators > > All of them go under Enrichment. Right? What do you think? @claudio.atzori @schatz Consider that most of the text currently available in the enrichment page under the mining section will be moved under the respective mining module page. So, all these new contributions describe enrichment processes, so IMO they would fit well in dedicated subpages. Moreover, doing so, the enrichment page could be autogenerated and provide the overview of the subsections. So @miriam.baglioni could you please restructure the Bulk `Tagging/Deduction` and the `Propagation` into subpages?
schatz added 1 commit 1 year ago
schatz commented 1 year ago
Collaborator

After all, I have split the "enrichment" page in sub-pages for Bulk tagging and Propagation.
The "Mining" section was just a placeholder from the graph.openaire.eu website that I have used when creating the structure, so I have removed it.

IMO this PR is ready to be merged now.

After all, I have split the "enrichment" page in sub-pages for Bulk tagging and Propagation. The "Mining" section was just a placeholder from the graph.openaire.eu website that I have used when creating the structure, so I have removed it. IMO this PR is ready to be merged now.
schatz merged commit 01e4744550 into main 1 year ago
The pull request has been merged as 01e4744550.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b enrichment main
git pull origin enrichment

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff enrichment
git push origin main
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/openaire-graph-docs#20
Loading…
There is no content yet.