enrichment #20

miriam.baglioni · 2022-11-23T14:04:06+01:00

miriam.baglioni commented

2022-11-23 14:04:06 +01:00

Thi PR referes to the first version of the documentation of the enrichment section regarding bulktagging and propagation

miriam.baglioni added 3 commits 2022-11-23 14:04:07 +01:00

1669c7a5fe [Enrichment] first version of documentation for the bulktagging and part of the propagation

6a773cfe1a [Enrichment] first version for propagation finished

b14f89a845 merging with main

schatz commented

2022-11-29 12:33:03 +01:00

Seems overall very good. I have the following minor comments:

Do we want to split the content in sub-pages for Mining, Bulk Tagging/Deduction, and Propagtion? If yes, we have already two sub-items of this page, namely Mining algorithms and Impact indicators. Any ideas on how we can restructure this? @claudio.atzori @thanasis.vergoulis
Images look very good but we had a comment from Androniki in the past that some figures do not look pretty when choosing the dark theme. The same holds for those; so if we want to support the option for the dark theme, we should probably change the (black) color of text without a background as well as the color of the edges with something else (e.g. ligh blue) as done in Deduplication.

Seems overall very good. I have the following minor comments: - Do we want to split the content in sub-pages for Mining, Bulk Tagging/Deduction, and Propagtion? If yes, we have already two sub-items of this page, namely Mining algorithms and Impact indicators. Any ideas on how we can restructure this? @claudio.atzori @thanasis.vergoulis - Images look very good but we had a comment from Androniki in the past that some figures do not look pretty when choosing the dark theme. The same holds for those; so if we want to support the option for the dark theme, we should probably change the (black) color of text without a background as well as the color of the edges with something else (e.g. ligh blue) as done in [Deduplication](http://snf-23385.ok-kno.grnetcloud.net/data-provision/deduplication/research-products).

thanasis.vergoulis commented

2022-11-29 20:12:25 +01:00

We are not going to support dark theme. I think it is too much. Let's keep the diagrams unchanged.

Regarding the first subject: I would suggest to go with one layer of sub-pages: Mining, Bulg Tagging/Deduplication, Propagation, Impact indicators

All of them go under Enrichment. Right? What do you think? @claudio.atzori @schatz

We are not going to support dark theme. I think it is too much. Let's keep the diagrams unchanged. Regarding the first subject: I would suggest to go with one layer of sub-pages: Mining, Bulg Tagging/Deduplication, Propagation, Impact indicators All of them go under Enrichment. Right? What do you think? @claudio.atzori @schatz

claudio.atzori commented

2022-11-30 09:57:40 +01:00

We are not going to support dark theme. I think it is too much. Let's keep the diagrams unchanged.

I agree, we could postpone those changes for a later release.

Regarding the first subject: I would suggest to go with one layer of sub-pages: Mining, Bulg Tagging/Deduplication, Propagation, Impact indicators

All of them go under Enrichment. Right? What do you think? @claudio.atzori @schatz

Consider that most of the text currently available in the enrichment page under the mining section will be moved under the respective mining module page. So, all these new contributions describe enrichment processes, so IMO they would fit well in dedicated subpages. Moreover, doing so, the enrichment page could be autogenerated and provide the overview of the subsections.

So @miriam.baglioni could you please restructure the Bulk Tagging/Deduction and the Propagation into subpages?

> We are not going to support dark theme. I think it is too much. Let's keep the diagrams unchanged. I agree, we could postpone those changes for a later release. > Regarding the first subject: I would suggest to go with one layer of sub-pages: Mining, Bulg Tagging/Deduplication, Propagation, Impact indicators > > All of them go under Enrichment. Right? What do you think? @claudio.atzori @schatz Consider that most of the text currently available in the enrichment page under the mining section will be moved under the respective mining module page. So, all these new contributions describe enrichment processes, so IMO they would fit well in dedicated subpages. Moreover, doing so, the enrichment page could be autogenerated and provide the overview of the subsections. So @miriam.baglioni could you please restructure the Bulk `Tagging/Deduction` and the `Propagation` into subpages?

schatz added 1 commit 2022-11-30 17:09:33 +01:00

7c12a37f11 Split the enrichment section in sub-pages

schatz commented

2022-11-30 17:11:07 +01:00

After all, I have split the "enrichment" page in sub-pages for Bulk tagging and Propagation.
The "Mining" section was just a placeholder from the graph.openaire.eu website that I have used when creating the structure, so I have removed it.

IMO this PR is ready to be merged now.

After all, I have split the "enrichment" page in sub-pages for Bulk tagging and Propagation. The "Mining" section was just a placeholder from the graph.openaire.eu website that I have used when creating the structure, so I have removed it. IMO this PR is ready to be merged now.

schatz merged commit 01e4744550 into main

2022-12-01 13:41:26 +01:00

schatz referenced this issue from a commit

2022-12-01 13:41:26 +01:00

Merge pull request 'enrichment' (#20) from enrichment into main

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/openaire-graph-docs#20