Crossref Enhancements: #511

sandro.labruzzo · 2024-11-19T14:59:50+01:00

sandro.labruzzo commented

2024-11-19 14:59:50 +01:00

Accurate Review Type Assignment: Resolved an issue identified in ticket https://support.openaire.eu/issues/9525#note-13. When a relationship of "is-review-of" is detected, the publication type is now correctly set to "Review."
Enhanced Author Affiliation Data: Implemented Miriam's suggestion by including a new field, "RawAffiliationString," in each author entry. This additional data provides a more granular level of detail regarding author affiliations, potentially improving discoverability and research analysis.

- **Accurate Review Type Assignment**: Resolved an issue identified in ticket https://support.openaire.eu/issues/9525#note-13. When a relationship of "_is-review-of_" is detected, the publication type is now correctly set to "**Review**." - **Enhanced Author Affiliation Data**: Implemented Miriam's suggestion by including a new field, "RawAffiliationString," in each author entry. This additional data provides a more granular level of detail regarding author affiliations, potentially improving discoverability and research analysis.

claudio.atzori was assigned by sandro.labruzzo

2024-11-19 14:59:50 +01:00

alessia.bardi was assigned by sandro.labruzzo

2024-11-19 14:59:50 +01:00

miriam.baglioni was assigned by sandro.labruzzo

2024-11-19 14:59:50 +01:00

sandro.labruzzo added 1 commit 2024-11-19 14:59:51 +01:00

a1297082e2 Crossref Enhancements:

-Accurate Review Type Assignment: Resolved an issue identified in ticket https://support.openaire.eu/issues/9525#note-13. When a relationship of "is-review-of" is detected, the publication type is now correctly set to "Review."
-Enhanced Author Affiliation Data: Implemented Miriam's suggestion by including a new field, "RawAffiliationString," in each author entry. This additional data provides a more granular level of detail regarding author affiliations, potentially improving discoverability and research analysis.

alessia.bardi reviewed 2024-11-19 15:23:19 +01:00

alessia.bardi left a comment

In the dscription of the PR you do not mention that you are removing the code that creates the instance from Unpaywall.
If the removal of that functioanlity was planned, then add it to description of the PR.

In the dscription of the PR you do not mention that you are removing the code that creates the instance from Unpaywall. If the removal of that functioanlity was planned, then add it to description of the PR.

dhp-workflows/dhp-aggregation/src/main/scala/eu/dnetlib/dhp/collection/crossref/Crossref2Oaf.scala Outdated

						
				@ -757,33 +761,6 @@ case object Crossref2Oaf {

				      else

				        resultList

				    }

alessia.bardi commented

2024-11-19 15:19:14 +01:00

You are removing the code that adds the instance from Unpaywall.
There was no reference to this change in the description of the PR.
If the removal of this functioality was planned, please include it in the PR description

You are removing the code that adds the instance from Unpaywall. There was no reference to this change in the description of the PR. If the removal of this functioality was planned, please include it in the PR description

sandro.labruzzo commented

2024-11-19 15:31:14 +01:00

You are removing the code that adds the instance from Unpaywall.
There was no reference to this change in the description of the PR.
If the removal of this functioality was planned, please include it in the PR description

The code was already removed and commented on, the unpaywall mapping comes in another section, I've deleted the commented code

> You are removing the code that adds the instance from Unpaywall. > There was no reference to this change in the description of the PR. > If the removal of this functioality was planned, please include it in the PR description The code was already removed and commented on, the unpaywall mapping comes in another section, I've deleted the commented code

sandro.labruzzo marked this conversation as resolved

miriam.baglioni commented

2024-11-19 16:29:05 +01:00

Sandro I added new funders mappings that are missing in this version of the code.
I would add some Assertions in the test instead of the prettyPrint :)

Sandro I added new funders mappings that are missing in this version of the code. I would add some Assertions in the test instead of the prettyPrint :)

sandro.labruzzo commented

2024-11-20 09:42:44 +01:00

Sandro I added new funders mappings that are missing in this version of the code.
I would add some Assertions in the test instead of the prettyPrint :)

Where did you add this mapping @miriam.baglioni ?
I branched beta, so if you added it only on the master branch, please merge the same commit here or in beta, and let me know.
While I'm changing the tests.

> Sandro I added new funders mappings that are missing in this version of the code. > I would add some Assertions in the test instead of the prettyPrint :) Where did you add this mapping @miriam.baglioni ? I branched beta, so if you added it only on the master branch, please merge the same commit here or in beta, and let me know. While I'm changing the tests.

sandro.labruzzo added 1 commit 2024-11-20 09:50:21 +01:00

496007188a Added assertion on CrossrefMappingTest

sandro.labruzzo added 1 commit 2024-11-20 09:54:23 +01:00

ac8995ab64 Merge remote-tracking branch 'origin/beta' into crossref_mapping_improvement

sandro.labruzzo changed target branch from dedup_new_comparators to beta

2024-11-20 10:35:12 +01:00

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

You can also view command line instructions.