D-Net
/
dnet-hadoop
13
4
Fork 10
Code Issues 14 Pull Requests 9 Projects 2 Releases 1 Wiki Activity

dump #50

Merged
claudio.atzori merged 98 commits from miriam.baglioni/dnet-hadoop:dump into master 2020-11-04 18:07:01 +01:00
Conversation 1 Commits 98 Files Changed 51 +950 -923
miriam.baglioni commented 2020-11-04 10:26:00 +01:00
Member
Copy Link

changes in this PR:

  • Class to create an archive moved to common module. It is now possible to specify the maz size in GB of each archive to be created
  • changed the parameter for the upload in Zenodo. Now we have three possible values for the uload:
    • new for a brand new deposition
    • version for a new version of an old deposition (the concept record id is needed in this case)
    • upload to continue uploading a not yet published deposition (deposition id needed in this case)
changes in this PR: - Class to create an archive moved to common module. It is now possible to specify the maz size in GB of each archive to be created - changed the parameter for the upload in Zenodo. Now we have three possible values for the uload: - new for a brand new deposition - version for a new version of an old deposition (the concept record id is needed in this case) - upload to continue uploading a not yet published deposition (deposition id needed in this case)
miriam.baglioni added the
enhancement
 label 2020-11-04 10:26:00 +01:00
sandro.labruzzo was assigned by miriam.baglioni 2020-11-04 10:26:00 +01:00
claudio.atzori was assigned by miriam.baglioni 2020-11-04 10:26:00 +01:00
claudio.atzori reviewed 2020-11-04 16:51:39 +01:00
dhp-workflows/dhp-graph-mapper/src/main/java/eu/dnetlib/dhp/oa/graph/dump/MakeTar.java Outdated
@ -110,3 +73,1 @@
ar.close();
}
// private static TarArchiveOutputStream getTar(FileSystem fileSystem, String outputPath) throws IOException {
claudio.atzori commented 2020-11-04 16:51:39 +01:00
Owner
Copy Link

Please delete commented code. It was factored out in the MakeTar utility class, right?

Please delete commented code. It was factored out in the MakeTar utility class, right?
claudio.atzori reviewed 2020-11-04 16:54:07 +01:00
dhp-workflows/dhp-graph-mapper/src/main/java/eu/dnetlib/dhp/oa/graph/dump/ResultMapper.java Outdated
@ -381,0 +398,4 @@
}
private static <I extends Instance> void setCommonValue(eu.dnetlib.dhp.schema.oaf.Instance i, I instance) {// <I
// extends
claudio.atzori commented 2020-11-04 16:54:07 +01:00
Owner
Copy Link

further comments to drop

further comments to drop
claudio.atzori requested changes 2020-11-04 16:56:51 +01:00
claudio.atzori left a comment
Owner
Copy Link

Please move all the PidGraph stuff in a different branch.

Please move all the PidGraph stuff in a different branch.
miriam.baglioni commented 2020-11-04 17:18:00 +01:00
Author
Member
Copy Link

Check it now. I have removed the pid graph dump stuff and also the commented lines

Check it now. I have removed the pid graph dump stuff and also the commented lines
claudio.atzori closed this pull request 2020-11-04 18:07:01 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
claudio.atzori
sandro.labruzzo
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#50
No description provided.
Delete Branch "miriam.baglioni/dnet-hadoop:dump"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?