D-Net
/
dnet-hadoop
15
4
Fork 10
Code Issues 14 Pull Requests 8 Projects 2 Releases 1 Wiki Activity

fix import of ORPs #390

Merged
claudio.atzori merged 2 commits from import_orps_fix into beta 2024-02-15 15:02:08 +01:00
Conversation 1 Commits 2 Files Changed 3 +15 -2
claudio.atzori commented 2024-02-07 17:08:25 +01:00
Owner
Copy Link

This PR fixes a bug that caused to miss importing the ORP records stored HDFS in the internal graph format (e.g. Datacite). This was due to the fact to understand the result type, the field value stored in result.resulttype.classid.

is set to other was compared with otherresearchproduct, implying that the filter would never match and therefore causing the exclusion of all the ORP records.

This PR fixes a bug that caused to miss importing the ORP records stored HDFS in the internal graph format (e.g. Datacite). This was due to the fact to understand the result type, the field value stored in `result.resulttype.classid`. is set to `other` was compared with `otherresearchproduct`, implying that the filter would never match and therefore causing the exclusion of all the ORP records.
claudio.atzori added 1 commit 2024-02-07 17:08:26 +01:00
claudio.atzori commented 2024-02-07 17:09:07 +01:00
Author
Owner
Copy Link

I still have to verify that all the unit tests keep passing after this change.

I still have to verify that all the unit tests keep passing after this change.
claudio.atzori changed title from fixed import of ORPs stored on HDFS in the internal graph format (e.g. Datacite) to WIP: fix import of ORPs 2024-02-07 17:09:31 +01:00
claudio.atzori changed title from WIP: fix import of ORPs to fix import of ORPs 2024-02-15 14:26:02 +01:00
claudio.atzori added 1 commit 2024-02-15 15:01:58 +01:00
claudio.atzori merged commit 753c2a72bd into beta 2024-02-15 15:02:08 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#390
No description provided.
Delete Branch "import_orps_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?