D-Net
/
dnet-hadoop
13
4
Fork 10
Code Issues 14 Pull Requests 8 Projects 2 Releases 1 Wiki Activity

extended existing code to import of POCI from open citation #340

Merged
claudio.atzori merged 4 commits from importpoci into beta 2023-10-03 10:52:12 +02:00
Conversation 2 Commits 4 Files Changed 7 +110 -79
miriam.baglioni commented 2023-10-02 09:30:42 +02:00
Member
Copy Link

This PR extends the code to import the OC COCI to include also POCI.
Differences:

  • the folder where to store the data is moved to /data/OCitations and then C2C for COCI and P2P for POCI
  • a new parameter prefix is added to diffentiate between the two sets:
    COCI for COCI and POCI for POCI
This PR extends the code to import the OC COCI to include also POCI. Differences: * the folder where to store the data is moved to `/data/OCitations` and then C2C for COCI and P2P for POCI * a new parameter **prefix** is added to diffentiate between the two sets: **COCI** for COCI and **POCI** for POCI
claudio.atzori was assigned by miriam.baglioni 2023-10-02 09:30:42 +02:00
miriam.baglioni added 1 commit 2023-10-02 09:30:43 +02:00
claudio.atzori commented 2023-10-02 10:08:48 +02:00
Owner
Copy Link

Thanks Miriam, it looks generaly good. I would just ensure to make two datasets (COCI and POCI) converge into the already existing actionset, i.e. without needing to create a new actionset for POCI.

This PR extends the code to import the OC COCI to include also POCI.
Differences:

  • the folder where to store the data is modev to /data/OCitations and then C2C for COCI and P2P for POCI

Why don't you use directory names that better reflect the dataset names? I would suggest using COCI and POCI as directory names.

Thanks Miriam, it looks generaly good. I would just ensure to make two datasets (COCI and POCI) converge into the already existing actionset, i.e. without needing to create a new actionset for POCI. > This PR extends the code to import the OC COCI to include also POCI. > Differences: > > * the folder where to store the data is modev to /data/OCitations and then C2C for COCI and P2P for POCI Why don't you use directory names that better reflect the dataset names? I would suggest using COCI and POCI as directory names.
miriam.baglioni added 2 commits 2023-10-02 14:12:08 +02:00
claudio.atzori added 1 commit 2023-10-03 10:43:55 +02:00
claudio.atzori commented 2023-10-03 10:52:07 +02:00
Owner
Copy Link

LGTM, let's proceed with the actual tests on beta.

LGTM, let's proceed with the actual tests on beta.
claudio.atzori merged commit f344ad76d0 into beta 2023-10-03 10:52:12 +02:00
claudio.atzori added this to the OpenAIRE - DNet project 2023-10-26 10:00:45 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
OpenAIRE - DNet
Assignees
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#340
No description provided.
Delete Branch "importpoci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?