D-Net
/
dnet-hadoop
13
4
Fork 10
Code Issues 14 Pull Requests 8 Projects 2 Releases 1 Wiki Activity

islookup_timeout #30

Merged
claudio.atzori merged 3 commits from islookup_timeout into master 2020-07-28 13:53:13 +02:00
Conversation 1 Commits 3 Files Changed 1 +30 -4
claudio.atzori commented 2020-07-27 17:52:25 +02:00
Owner
Copy Link

This PR includes the possibility to set connectTimeout and requestTimeout in the isLookUp service stub. Further extensions might add the possibility to pass the timeout values as parameters, as well as to cover more alternative implementations for the service instance (currently only javax.xml.ws.BindingProvider is supported)

This PR includes the possibility to set `connectTimeout` and `requestTimeout` in the isLookUp service stub. Further extensions might add the possibility to pass the timeout values as parameters, as well as to cover more alternative implementations for the service instance (currently only `javax.xml.ws.BindingProvider` is supported)
michele.artini was assigned by claudio.atzori 2020-07-27 17:52:25 +02:00
miriam.baglioni was assigned by claudio.atzori 2020-07-27 17:52:25 +02:00
michele.artini commented 2020-07-28 12:49:59 +02:00
Member
Copy Link

I tested the patch in a simple wf (import claims from db).

The IS query have been regularly executed and the logs contain the following lines:

2020-07-28 10:37:12,417 INFO [main] eu.dnetlib.dhp.utils.ISLookupClientFactory: creating eu.dnetlib.enabling.is.lookup.rmi.ISLookUpService stub from http://beta.services.openaire.eu
:8280/is/services/isLookUp?wsdl
2020-07-28 10:37:12,721 INFO [main] org.apache.cxf.wsdl.service.factory.ReflectionServiceFactoryBean: Creating Service {http://services.dnetlib.eu/}ISLookUpServiceService from class
 eu.dnetlib.enabling.is.lookup.rmi.ISLookUpService
2020-07-28 10:37:13,815 INFO [main] eu.dnetlib.dhp.utils.ISLookupClientFactory: setting timeouts for javax.xml.ws.BindingProvider to requestTimeout: 600000, connectTimeout: 600000

In particular the last line indicates that the service is an instance of BindingProvider.

For me, the PR can be accepted.

I tested the patch in a simple wf (import claims from db). The IS query have been regularly executed and the logs contain the following lines: ``` 2020-07-28 10:37:12,417 INFO [main] eu.dnetlib.dhp.utils.ISLookupClientFactory: creating eu.dnetlib.enabling.is.lookup.rmi.ISLookUpService stub from http://beta.services.openaire.eu :8280/is/services/isLookUp?wsdl 2020-07-28 10:37:12,721 INFO [main] org.apache.cxf.wsdl.service.factory.ReflectionServiceFactoryBean: Creating Service {http://services.dnetlib.eu/}ISLookUpServiceService from class eu.dnetlib.enabling.is.lookup.rmi.ISLookUpService 2020-07-28 10:37:13,815 INFO [main] eu.dnetlib.dhp.utils.ISLookupClientFactory: setting timeouts for javax.xml.ws.BindingProvider to requestTimeout: 600000, connectTimeout: 600000 ``` In particular the last line indicates that the service is an instance of **BindingProvider**. For me, the PR can be accepted.
claudio.atzori closed this pull request 2020-07-28 13:53:13 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
miriam.baglioni
michele.artini
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#30
No description provided.
Delete Branch "islookup_timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?