D-Net
/
dnet-hadoop
15
4
Fork 10
Code Issues 14 Pull Requests 8 Projects 2 Releases 1 Wiki Activity

Labels Milestones

[metadata transformation] better error handling in XSLT transformation #253

Open
claudio.atzori wants to merge 3 commits from transformation_wf into beta
pull from: transformation_wf
merge into: D-Net:beta
Conversation 1 Commits 3 Files Changed 4
claudio.atzori commented 2 years ago
Owner

This PR addresses #252 by improving the error handling in the XSLT-based transformation workflow, separating the XSLT creation errors from the XSLT application, and letting the 1st propagate. Furthermore, every error is gathered in the AggregationReport object and reported back to the MSRO.

This PR addresses #252 by improving the error handling in the XSLT-based transformation workflow, separating the XSLT creation errors from the XSLT application, and letting the 1st propagate. Furthermore, every error is gathered in the `AggregationReport` object and reported back to the MSRO.
claudio.atzori added the
enhancement
bug
 labels 2 years ago
claudio.atzori self-assigned this 2 years ago
claudio.atzori added 1 commit 2 years ago
claudio.atzori added 1 commit 2 years ago
claudio.atzori requested review from sandro.labruzzo 2 years ago
claudio.atzori requested review from alessia.bardi 2 years ago
alessia.bardi commented 2 years ago
Owner

Let's test how it goes, to make sure

  • we do not get any unexpected null pointers for the counters in the report
  • the transformation fails at the first record in case the mapping is not well formed
Let's test how it goes, to make sure - we do not get any unexpected null pointers for the counters in the report - the transformation fails at the first record in case the mapping is not well formed
claudio.atzori added 1 commit 2 years ago

Reviewers

sandro.labruzzo was requested for review 2 years ago
alessia.bardi was requested for review 2 years ago
This pull request has changes conflicting with the target branch.
  • dhp-workflows/dhp-aggregation/src/main/java/eu/dnetlib/dhp/transformation/xslt/XSLTTransformationFunction.java
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b transformation_wf beta
git pull origin transformation_wf

Step 2:

Merge the changes and update on Gitea.
git checkout beta
git merge --no-ff transformation_wf
git push origin beta
Sign in to join this conversation.
Reviewers
Request review
No reviewers
sandro.labruzzo
alessia.bardi
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature / refactoring   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
RDGraph

EOSC Research Discovery Graph   
RSAC

EOSC Research Software APIs and Connectors   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#253
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'transformation_wf'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes