D-Net
/
dnet-hadoop
14
5
Fork 11
Code Issues 14 Pull Requests 13 Projects 2 Releases 2 Wiki Activity

#7861#note-8 instance url from handle #243

Merged
claudio.atzori merged 4 commits from handle_as_instance_urls into beta 2022-09-09 12:19:18 +02:00
Conversation 0 Commits 4 Files Changed 3 +35 -46
alessia.bardi commented 2022-09-07 16:34:08 +02:00
Owner
Copy Link

See ticket https://support.openaire.eu/issues/7861#note-8: we have many results with no instance in the index because they are without an instance url in the graph. With this fix we should cover the missing instances for repositories that provide a handle.
An example is https://explore.openaire.eu/search/publication?articleId=od______1560::8f7a139735f493882bb0f4abceb6e200

I have also changed the DOI prefix used in the class: we can use https://doi.org/ instead of https://dx.doi.org/ .

See ticket https://support.openaire.eu/issues/7861#note-8: we have many results with no instance in the index because they are without an instance url in the graph. With this fix we should cover the missing instances for repositories that provide a handle. An example is https://explore.openaire.eu/search/publication?articleId=od______1560::8f7a139735f493882bb0f4abceb6e200 I have also changed the DOI prefix used in the class: we can use https://doi.org/ instead of https://dx.doi.org/ .
alessia.bardi added 1 commit 2022-09-07 16:34:10 +02:00
alessia.bardi requested review from claudio.atzori 2022-09-07 16:34:25 +02:00
claudio.atzori was assigned by alessia.bardi 2022-09-07 16:34:36 +02:00
claudio.atzori reviewed 2022-09-09 08:49:49 +02:00
dhp-workflows/dhp-graph-mapper/src/main/java/eu/dnetlib/dhp/oa/graph/raw/OdfToOafMapper.java Outdated
@ -27,2 +27,3 @@
public static final String HTTP_DX_DOI_PREIFX = "https://dx.doi.org/";
public static final String HTTP_DOI_PREIFX = "https://doi.org/";
public static final String HTTP_HANDLE_PREIFX = "http://hdl.handle.net/";
claudio.atzori commented 2022-09-09 08:49:49 +02:00
Owner
Copy Link

Why not declaring https also for the handle resolver?

Why not declaring https also for the handle resolver?
claudio.atzori marked this conversation as resolved
claudio.atzori requested changes 2022-09-09 08:51:17 +02:00
claudio.atzori left a comment
Owner
Copy Link

Overall I'm OK with this PR, just a minor comment, see it inline.

Overall I'm OK with this PR, just a minor comment, see it inline.
claudio.atzori added 1 commit 2022-09-09 09:47:20 +02:00
alessia.bardi added 2 commits 2022-09-09 12:17:40 +02:00
claudio.atzori merged commit 690be4482f into beta 2022-09-09 12:19:17 +02:00
claudio.atzori deleted branch handle_as_instance_urls 2022-09-09 12:19:27 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
claudio.atzori
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#243
No description provided.
Delete Branch "handle_as_instance_urls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?