D-Net
/
dnet-hadoop
14
5
Fork 11
Code Issues 14 Pull Requests 10 Projects 2 Releases 2 Wiki Activity

score class in the XML serialization #225

Merged
claudio.atzori merged 1 commits from measure_serialization into beta 2022-07-01 10:53:49 +02:00
Conversation 2 Commits 1 Files Changed 3 +188 -17
claudio.atzori commented 2022-07-01 10:01:11 +02:00
Owner
Copy Link

This PR includes the class information in the measure XML serialization, which changes from

  <measure id="influence" key="score" value="5.06690394631e-09"/>
  <measure id="popularity_alt" key="score" value="0.0"/>
  <measure id="popularity"  key="score" value="3.11855618382e-09"/>
  <measure id="influence_alt"  key="score" value="0.0"/>
  <measure id="impulse"  key="score" value="0.0"/>

to

  <measure id="influence" score="5.06690394631e-09" class="C"/>
  <measure id="popularity_alt" score="0.0" class="C"/>
  <measure id="popularity" score="3.11855618382e-09" class="C"/>
  <measure id="influence_alt" score="0.0" class="C"/>
  <measure id="impulse" score="0.0" class="C"/>

Note also that the attributes are renamed, I think the updated serialisation is simpler.

This PR includes the class information in the measure XML serialization, which changes from ``` <measure id="influence" key="score" value="5.06690394631e-09"/> <measure id="popularity_alt" key="score" value="0.0"/> <measure id="popularity" key="score" value="3.11855618382e-09"/> <measure id="influence_alt" key="score" value="0.0"/> <measure id="impulse" key="score" value="0.0"/> ``` to ``` <measure id="influence" score="5.06690394631e-09" class="C"/> <measure id="popularity_alt" score="0.0" class="C"/> <measure id="popularity" score="3.11855618382e-09" class="C"/> <measure id="influence_alt" score="0.0" class="C"/> <measure id="impulse" score="0.0" class="C"/> ``` Note also that the attributes are renamed, I think the updated serialisation is simpler.
claudio.atzori added the
enhancement
 label 2022-07-01 10:01:11 +02:00
alessia.bardi was assigned by claudio.atzori 2022-07-01 10:01:11 +02:00
miriam.baglioni was assigned by claudio.atzori 2022-07-01 10:01:11 +02:00
claudio.atzori added 1 commit 2022-07-01 10:01:12 +02:00
alessia.bardi commented 2022-07-01 10:33:04 +02:00
Owner
Copy Link

I am not familiar with the exact input provided by BIP!Finder, but I think this PR is ok.

I am not familiar with the exact input provided by BIP!Finder, but I think this PR is ok.
miriam.baglioni commented 2022-07-01 10:52:47 +02:00
Member
Copy Link

The PR is ok to me as well

The PR is ok to me as well
claudio.atzori merged commit 138d1dfbf8 into beta 2022-07-01 10:53:49 +02:00
claudio.atzori deleted branch measure_serialization 2022-07-01 10:53:56 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
alessia.bardi
miriam.baglioni
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#225
No description provided.
Delete Branch "measure_serialization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?