participant project contribution #223

claudio.atzori · 2022-06-24T17:29:43+02:00

claudio.atzori commented

2022-06-24 17:29:43 +02:00

This PR extends the mapping applied to the aggregator's DB content to include the individual montary contribution for each project partner, which becomes a property of the project - organization relation.

A side consideration: in case of false positives produced by the Organization deduplication, we might end up merging different relationships bearing this information. IT WOULD BE A MISTAKE TO MERGE THEM, therefore in case of such event, the most reasonable approach seems to be a conservative one: not set any contribution information.

This PR extends the mapping applied to the aggregator's DB content to include the individual montary contribution for each project partner, which becomes a property of the `project - organization` relation. A side consideration: in case of false positives produced by the Organization deduplication, we might end up merging different relationships bearing this information. **`IT WOULD BE A MISTAKE TO MERGE THEM`**, therefore in case of such event, the most reasonable approach seems to be a conservative one: not set any contribution information.

claudio.atzori added the

enhancement

label 2022-06-24 17:29:43 +02:00

claudio.atzori added 1 commit 2022-06-24 17:29:44 +02:00

5130eac247 mapping by participant project contribution

claudio.atzori requested review from alessia.bardi 2022-06-24 17:29:50 +02:00

claudio.atzori requested review from miriam.baglioni 2022-06-24 17:29:54 +02:00

claudio.atzori added 1 commit 2022-06-27 09:37:42 +02:00

a8773af0cb Merge branch 'beta' into project_organization_contribution

miriam.baglioni commented

2022-06-27 10:14:45 +02:00

I think the PR can be merged. Only one consideration: you say that when more than one organization bring information about the funded amount it would be safer not to show any contribution. I think we should check if the funded amount is the same. In that case we can map that value. It is different if we have two values that are not the same. In this case why should collect them somewhere to be used to improve the deduplication. One more thing: we need to consider all the relations that will be merged together to be sure that only once the funded amount is occurring, or if more than once, all the times has the same value

claudio.atzori added 1 commit 2022-07-28 09:50:02 +02:00

09ccc7b472 Merge branch 'beta' into project_organization_contribution

claudio.atzori commented

2022-07-28 10:04:42 +02:00

I think the PR can be merged. Only one consideration: you say that when more than one organization bring information about the funded amount it would be safer not to show any contribution. I think we should check if the funded amount is the same. In that case we can map that value.

As a matter of fact, question is not limited to the presentation of the funded amount. Taking any action in case of wrong organization deduplication would always imply drawbacks on the aggregated views. The only case that would not be affected is limited to the occurrence of exactly the same amount, but I'm not sure it might happen, and if it does would be by pure chance.

It is different if we have two values that are not the same. In this case why should collect them somewhere to be used to improve the deduplication.

I agree it would be helpful, the information would need to be dumped somewhere in such cases, but we'd need to be alerted as well, otherwise I doubt anyone will ever take a look at such data.

One more thing: we need to consider all the relations that will be merged together to be sure that only once the funded amount is occurring, or if more than once, all the times has the same value

I'm not sure I get what you mean here. Can you elaborate?

Overall, I think we could proceed with integrating the changes as they are, I just want to include some more to-the-point unit test, while to evaluate how to proceed in case of wrong organization dedup, we can verify to what extent this will occur by querying the actual graph data as soon as this change will be shipped to beta and the 1st graph built.

> I think the PR can be merged. Only one consideration: you say that when more than one organization bring information about the funded amount it would be safer not to show any contribution. I think we should check if the funded amount is the same. In that case we can map that value. As a matter of fact, question is not limited to the presentation of the funded amount. Taking any action in case of wrong organization deduplication would always imply drawbacks on the aggregated views. The only case that would not be affected is limited to the occurrence of exactly the same amount, but I'm not sure it might happen, and if it does would be by pure chance. > It is different if we have two values that are not the same. In this case why should collect them somewhere to be used to improve the deduplication. I agree it would be helpful, the information would need to be dumped somewhere in such cases, but we'd need to be alerted as well, otherwise I doubt anyone will ever take a look at such data. > One more thing: we need to consider all the relations that will be merged together to be sure that only once the funded amount is occurring, or if more than once, all the times has the same value I'm not sure I get what you mean here. Can you elaborate? Overall, I think we could proceed with integrating the changes as they are, I just want to include some more to-the-point unit test, while to evaluate how to proceed in case of wrong organization dedup, we can verify to what extent this will occur by querying the actual graph data as soon as this change will be shipped to beta and the 1st graph built.

claudio.atzori added 1 commit 2022-07-28 10:15:45 +02:00

60e4fbd78b Merge branch 'beta' into project_organization_contribution

claudio.atzori added 1 commit 2022-07-28 11:27:38 +02:00

1dd1e4fe3a extended test for mapping project_organization relations

claudio.atzori merged commit 37cfda0fc5 into beta

2022-07-28 12:16:30 +02:00

claudio.atzori referenced this issue from a commit

2022-07-28 12:16:31 +02:00

Merge pull request 'participant project contribution' (#223) from project_organization_contribution into beta

claudio.atzori deleted branch project_organization_contribution

2022-07-28 12:16:32 +02:00

claudio.atzori referenced this pull request