D-Net
/
dnet-hadoop
15
4
Fork 10
Code Issues 14 Pull Requests 8 Projects 2 Releases 1 Wiki Activity

Labels Milestones

openCitations #194

Merged
miriam.baglioni merged 6 commits from openCitations into beta 2 years ago
Conversation 0 Commits 6 Files Changed 21
miriam.baglioni commented 2 years ago
Collaborator

This PR is to fix issues with OC data: dois with commas and self citations

This PR is to fix issues with OC data: dois with commas and self citations
alessia.bardi was assigned by miriam.baglioni 2 years ago
miriam.baglioni added 3 commits 2 years ago
miriam.baglioni added 1 commit 2 years ago
alessia.bardi requested changes 2 years ago
alessia.bardi left a comment
Owner

Looks ok, just few small comments:

  1. Remove the confusing commented lines in the COCI model
  2. Two changes are not related to COCI (see pom.xml and AbstractMdRecordToOafMapper)
Looks ok, just few small comments: 1. Remove the confusing commented lines in the COCI model 2. Two changes are not related to COCI (see pom.xml and AbstractMdRecordToOafMapper)
dhp-workflows/dhp-aggregation/src/main/java/eu/dnetlib/dhp/actionmanager/opencitations/model/COCI.java
@ -0,0 +7,4 @@
public class COCI implements Serializable {
@CsvBindByPosition(position = 0)
// @CsvBindByName(column = "doi")
alessia.bardi commented 2 years ago
Owner

This commented line is confusing. The first column of the csv is the coci id, not the doi.
The same applies to the commented lines below

This commented line is confusing. The first column of the csv is the coci id, not the doi. The same applies to the commented lines below
miriam.baglioni commented 2 years ago
Poster
Collaborator

done

done
miriam.baglioni added 2 commits 2 years ago
miriam.baglioni merged commit a1013e62d4 into beta 2 years ago

Reviewers

alessia.bardi requested changes 2 years ago
The pull request has been merged as a1013e62d4.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b openCitations beta
git pull origin openCitations

Step 2:

Merge the changes and update on Gitea.
git checkout beta
git merge --no-ff openCitations
git push origin beta
Sign in to join this conversation.
Reviewers
Request review
No reviewers
alessia.bardi
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature / refactoring   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
RDGraph

EOSC Research Discovery Graph   
RSAC

EOSC Research Software APIs and Connectors   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
alessia.bardi
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#194
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'openCitations'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes