D-Net
/
dnet-hadoop
14
5
Fork 11
Code Issues 14 Pull Requests 13 Projects 2 Releases 2 Wiki Activity

openCitations #194

Merged
miriam.baglioni merged 6 commits from openCitations into beta 2022-02-14 14:58:28 +01:00
Conversation 0 Commits 6 Files Changed 21 +392 -32
miriam.baglioni commented 2022-02-08 16:16:35 +01:00
Member
Copy Link

This PR is to fix issues with OC data: dois with commas and self citations

This PR is to fix issues with OC data: dois with commas and self citations
alessia.bardi was assigned by miriam.baglioni 2022-02-08 16:16:35 +01:00
miriam.baglioni added 3 commits 2022-02-08 16:16:35 +01:00
miriam.baglioni added 1 commit 2022-02-08 16:23:12 +01:00
alessia.bardi requested changes 2022-02-09 11:45:37 +01:00
alessia.bardi left a comment
Owner
Copy Link

Looks ok, just few small comments:

  1. Remove the confusing commented lines in the COCI model
  2. Two changes are not related to COCI (see pom.xml and AbstractMdRecordToOafMapper)
Looks ok, just few small comments: 1. Remove the confusing commented lines in the COCI model 2. Two changes are not related to COCI (see pom.xml and AbstractMdRecordToOafMapper)
dhp-workflows/dhp-aggregation/src/main/java/eu/dnetlib/dhp/actionmanager/opencitations/model/COCI.java
@ -0,0 +7,4 @@
public class COCI implements Serializable {
@CsvBindByPosition(position = 0)
// @CsvBindByName(column = "doi")
alessia.bardi commented 2022-02-09 11:37:20 +01:00
Owner
Copy Link

This commented line is confusing. The first column of the csv is the coci id, not the doi.
The same applies to the commented lines below

This commented line is confusing. The first column of the csv is the coci id, not the doi. The same applies to the commented lines below
miriam.baglioni commented 2022-02-14 14:52:29 +01:00
Author
Member
Copy Link

done

done
miriam.baglioni added 2 commits 2022-02-14 14:52:17 +01:00
miriam.baglioni merged commit a1013e62d4 into beta 2022-02-14 14:58:28 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
alessia.bardi
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
alessia.bardi
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#194
No description provided.
Delete Branch "openCitations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?