PR: Bypass Action Set #157

miriam.baglioni · 2021-11-12T10:27:28+01:00

miriam.baglioni commented

2021-11-12 10:27:28 +01:00

This pull request is to create OAF entities that aim to enrich existing records in the graph. The OAF object is created setting as id a particular encoding of the given PID

unresolved:[pid]:[pidtype]

where

unresolved is a constant value
pid: is the persistent id value, e.g. 10.5281/zenodo.4707307
pidtype: is the persistent id type, e.g. doi

Then, such obejects are matched againsts those available in the graph using the result.instance.pid values.

This mechanism can be used to integrate enrichments produced as associated by a given PID. All the objects for which a match is not found are discarded.

This pull request is to create OAF entities that aim to enrich existing records in the graph. The OAF object is created setting as `id` a particular encoding of the given PID ```unresolved:[pid]:[pidtype]``` where - `unresolved` is a constant value - `pid`: is the persistent id value, e.g. `10.5281/zenodo.4707307` - `pidtype`: is the persistent id type, e.g. `doi` Then, such obejects are matched againsts those available in the graph using the `result.instance.pid` values. This mechanism can be used to integrate enrichments produced as associated by a given PID. All the objects for which a match is not found are discarded.

miriam.baglioni added 7 commits 2021-11-12 10:27:28 +01:00

a7d50c499b [BypassAS] prepare FOS subject, test and model for FOS and BipFinder scores

6f7ca539c6 [BypassAS] update of results for bipFinder and FOS

9e214ce0eb [BypassAS] addition of OC relations

c371b23077 -

935062edec [Bypass Action Set] creation of unresolved entities

716021546e [Bypass Action Set] minor fix

ffb0ce1d59 merge with beta - resolved conflict in pom

miriam.baglioni requested review from claudio.atzori 2021-11-12 10:27:42 +01:00

claudio.atzori requested changes 2021-11-12 10:46:29 +01:00

claudio.atzori left a comment

Consider using the already existing common function

eu.dnetlib.dhp.utils.DHPUtils#generateUnresolvedIdentifier

Consider using the already existing common function ``` eu.dnetlib.dhp.utils.DHPUtils#generateUnresolvedIdentifier ```

dhp-workflows/dhp-aggregation/src/main/java/eu/dnetlib/dhp/actionmanager/createunresolvedentities/Constants.java

						
				@ -0,0 +47,4 @@

							.map((MapFunction<String, R>) value -> OBJECT_MAPPER.readValue(value, clazz), Encoders.bean(clazz));

					}

					public static String getUnresolvedDoiIndentifier(String doi) {

claudio.atzori commented

2021-11-12 10:43:23 +01:00

Instead of defining an ad hoc method, it would be better to reuse the already existing function for the creation of the unresolved identifiers. It is available in

eu.dnetlib.dhp.utils.DHPUtils#generateUnresolvedIdentifier

Instead of defining an ad hoc method, it would be better to reuse the already existing function for the creation of the unresolved identifiers. It is available in ``` eu.dnetlib.dhp.utils.DHPUtils#generateUnresolvedIdentifier ```

claudio.atzori marked this conversation as resolved

miriam.baglioni added 3 commits 2021-11-12 10:57:16 +01:00

47ccb53c4f [Bypass Action Set] modification for comment #157 (comment)

881113743f [Bypass Action Set] refactoring

92d0e18b55 [Bypass Action Set] used constant DOI instead of "doi"

claudio.atzori merged commit 7b81607035 into beta

2021-11-12 12:01:05 +01:00

claudio.atzori referenced this issue from a commit

2021-11-12 12:01:05 +01:00

Merge pull request 'PR: Bypass Action Set' (#157) from bypass_acstionset into beta

claudio.atzori referenced this pull request

2021-11-26 15:55:18 +01:00