PR: Bypass Action Set #157

Merged
claudio.atzori merged 10 commits from bypass_acstionset into beta 2 years ago
Collaborator

This pull request is to create OAF entities that aim to enrich existing records in the graph. The OAF object is created setting as id a particular encoding of the given PID

unresolved:[pid]:[pidtype]

where

  • unresolved is a constant value
  • pid: is the persistent id value, e.g. 10.5281/zenodo.4707307
  • pidtype: is the persistent id type, e.g. doi

Then, such obejects are matched againsts those available in the graph using the result.instance.pid values.

This mechanism can be used to integrate enrichments produced as associated by a given PID. All the objects for which a match is not found are discarded.

This pull request is to create OAF entities that aim to enrich existing records in the graph. The OAF object is created setting as `id` a particular encoding of the given PID ```unresolved:[pid]:[pidtype]``` where - `unresolved` is a constant value - `pid`: is the persistent id value, e.g. `10.5281/zenodo.4707307` - `pidtype`: is the persistent id type, e.g. `doi` Then, such obejects are matched againsts those available in the graph using the `result.instance.pid` values. This mechanism can be used to integrate enrichments produced as associated by a given PID. All the objects for which a match is not found are discarded.
miriam.baglioni added 7 commits 2 years ago
miriam.baglioni requested review from claudio.atzori 2 years ago
claudio.atzori requested changes 2 years ago
claudio.atzori left a comment
Owner

Consider using the already existing common function

eu.dnetlib.dhp.utils.DHPUtils#generateUnresolvedIdentifier
Consider using the already existing common function ``` eu.dnetlib.dhp.utils.DHPUtils#generateUnresolvedIdentifier ```
@ -0,0 +47,4 @@
.map((MapFunction<String, R>) value -> OBJECT_MAPPER.readValue(value, clazz), Encoders.bean(clazz));
}
public static String getUnresolvedDoiIndentifier(String doi) {
Owner

Instead of defining an ad hoc method, it would be better to reuse the already existing function for the creation of the unresolved identifiers. It is available in

eu.dnetlib.dhp.utils.DHPUtils#generateUnresolvedIdentifier
Instead of defining an ad hoc method, it would be better to reuse the already existing function for the creation of the unresolved identifiers. It is available in ``` eu.dnetlib.dhp.utils.DHPUtils#generateUnresolvedIdentifier ```
claudio.atzori marked this conversation as resolved
miriam.baglioni added 3 commits 2 years ago
claudio.atzori merged commit 7b81607035 into beta 2 years ago

Reviewers

claudio.atzori requested changes 2 years ago
The pull request has been merged as 7b81607035.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b bypass_acstionset beta
git pull origin bypass_acstionset

Step 2:

Merge the changes and update on Gitea.
git checkout beta
git merge --no-ff bypass_acstionset
git push origin beta
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#157
Loading…
There is no content yet.