DOIBoost Mapping: change the creation of the instance in the DOIBoost result #155

Merged
claudio.atzori merged 12 commits from doiboost_url into beta 2 years ago
Collaborator

This PR is to change the way the instance is created for each of the providers considered for the creation of the DOIBoost result.

  1. Crossref instance is created with just one url made as "https://doi.org/[doi]"
  2. No instance is created for MAG
  3. UnpayWall and ORCID stay as there were

Another modification regards the mapping of the type "dissertation" from crossref. It is now mapped as Thesis (0040) instead of Doctoral Thesis (0006) as it was before

This PR is to change the way the instance is created for each of the providers considered for the creation of the DOIBoost result. 1. Crossref instance is created with just one url made as "https://doi.org/[doi]" 2. No instance is created for MAG 3. UnpayWall and ORCID stay as there were Another modification regards the mapping of the type "dissertation" from crossref. It is now mapped as Thesis (0040) instead of Doctoral Thesis (0006) as it was before
alessia.bardi was assigned by miriam.baglioni 2 years ago
claudio.atzori was assigned by miriam.baglioni 2 years ago
miriam.baglioni added 11 commits 2 years ago
claudio.atzori requested changes 2 years ago
claudio.atzori left a comment
Owner

Minor: a few lines of code are commented out and should be cleaned up

Minor: a few lines of code are commented out and should be cleaned up
@ -212,2 +209,2 @@
instance.setUrl(links.asJava)
}
val s: List[String] = List("https://doi.org/" + doi)
// val links: List[String] = ((for {JString(url) <- json \ "link" \ "URL"} yield url) ::: List(s)).filter(p => p != null && p.toLowerCase().contains(doi.toLowerCase())).distinct
Owner

Clean up commented out code lines

Clean up commented out code lines
claudio.atzori marked this conversation as resolved
claudio.atzori added 1 commit 2 years ago
claudio.atzori merged commit 8bdca3413f into beta 2 years ago

Reviewers

claudio.atzori requested changes 2 years ago
The pull request has been merged as 8bdca3413f.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b doiboost_url beta
git pull origin doiboost_url

Step 2:

Merge the changes and update on Gitea.
git checkout beta
git merge --no-ff doiboost_url
git push origin beta
Sign in to join this conversation.
No reviewers
No Milestone
No project
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#155
Loading…
There is no content yet.