result_pids #14

michele.artini · 2020-05-26T13:13:48+02:00

michele.artini commented

2020-05-26 13:13:48 +02:00

No description provided.

claudio.atzori requested changes 2020-05-26 16:22:11 +02:00

claudio.atzori left a comment

Michele please remember to compile the code before you a commit & push, in this way you're going to reformat the code according to the common style.

I suspect some of the diffs come from changes that you didn't sync on and would be avoided in the PR if you compiled the code first :)

Most importantly however, I noticed the mapping of the PIDs from the Odf format doesn't filter the types indicated in the dedicated vocabulary (see comment below).

Michele please remember to compile the code before you a commit & push, in this way you're going to reformat the code according to the common style. I suspect some of the diffs come from changes that you didn't sync on and would be avoided in the PR if you compiled the code first :) Most importantly however, I noticed the mapping of the PIDs from the Odf format doesn't filter the types indicated in the dedicated vocabulary (see comment below).

dhp-workflows/dhp-graph-mapper/src/main/java/eu/dnetlib/dhp/oa/graph/raw/OdfToOafMapper.java

						
				@ -371,1 +371,4 @@

					}

					@Override

					protected List<StructuredProperty> prepareResultPids(final Document doc, final DataInfo info) {

claudio.atzori commented

2020-05-26 15:29:31 +02:00

The mapping for PIDs should only allow passing PID types declared in the dnet:pid_types vocabulary, while all the others should be discarded. However, I don't see in this method (or in the methods used by it) any filtering applied according to any vocabulary.

The mapping for PIDs should only allow passing PID types declared in the *dnet:pid_types* vocabulary, while all the others should be discarded. However, I don't see in this method (or in the methods used by it) any filtering applied according to any vocabulary.