D-Net
/
dnet-hadoop
14
5
Fork 11
Code Issues 14 Pull Requests 10 Projects 2 Releases 2 Wiki Activity

hostedbymap #136

Merged
claudio.atzori merged 60 commits from hostedbymap into beta 2021-08-12 17:10:55 +02:00
Conversation 1 Commits 60 Files Changed 46 +2268 -6
miriam.baglioni commented 2021-08-11 16:05:39 +02:00
Member
Copy Link

This PR is related to ticket #5644

It build on demand a new hostedbymap by exploiting two external sources:

It applies the HBM on the entities in the graph, the entities involved by its application are the Datasources and the Publications.

The Datasource will be modified in the openairecompatibility field and only if its classid is set to UNKNOWN. In this case, it will be set as hostedBy, and the classname will become "collected from a compatible aggregator".

The publications that will be affected by the application of the HBM are those having only one instance. For those with journal information for which exists a match with the hbm, the hostedby information in the instance will be modified according to the information in the hbm. If in the map the journal identifier is marked as OpenAccess, the accessright of the publication will be set to OPEN and the OpenAccessRoute to hybrid. Also the bestaccessright at the level of the result is possibly changed.

This PR is related to ticket #5644 It build on demand a new hostedbymap by exploiting two external sources: - https://pub.uni-bielefeld.de/download/2944717/2944718/issn_gold_oa_version_4.csv - https://doaj.org/csv) It applies the HBM on the entities in the graph, the entities involved by its application are the Datasources and the Publications. The Datasource will be modified in the `openairecompatibility` field and only if its classid is set to UNKNOWN. In this case, it will be set as `hostedBy`, and the classname will become "collected from a compatible aggregator". The publications that will be affected by the application of the HBM are those having only one instance. For those with journal information for which exists a match with the hbm, the hostedby information in the instance will be modified according to the information in the hbm. If in the map the journal identifier is marked as `OpenAccess`, the `accessright` of the publication will be set to OPEN and the `OpenAccessRoute` to `hybrid`. Also the `bestaccessright` at the level of the result is possibly changed.
miriam.baglioni added the
enhancement
 label 2021-08-11 16:05:39 +02:00
claudio.atzori was assigned by miriam.baglioni 2021-08-11 16:05:40 +02:00
miriam.baglioni added 37 commits 2021-08-11 16:05:40 +02:00
miriam.baglioni added 1 commit 2021-08-11 16:12:05 +02:00
miriam.baglioni added 1 commit 2021-08-11 16:17:03 +02:00
miriam.baglioni added 2 commits 2021-08-11 16:36:12 +02:00
claudio.atzori requested changes 2021-08-11 17:24:03 +02:00
claudio.atzori left a comment
Owner
Copy Link
  • It seems that many files, not related with the implementation of this new fature got changed. In particular, ISSN (uppercase) got replaced with issn (lowerase) in many files that have nothing to do with this PR. Please check and revert them to their previous state.
  • On dhp-workflows/dhp-graph-mapper/pom.xml I see a new dependency:
<dependency>
   <groupId>com.opencsv</groupId>
   <artifactId>opencsv</artifactId>
   <version>5.5</version>
</dependency>

I got nothing against the introduction of new libraries, but two comments on this

  1. didn't we already manage CSVs with an external library? If yes, why do we need yet another one?
  2. dependency versions should be declared only in the external pom file, all the submodules must refer to them without specifying the version.
  • On dhp-workflows/dhp-doiboost/pom.xml I see a new dependency towards the dhp-aggregation. In general, common utilities neeeded by more than one submodule should be moved in dhp-common, let's try to keep the dependencies well organised.
* It seems that many files, not related with the implementation of this new fature got changed. In particular, `ISSN` (uppercase) got replaced with `issn` (lowerase) in many files that have nothing to do with this PR. Please check and revert them to their previous state. * On `dhp-workflows/dhp-graph-mapper/pom.xml` I see a new dependency: ``` <dependency> <groupId>com.opencsv</groupId> <artifactId>opencsv</artifactId> <version>5.5</version> </dependency> ``` I got nothing against the introduction of new libraries, but two comments on this 1. didn't we already manage CSVs with an external library? If yes, why do we need yet another one? 2. dependency versions should be declared only in the external pom file, all the submodules must refer to them without specifying the version. * On `dhp-workflows/dhp-doiboost/pom.xml` I see a new dependency towards the `dhp-aggregation`. In general, common utilities neeeded by more than one submodule should be moved in `dhp-common`, let's try to keep the dependencies well organised.
miriam.baglioni added 14 commits 2021-08-11 17:44:24 +02:00
miriam.baglioni added 2 commits 2021-08-11 17:46:26 +02:00
miriam.baglioni added 1 commit 2021-08-11 17:50:40 +02:00
miriam.baglioni added 1 commit 2021-08-11 18:09:54 +02:00
miriam.baglioni commented 2021-08-11 18:12:05 +02:00
Author
Member
Copy Link

I have reverted all the modified ISSN on the files. I have also removed the not needed dependecies from the poms.
The new library to import csv files should replace the previous one. A new PR will follow for refactoring

I have reverted all the modified ISSN on the files. I have also removed the not needed dependecies from the poms. The new library to import csv files should replace the previous one. A new PR will follow for refactoring
claudio.atzori added 1 commit 2021-08-12 17:04:32 +02:00
claudio.atzori merged commit e91ffcd2f3 into beta 2021-08-12 17:10:55 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
claudio.atzori
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#136
No description provided.
Delete Branch "hostedbymap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?