Change the access right in DoiBoost #126

Merged
claudio.atzori merged 19 commits from doiboosi_accessright into beta 3 years ago
Collaborator

This PR addresses ticket #4362. It does not include the merge with the gold list from UNIBI because it will be considered in creating a new hosteByMap, so no modification to the part of the cose that exploits the map needs to be done here.

This PR addresses ticket [#4362](https://support.openaire.eu/issues/4362). It does not include the merge with the gold list from UNIBI because it will be considered in creating a new hosteByMap, so no modification to the part of the cose that exploits the map needs to be done here.
miriam.baglioni added the
enhancement
label 3 years ago
alessia.bardi was assigned by miriam.baglioni 3 years ago
claudio.atzori was assigned by miriam.baglioni 3 years ago
miriam.baglioni added 15 commits 3 years ago
claudio.atzori requested changes 3 years ago
claudio.atzori left a comment
Owner

Just minor cleanups:

  • commented code should be removed
  • use of constants from the common ModelConstants class
Just minor cleanups: * commented code should be removed * use of constants from the common `ModelConstants` class
@ -121,0 +185,4 @@
// val pub_date = LocalDate.parse(date, formatter)
// if (((now.toEpochDay - pub_date.toEpochDay)/365.0) > 1){
Owner

Consider cleaning up commented code

Consider cleaning up commented code
miriam.baglioni marked this conversation as resolved
@ -130,2 +211,4 @@
def getUnknownQualifier():AccessRight = {
OafMapperUtils.accessRight("UNKNOWN","not available",ModelConstants.DNET_ACCESS_MODES, ModelConstants.DNET_ACCESS_MODES)
Owner

Consider using ModelConstants.UNKNOWN and ModelConstants.NOT_AVAILABLE

Consider using `ModelConstants.UNKNOWN` and `ModelConstants.NOT_AVAILABLE`
miriam.baglioni marked this conversation as resolved
@ -132,0 +216,4 @@
def getEmbargoedAccessQualifier():AccessRight = {
OafMapperUtils.accessRight("EMBARGO","Embargo",ModelConstants.DNET_ACCESS_MODES, ModelConstants.DNET_ACCESS_MODES)
Owner

A constant for EMBARGO is not available yet, but I just added it.

A constant for EMBARGO is not available yet, but I just added it.
Poster
Collaborator

Not visible yet, to be modified

Not visible yet, to be modified
@ -132,0 +220,4 @@
}
def getClosedAccessQualifier():AccessRight = {
OafMapperUtils.accessRight("CLOSED","Closed Access", ModelConstants.DNET_ACCESS_MODES, ModelConstants.DNET_ACCESS_MODES)
Owner

A constant for CLOSED is not available yet, but I just added it.

A constant for CLOSED is not available yet, but I just added it.
miriam.baglioni added 4 commits 3 years ago
claudio.atzori merged commit b346feed36 into beta 3 years ago

Reviewers

claudio.atzori requested changes 3 years ago
The pull request has been merged as b346feed36.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b doiboosi_accessright beta
git pull origin doiboosi_accessright

Step 2:

Merge the changes and update on Gitea.
git checkout beta
git merge --no-ff doiboosi_accessright
git push origin beta
Sign in to join this conversation.
No reviewers
No Milestone
No project
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#126
Loading…
There is no content yet.