Change the access right in DoiBoost #126

miriam.baglioni · 2021-07-28T10:34:19+02:00

miriam.baglioni commented

2021-07-28 10:34:19 +02:00

This PR addresses ticket #4362. It does not include the merge with the gold list from UNIBI because it will be considered in creating a new hosteByMap, so no modification to the part of the cose that exploits the map needs to be done here.

This PR addresses ticket [#4362](https://support.openaire.eu/issues/4362). It does not include the merge with the gold list from UNIBI because it will be considered in creating a new hosteByMap, so no modification to the part of the cose that exploits the map needs to be done here.

miriam.baglioni added the

enhancement

label 2021-07-28 10:34:19 +02:00

alessia.bardi was assigned by miriam.baglioni

2021-07-28 10:34:19 +02:00

claudio.atzori was assigned by miriam.baglioni

2021-07-28 10:34:19 +02:00

miriam.baglioni added 15 commits 2021-07-28 10:34:19 +02:00

441701c85c DoiBoost AccessRigh #4362 - If multiple licenses are available, take the one applied to 'vor'

981b1018f6 DoiBoost AccessRigh #4362 - decide access right according to licence. Default access right is Unknown

6222adf176 DoiBoost AccessRigh #4362 - added resources and test for crossref mapping (licence part included)

f4f7c6f9d3 DoiBoost AccessRigh #4362 - Unpaywall mapped to OAF with OPEN instance (non oa are filtered out) (unknown hostedby) + map the color as it is

09ad7b2a9e DoiBoost AccessRigh #4362 - Unpaywall mapped to OAF with OPEN instance (non oa are filtered out) (unknown hostedby) + map the color as it is

4da46bb62f mergin with branch beta

34506df1b6 DoiBoost AccessRigh #4362 - if the journal is open, the OPEN access right is set to all instances and color is GOLD (overwrite if the color was already set in one of the previous steps)

3bc9a05bc9 mergin with branch beta

199123b74b DoiBoost AccessRigh #4362 - Fixed issue on date formatting. Added test method and associated resource

59530a14fb DoiBoost AccessRigh #4362 - set BestAccessRight with the ususal comparator

662c396354 duplicate the number of partitions in ConvertCrossrefToOaf

b420b11ed3 duplicate the number of partitions in ProcessMag

b226ba4439 mergin with branch beta

1a5b114906 DoiBoost AccessRigh #4362 - refactoring

6c936943aa mergin with branch beta

claudio.atzori requested changes 2021-07-28 10:51:47 +02:00

claudio.atzori left a comment

Just minor cleanups:

commented code should be removed
use of constants from the common ModelConstants class

Just minor cleanups: * commented code should be removed * use of constants from the common `ModelConstants` class

dhp-workflows/dhp-doiboost/src/main/java/eu/dnetlib/doiboost/DoiBoostMappingUtil.scala Outdated

						
				@ -121,0 +185,4 @@

				     // val pub_date = LocalDate.parse(date, formatter)

				//      if (((now.toEpochDay - pub_date.toEpochDay)/365.0) > 1){

claudio.atzori commented

2021-07-28 10:43:36 +02:00

Consider cleaning up commented code

miriam.baglioni marked this conversation as resolved

dhp-workflows/dhp-doiboost/src/main/java/eu/dnetlib/doiboost/DoiBoostMappingUtil.scala Outdated

						
				@ -130,2 +211,4 @@

				  def getUnknownQualifier():AccessRight = {

				    OafMapperUtils.accessRight("UNKNOWN","not available",ModelConstants.DNET_ACCESS_MODES, ModelConstants.DNET_ACCESS_MODES)

claudio.atzori commented

2021-07-28 10:45:05 +02:00

Consider using ModelConstants.UNKNOWN and ModelConstants.NOT_AVAILABLE

Consider using `ModelConstants.UNKNOWN` and `ModelConstants.NOT_AVAILABLE`

miriam.baglioni marked this conversation as resolved

dhp-workflows/dhp-doiboost/src/main/java/eu/dnetlib/doiboost/DoiBoostMappingUtil.scala Outdated

						
				@ -132,0 +216,4 @@

				  def getEmbargoedAccessQualifier():AccessRight = {

				    OafMapperUtils.accessRight("EMBARGO","Embargo",ModelConstants.DNET_ACCESS_MODES, ModelConstants.DNET_ACCESS_MODES)

claudio.atzori commented

2021-07-28 10:49:31 +02:00

A constant for EMBARGO is not available yet, but I just added it.

miriam.baglioni commented

2021-07-28 11:14:53 +02:00

Not visible yet, to be modified

dhp-workflows/dhp-doiboost/src/main/java/eu/dnetlib/doiboost/DoiBoostMappingUtil.scala Outdated

						
				@ -132,0 +220,4 @@

				  }

				  def getClosedAccessQualifier():AccessRight = {

				    OafMapperUtils.accessRight("CLOSED","Closed Access", ModelConstants.DNET_ACCESS_MODES, ModelConstants.DNET_ACCESS_MODES)