D-Net
/
dnet-hadoop
13
4
Fork 10
Code Issues 14 Pull Requests 8 Projects 2 Releases 1 Wiki Activity

switch from getDatasourceId to getNsPrefix #107

Closed
andreas.czerniak wants to merge 8 commits from stable_ids into stable_ids
pull from: stable_ids
merge into: D-Net:stable_ids
Conversation 0 Commits 8 Files Changed 4 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 29da540b4e - Show all commits

2
dhp-workflows/dhp-aggregation/src/main/java/eu/dnetlib/dhp/transformation/xslt/XSLTTransformationFunction.java
View File

@ -59,7 +59,7 @@ public class XSLTTransformationFunction implements MapFunction<MetadataRecord, M
final XsltCompiler comp = processor.newXsltCompiler();
QName datasourceIDParam = new QName(DATASOURCE_ID_PARAM);
comp.setParameter(datasourceIDParam, new XdmAtomicValue(value.getProvenance().getDatasourceId()));
comp.setParameter(datasourceIDParam, new XdmAtomicValue(value.getProvenance().getNsPrefix()));
claudio.atzori commented 2021-05-14 15:30:39 +02:00
Review
Copy Link

DatasourceID and namespacePrefix are different concepts and are not interchangeable. Switching from one to the other should be done in accordance to the parameter name. With this PR it would still be bound to the param name varDataSourceId, creating confusion.

DatasourceID and namespacePrefix are different concepts and are not interchangeable. Switching from one to the other should be done in accordance to the parameter name. With this PR it would still be bound to the param name varDataSourceId, creating confusion.
QName datasourceNameParam = new QName(DATASOURCE_NAME_PARAM);
comp.setParameter(datasourceNameParam, new XdmAtomicValue(value.getProvenance().getDatasourceName()));
XsltExecutable xslt = comp