D-Net
/
dnet-hadoop
15
4
Fork 10
Code Issues 14 Pull Requests 10 Projects 2 Releases 1 Wiki Activity

switch from getDatasourceId to getNsPrefix #107

Closed
andreas.czerniak wants to merge 8 commits from stable_ids into stable_ids
pull from: stable_ids
merge into: D-Net:stable_ids
Conversation 0 Commits 8 Files Changed 4 +491 -2
andreas.czerniak commented 2021-05-13 00:11:19 +02:00
Member
Copy Link

Adding comments, test class, and important to handle datasource ids.

Adding comments, test class, and important to handle datasource ids.
andreas.czerniak added 8 commits 2021-05-13 00:11:20 +02:00
claudio.atzori reviewed 2021-05-14 15:27:49 +02:00
claudio.atzori requested changes 2021-05-14 15:32:11 +02:00
claudio.atzori left a comment
Owner
Copy Link

Summary:

  • clarify the reason for switching from datasourceId to nsPrefix
  • include test classes in the PR only when the tests are entirely defined
Summary: - clarify the reason for switching from datasourceId to nsPrefix - include test classes in the PR only when the tests are entirely defined
dhp-workflows/dhp-aggregation/src/main/java/eu/dnetlib/dhp/transformation/xslt/XSLTTransformationFunction.java
@ -60,3 +60,3 @@
final XsltCompiler comp = processor.newXsltCompiler();
QName datasourceIDParam = new QName(DATASOURCE_ID_PARAM);
comp.setParameter(datasourceIDParam, new XdmAtomicValue(value.getProvenance().getDatasourceId()));
comp.setParameter(datasourceIDParam, new XdmAtomicValue(value.getProvenance().getNsPrefix()));
claudio.atzori commented 2021-05-14 15:30:39 +02:00
Owner
Copy Link

DatasourceID and namespacePrefix are different concepts and are not interchangeable. Switching from one to the other should be done in accordance to the parameter name. With this PR it would still be bound to the param name varDataSourceId, creating confusion.

DatasourceID and namespacePrefix are different concepts and are not interchangeable. Switching from one to the other should be done in accordance to the parameter name. With this PR it would still be bound to the param name varDataSourceId, creating confusion.
dhp-workflows/dhp-aggregation/src/test/java/eu/dnetlib/dhp/transformation/xslt/PersonCleanerTest.java
@ -0,0 +9,4 @@
import org.mockito.junit.jupiter.MockitoExtension;
@ExtendWith(MockitoExtension.class)
public class PersonCleanerTest {
claudio.atzori commented 2021-05-14 15:29:43 +02:00
Owner
Copy Link

Please include the test classes in the PR when they provide actual assertions.

Please include the test classes in the PR when they provide actual assertions.
andreas.czerniak closed this pull request 2021-05-14 23:23:23 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
claudio.atzori
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#107
No description provided.
Delete Branch "stable_ids"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?