D-Net
/
dnet-hadoop
15
4
Fork 10
Code Issues 14 Pull Requests 8 Projects 2 Releases 1 Wiki Activity

Labels Milestones

#7861#note-8 instance url from handle #243

Merged
claudio.atzori merged 4 commits from handle_as_instance_urls into beta 2 years ago
Conversation 0 Commits 4 Files Changed 3
alessia.bardi commented 2 years ago
Owner

See ticket https://support.openaire.eu/issues/7861#note-8: we have many results with no instance in the index because they are without an instance url in the graph. With this fix we should cover the missing instances for repositories that provide a handle.
An example is https://explore.openaire.eu/search/publication?articleId=od______1560::8f7a139735f493882bb0f4abceb6e200

I have also changed the DOI prefix used in the class: we can use https://doi.org/ instead of https://dx.doi.org/ .

See ticket https://support.openaire.eu/issues/7861#note-8: we have many results with no instance in the index because they are without an instance url in the graph. With this fix we should cover the missing instances for repositories that provide a handle. An example is https://explore.openaire.eu/search/publication?articleId=od______1560::8f7a139735f493882bb0f4abceb6e200 I have also changed the DOI prefix used in the class: we can use https://doi.org/ instead of https://dx.doi.org/ .
alessia.bardi added 1 commit 2 years ago
alessia.bardi requested review from claudio.atzori 2 years ago
claudio.atzori was assigned by alessia.bardi 2 years ago
claudio.atzori reviewed 2 years ago
dhp-workflows/dhp-graph-mapper/src/main/java/eu/dnetlib/dhp/oa/graph/raw/OdfToOafMapper.java Outdated
@ -27,2 +27,3 @@
public static final String HTTP_DX_DOI_PREIFX = "https://dx.doi.org/";
public static final String HTTP_DOI_PREIFX = "https://doi.org/";
public static final String HTTP_HANDLE_PREIFX = "http://hdl.handle.net/";
claudio.atzori commented 2 years ago
Owner

Why not declaring https also for the handle resolver?

Why not declaring https also for the handle resolver?
claudio.atzori marked this conversation as resolved
claudio.atzori requested changes 2 years ago
claudio.atzori left a comment
Owner

Overall I'm OK with this PR, just a minor comment, see it inline.

Overall I'm OK with this PR, just a minor comment, see it inline.
claudio.atzori added 1 commit 2 years ago
alessia.bardi added 2 commits 2 years ago
claudio.atzori merged commit 690be4482f into beta 2 years ago
claudio.atzori deleted branch handle_as_instance_urls 2 years ago

Reviewers

claudio.atzori requested changes 2 years ago
The pull request has been merged as 690be4482f.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b handle_as_instance_urls beta
git pull origin handle_as_instance_urls

Step 2:

Merge the changes and update on Gitea.
git checkout beta
git merge --no-ff handle_as_instance_urls
git push origin beta
Sign in to join this conversation.
Reviewers
Request review
No reviewers
claudio.atzori
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature / refactoring   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
RDGraph

EOSC Research Discovery Graph   
RSAC

EOSC Research Software APIs and Connectors   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#243
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'handle_as_instance_urls'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes