DOIBoost Mapping: change the creation of the instance in the DOIBoost result #155

miriam.baglioni · 2021-11-11T09:05:01+01:00

miriam.baglioni commented

2021-11-11 09:05:01 +01:00

This PR is to change the way the instance is created for each of the providers considered for the creation of the DOIBoost result.

Crossref instance is created with just one url made as "https://doi.org/[doi]"
No instance is created for MAG
UnpayWall and ORCID stay as there were

Another modification regards the mapping of the type "dissertation" from crossref. It is now mapped as Thesis (0040) instead of Doctoral Thesis (0006) as it was before

This PR is to change the way the instance is created for each of the providers considered for the creation of the DOIBoost result. 1. Crossref instance is created with just one url made as "https://doi.org/[doi]" 2. No instance is created for MAG 3. UnpayWall and ORCID stay as there were Another modification regards the mapping of the type "dissertation" from crossref. It is now mapped as Thesis (0040) instead of Doctoral Thesis (0006) as it was before

alessia.bardi was assigned by miriam.baglioni

2021-11-11 09:05:02 +01:00

claudio.atzori was assigned by miriam.baglioni

2021-11-11 09:05:02 +01:00

miriam.baglioni added 11 commits 2021-11-11 09:05:02 +01:00

2480e590d1 [DOIBoost - Mapping] changed the type on which to map dissertation from Crossref: from 006 Doctoral thesis to 0044 Thesis since dissertation could be either Doctoral or master thesis

779318961c [DOIBoost - Mapping] removed the url from crossref containing the api.elsevier.com... string in the url

b2bb8d9d79 [DOIBoost - Mapping] selecting the url from Crossref containing the doi

683fe093cf [DOIBoost - Mapping] Remove the addition of the instance to the MAG publication record

96769b4481 [DOIBoost - Mapping] Changed the logic which brought in in the instance urls that should not be there: The urld of the doi in the json is reachable from the root (json/"URL") other urls where added from the links element. Now the mapping from the link element has been removed

d97ea82a29 [DOIBoost Mapping] Added test to verify the instance created for Crossref will have just the url related to the doi

edf55395e9 added test resourse

d50057b2d9 [DOIBoost Mapping] changed the way to create the url for the instance: we use the crooref guidelines https://doi.org/doi

de63d29b6f [DOIBoost Mapping] Fix to avoid to produce results with null as identifier (probably due to the filtering function in the factory for the creation of the id)

df7ee77c7a [DOIBoost Mapping] removed not needed comments

6d3c4c4abe mergin with branch beta

claudio.atzori requested changes 2021-11-11 09:45:22 +01:00

claudio.atzori left a comment

Minor: a few lines of code are commented out and should be cleaned up

dhp-workflows/dhp-doiboost/src/main/java/eu/dnetlib/doiboost/crossref/Crossref2Oaf.scala

						
				@ -212,2 +209,2 @@

				      instance.setUrl(links.asJava)

				    }

				    val s: List[String] = List("https://doi.org/" + doi)

				//    val links: List[String] = ((for {JString(url) <- json \ "link" \ "URL"} yield url) ::: List(s)).filter(p => p != null && p.toLowerCase().contains(doi.toLowerCase())).distinct