enrichment #9

Merged
claudio.atzori merged 4 commits from enrichment into master 2 years ago
Owner

This branch implements enrichment on Result specializing in the method mergefrom().
During the merge, when one of the two records has the provenance "enrich" instead of duplicating an instance, we try to enrich only the missing attribute.

This branch implements enrichment on Result specializing in the method **mergefrom()**. During the merge, when one of the two records has the provenance "enrich" instead of duplicating an instance, we try to enrich only the missing attribute.
sandro.labruzzo added 2 commits 2 years ago
sandro.labruzzo added 1 commit 2 years ago
claudio.atzori reviewed 2 years ago
@ -245,0 +544,4 @@
* @param pid the pid
* @return the string
*/
private static String normalizePid(final StructuredProperty pid) {
Owner

A very similar function already exists in this module:

https://code-repo.d4science.org/D-Net/dhp-schemas/src/branch/master/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/CleaningFunctions.java#L50

Consider reusing it, or if its behaviour doesn't exactly match the you you need, consider to adjust it.

A very similar function already exists in this module: https://code-repo.d4science.org/D-Net/dhp-schemas/src/branch/master/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/CleaningFunctions.java#L50 Consider reusing it, or if its behaviour doesn't exactly match the you you need, consider to adjust it.
sandro.labruzzo marked this conversation as resolved
claudio.atzori requested changes 2 years ago
claudio.atzori left a comment
Owner

Let's try reuse already existing utilities. See comment below.

Let's try reuse already existing utilities. See comment below.
sandro.labruzzo added 1 commit 2 years ago
claudio.atzori merged commit fa4cd3963b into master 2 years ago

Reviewers

claudio.atzori requested changes 2 years ago
The pull request has been merged as fa4cd3963b.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b enrichment master
git pull origin enrichment

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff enrichment
git push origin master
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dhp-schemas#9
Loading…
There is no content yet.