D-Net
/
dhp-schemas
9
1
Fork 0
Code Issues 1 Pull Requests 5 Projects Releases 1 Wiki Activity

Moving the BipFinder! Measures #5

Closed
miriam.baglioni wants to merge 0 commits from instance_measures into master
pull from: instance_measures
merge into: D-Net:master
Conversation 0 Commits - Files Changed - +57 -10
miriam.baglioni commented 2021-11-15 16:55:35 +01:00
Member
Copy Link

This PR is to move the BipFinder Measures at the level of the instance both in the model of the graph and in that of the dump.
It also regenerates the schema of the dumper result.

Please have a careful look at it because I realized that the field alternateIdentifier was missing in the previous version.

This PR is to move the BipFinder Measures at the level of the instance both in the model of the graph and in that of the dump. It also regenerates the schema of the dumper result. Please have a careful look at it because I realized that the field `alternateIdentifier` was missing in the previous version.
alessia.bardi was assigned by miriam.baglioni 2021-11-15 16:55:35 +01:00
claudio.atzori was assigned by miriam.baglioni 2021-11-15 16:55:35 +01:00
miriam.baglioni added 3 commits 2021-11-15 16:55:35 +01:00
claudio.atzori requested changes 2021-11-16 09:04:32 +01:00
claudio.atzori left a comment
Owner
Copy Link
  1. please fix some typos in the javadoc
  2. the field measures is designed to be generic. Although it is currently used to host the citation scores, the documentation/descriptions we produce for it should stress its genericity, rather than the single use case currently inplace for them.
1) please fix some typos in the javadoc 2) the field measures is designed to be generic. Although it is currently used to host the citation scores, the documentation/descriptions we produce for it should stress its genericity, rather than the single use case currently inplace for them.
src/main/java/eu/dnetlib/dhp/schema/dump/oaf/Instance.java
@ -19,9 +19,12 @@ import java.util.List;
* -pid of type List<ControlledField> that is the list of pids associated to the result coming from authoritative sources for that pid
* -alternateIdentifier of type List<ControlledField> that is the list of pids associated to the result coming from NON authoritative
* sources for that pid
* -measure list<KeyValue> to represent the measure of beepFinder. It corresponds to measures in the model
claudio.atzori commented 2021-11-16 09:02:56 +01:00
Owner
Copy Link

typo: Bip!Finder

typo: Bip!Finder
src/main/java/eu/dnetlib/dhp/schema/dump/oaf/Result.java
@ -60,11 +60,11 @@ import java.util.List;
* to store information about the time OpenAIRE collected the record. It corresponds to dateofcollection of the result
* represented in the internal model - lasteupdatetimestamp of type String to store the timestamp of the last update of
* the record. It corresponds to lastupdatetimestamp of the resord represented in the internal model
* -measure list<KeyValue> to represent the measure of beepFinder. It corresponds to measures in the model
claudio.atzori commented 2021-11-16 09:00:30 +01:00
Owner
Copy Link

typo: Bip!Finder.

typo: Bip!Finder.
miriam.baglioni closed this pull request 2021-11-16 10:22:24 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
claudio.atzori
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
alessia.bardi
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dhp-schemas#5
No description provided.
Delete Branch "instance_measures"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?