D-Net
/
dhp-schemas
9
1
Fork 0
Code Issues 1 Pull Requests 5 Projects Releases 4 Wiki Activity

scholexplorer_incremental_index #14

Merged
sandro.labruzzo merged 12 commits from scholexplorer_incremental_index into master 2022-03-29 11:43:02 +02:00
Conversation 1 Commits 12 Files Changed 26 +3016 -40
sandro.labruzzo commented 2022-02-23 11:08:01 +01:00
Owner
Copy Link

To define incremental indexing on Scholexplorer, we need to implement a method that compare two Scholix Item.

Furthermore, this PR includes also moving the common API schema of Scholix that is quite different from that used from the index into dhp-schema

This PR includes:

  • implementation of the compareTo method on Scholix objects and all model properties
  • Unit Test to verify that compareTo works on different case
  • Moved Scholix API Data model into dhp-schemas
To define incremental indexing on Scholexplorer, we need to implement a method that **compare** two Scholix Item. Furthermore, this PR includes also moving the common API schema of Scholix that is quite different from that used from the index into dhp-schema This PR includes: * implementation of the *compareTo* method on Scholix objects and all model properties * Unit Test to verify that compareTo works on different case * Moved Scholix API Data model into dhp-schemas
sandro.labruzzo added 3 commits 2022-02-23 11:08:02 +01:00
sandro.labruzzo added 1 commit 2022-02-25 15:25:50 +01:00
claudio.atzori was assigned by sandro.labruzzo 2022-02-28 09:28:13 +01:00
sandro.labruzzo added 2 commits 2022-02-28 12:11:39 +01:00
claudio.atzori reviewed 2022-03-09 09:24:10 +01:00
pom.xml Outdated
@ -338,0 +352,4 @@
<dependency>
<groupId>io.swagger</groupId>
<artifactId>swagger-annotations</artifactId>
<version>1.5.20</version>
claudio.atzori commented 2022-03-09 09:24:10 +01:00
Owner
Copy Link

The version of each dependency should be indicated under the dependencyManagement element.

The version of each dependency should be indicated under the dependencyManagement element.
sandro.labruzzo marked this conversation as resolved
claudio.atzori reviewed 2022-03-09 09:24:33 +01:00
pom.xml
@ -138,6 +138,9 @@
<artifactId>maven-dependency-plugin</artifactId>
<version>3.0.0</version>
</plugin>
claudio.atzori commented 2022-03-09 09:24:33 +01:00
Owner
Copy Link

Please cleanup non necessary changes.

Please cleanup non necessary changes.
sandro.labruzzo marked this conversation as resolved
claudio.atzori requested changes 2022-03-09 09:26:44 +01:00
claudio.atzori left a comment
Owner
Copy Link

Overall looks good, please check the inline comments.

Overall looks good, please check the inline comments.
sandro.labruzzo added 1 commit 2022-03-29 11:14:55 +02:00
sandro.labruzzo commented 2022-03-29 11:16:33 +02:00
Author
Owner
Copy Link

The review comment has been fixed. I Think we can merge the PR

The review comment has been fixed. I Think we can merge the PR
sandro.labruzzo added 1 commit 2022-03-29 11:18:34 +02:00
claudio.atzori reviewed 2022-03-29 11:20:59 +02:00
pom.xml
claudio.atzori commented 2022-03-29 11:20:59 +02:00
Owner
Copy Link

This is not necessary

This is not necessary
claudio.atzori reviewed 2022-03-29 11:21:47 +02:00
pom.xml Outdated
@ -338,0 +357,4 @@
<dependency>
<groupId>io.swagger.core.v3</groupId>
<artifactId>swagger-annotations</artifactId>
<version>2.1.12</version>
claudio.atzori commented 2022-03-29 11:21:47 +02:00
Owner
Copy Link

Please move all the dependency versions under the <dependencyManagement> section.

Please move all the dependency versions under the `<dependencyManagement>` section.
sandro.labruzzo marked this conversation as resolved
claudio.atzori requested changes 2022-03-29 11:22:38 +02:00
claudio.atzori left a comment
Owner
Copy Link

Minor changes

Minor changes
claudio.atzori added 1 commit 2022-03-29 11:22:44 +02:00
sandro.labruzzo added 2 commits 2022-03-29 11:29:51 +02:00
sandro.labruzzo requested review from claudio.atzori 2022-03-29 11:30:48 +02:00
sandro.labruzzo added 1 commit 2022-03-29 11:39:52 +02:00
sandro.labruzzo merged commit 4804fb2dd2 into master 2022-03-29 11:43:02 +02:00
sandro.labruzzo deleted branch scholexplorer_incremental_index 2022-03-29 11:43:02 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
claudio.atzori
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dhp-schemas#14
No description provided.
Delete Branch "scholexplorer_incremental_index"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?