D-Net
/
dhp-schemas
10
1
Fork 0
Code Issues 1 Pull Requests 2 Projects Releases Wiki Activity

Labels Milestones

scholexplorer_incremental_index #14

Merged
sandro.labruzzo merged 12 commits from scholexplorer_incremental_index into master 2 years ago
Conversation 1 Commits 12 Files Changed 26
sandro.labruzzo commented 2 years ago
Owner

To define incremental indexing on Scholexplorer, we need to implement a method that compare two Scholix Item.

Furthermore, this PR includes also moving the common API schema of Scholix that is quite different from that used from the index into dhp-schema

This PR includes:

  • implementation of the compareTo method on Scholix objects and all model properties
  • Unit Test to verify that compareTo works on different case
  • Moved Scholix API Data model into dhp-schemas
To define incremental indexing on Scholexplorer, we need to implement a method that **compare** two Scholix Item. Furthermore, this PR includes also moving the common API schema of Scholix that is quite different from that used from the index into dhp-schema This PR includes: * implementation of the *compareTo* method on Scholix objects and all model properties * Unit Test to verify that compareTo works on different case * Moved Scholix API Data model into dhp-schemas
sandro.labruzzo added 3 commits 2 years ago
sandro.labruzzo added 1 commit 2 years ago
claudio.atzori was assigned by sandro.labruzzo 2 years ago
sandro.labruzzo added 2 commits 2 years ago
claudio.atzori reviewed 2 years ago
pom.xml Outdated
@ -338,0 +352,4 @@
<dependency>
<groupId>io.swagger</groupId>
<artifactId>swagger-annotations</artifactId>
<version>1.5.20</version>
claudio.atzori commented 2 years ago
Owner

The version of each dependency should be indicated under the dependencyManagement element.

The version of each dependency should be indicated under the dependencyManagement element.
sandro.labruzzo marked this conversation as resolved
claudio.atzori reviewed 2 years ago
pom.xml
@ -138,6 +138,9 @@
<artifactId>maven-dependency-plugin</artifactId>
<version>3.0.0</version>
</plugin>
claudio.atzori commented 2 years ago
Owner

Please cleanup non necessary changes.

Please cleanup non necessary changes.
sandro.labruzzo marked this conversation as resolved
claudio.atzori requested changes 2 years ago
claudio.atzori left a comment
Owner

Overall looks good, please check the inline comments.

Overall looks good, please check the inline comments.
sandro.labruzzo added 1 commit 2 years ago
sandro.labruzzo commented 2 years ago
Poster
Owner

The review comment has been fixed. I Think we can merge the PR

The review comment has been fixed. I Think we can merge the PR
sandro.labruzzo added 1 commit 2 years ago
claudio.atzori reviewed 2 years ago
pom.xml
claudio.atzori commented 2 years ago
Owner

This is not necessary

This is not necessary
claudio.atzori reviewed 2 years ago
pom.xml Outdated
@ -338,0 +357,4 @@
<dependency>
<groupId>io.swagger.core.v3</groupId>
<artifactId>swagger-annotations</artifactId>
<version>2.1.12</version>
claudio.atzori commented 2 years ago
Owner

Please move all the dependency versions under the <dependencyManagement> section.

Please move all the dependency versions under the `<dependencyManagement>` section.
sandro.labruzzo marked this conversation as resolved
claudio.atzori requested changes 2 years ago
claudio.atzori left a comment
Owner

Minor changes

Minor changes
claudio.atzori added 1 commit 2 years ago
sandro.labruzzo added 2 commits 2 years ago
sandro.labruzzo requested review from claudio.atzori 2 years ago
sandro.labruzzo added 1 commit 2 years ago
sandro.labruzzo merged commit 4804fb2dd2 into master 2 years ago
sandro.labruzzo deleted branch scholexplorer_incremental_index 2 years ago

Reviewers

claudio.atzori was requested for review 2 years ago
The pull request has been merged as 4804fb2dd2.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b scholexplorer_incremental_index master
git pull origin scholexplorer_incremental_index

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff scholexplorer_incremental_index
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
claudio.atzori
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dhp-schemas#14
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'scholexplorer_incremental_index'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes