D-Net
/
dhp-schemas
9
1
Fork 0
Code Issues 1 Pull Requests 3 Projects Releases Wiki Activity

enrichment #9

Merged
claudio.atzori merged 4 commits from enrichment into master 2022-01-14 09:48:53 +01:00
Conversation 0 Commits 4 Files Changed 4 +724 -8
sandro.labruzzo commented 2022-01-13 15:00:42 +01:00
Owner
Copy Link

This branch implements enrichment on Result specializing in the method mergefrom().
During the merge, when one of the two records has the provenance "enrich" instead of duplicating an instance, we try to enrich only the missing attribute.

This branch implements enrichment on Result specializing in the method **mergefrom()**. During the merge, when one of the two records has the provenance "enrich" instead of duplicating an instance, we try to enrich only the missing attribute.
sandro.labruzzo added 2 commits 2022-01-13 15:00:43 +01:00
sandro.labruzzo added 1 commit 2022-01-14 08:46:24 +01:00
claudio.atzori reviewed 2022-01-14 09:11:07 +01:00
src/main/java/eu/dnetlib/dhp/schema/oaf/Result.java Outdated
@ -245,0 +544,4 @@
* @param pid the pid
* @return the string
*/
private static String normalizePid(final StructuredProperty pid) {
claudio.atzori commented 2022-01-14 09:11:07 +01:00
Owner
Copy Link

A very similar function already exists in this module:

https://code-repo.d4science.org/D-Net/dhp-schemas/src/branch/master/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/CleaningFunctions.java#L50

Consider reusing it, or if its behaviour doesn't exactly match the you you need, consider to adjust it.

A very similar function already exists in this module: https://code-repo.d4science.org/D-Net/dhp-schemas/src/branch/master/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/CleaningFunctions.java#L50 Consider reusing it, or if its behaviour doesn't exactly match the you you need, consider to adjust it.
sandro.labruzzo marked this conversation as resolved
claudio.atzori requested changes 2022-01-14 09:12:47 +01:00
claudio.atzori left a comment
Owner
Copy Link

Let's try reuse already existing utilities. See comment below.

Let's try reuse already existing utilities. See comment below.
sandro.labruzzo added 1 commit 2022-01-14 09:46:46 +01:00
claudio.atzori merged commit fa4cd3963b into master 2022-01-14 09:48:53 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
claudio.atzori
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dhp-schemas#9
No description provided.
Delete Branch "enrichment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?