sabeel
/
dnet-hadoop
forked from D-Net/dnet-hadoop
1
0
Fork 0
Code Pull Requests Activity

added NPE checks

This commit is contained in:
Claudio Atzori 2022-01-21 14:30:09 +01:00
parent 2f385b3ac6
commit c42623f006
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/OafMapperUtils.java
View File

@ -48,8 +48,8 @@ public class OafMapperUtils {
public static Result mergeResults(Result left, Result right) { public static Result mergeResults(Result left, Result right) {
final boolean leftFromDeletedAuthority = isFromDeletedAuthority(left); final boolean leftFromDeletedAuthority = isFromDelegatedAuthority(left);
final boolean rightFromDeletedAuthority = isFromDeletedAuthority(right); final boolean rightFromDeletedAuthority = isFromDelegatedAuthority(right);
if (leftFromDeletedAuthority && !rightFromDeletedAuthority) { if (leftFromDeletedAuthority && !rightFromDeletedAuthority) {
return left; return left;
@ -67,12 +67,16 @@ public class OafMapperUtils {
} }
} }
private static boolean isFromDeletedAuthority(Result r) { private static boolean isFromDelegatedAuthority(Result r) {
return r return Optional
.getInstance() .ofNullable(r.getInstance())
.stream() .map(
.map(i -> i.getCollectedfrom().getKey()) instance -> instance
.anyMatch(cfId -> IdentifierFactory.delegatedAuthorityDatasourceIds().contains(cfId)); .stream()
.filter(i -> Objects.nonNull(i.getCollectedfrom()))
.map(i -> i.getCollectedfrom().getKey())
.anyMatch(cfId -> IdentifierFactory.delegatedAuthorityDatasourceIds().contains(cfId)))
.orElse(false);
} }
public static KeyValue keyValue(final String k, final String v) { public static KeyValue keyValue(final String k, final String v) {