From c1e9f1f89ea7272e6ba7dc0eeddc5b8fc81cfe1d Mon Sep 17 00:00:00 2001
From: Francesco Mangiacrapa <francesco.mangiacrapa@isti.cnr.it>
Date: Mon, 16 Sep 2019 10:19:31 +0000
Subject: [PATCH] [Feature #13327] Checking upload permission before the upload
 starting

git-svn-id: https://svn.d4science.research-infrastructures.eu/gcube/trunk/portlets/widgets/workspace-uploader@181695 82a268e6-3cf1-43bd-a215-b396298e98cf
---
 distro/changelog.xml                          |  3 +++
 .../server/WorkspaceUploadServletStream.java  | 23 +++++++------------
 2 files changed, 11 insertions(+), 15 deletions(-)

diff --git a/distro/changelog.xml b/distro/changelog.xml
index 3300238..583eaa9 100644
--- a/distro/changelog.xml
+++ b/distro/changelog.xml
@@ -5,6 +5,9 @@
 		<Change>[Task #17152] Workspace uploader: avoid . (dot) char added as
 			suffix when the filename does not contain an extension
 		</Change>
+		<Change>
+		[Feature #13327] Checking upload permission before the upload starting
+		</Change>
 	</Changeset>
 	<Changeset
 		component="org.gcube.portlets-widgets.workspace-uploader.2-0-2"
diff --git a/src/main/java/org/gcube/portlets/widgets/workspaceuploader/server/WorkspaceUploadServletStream.java b/src/main/java/org/gcube/portlets/widgets/workspaceuploader/server/WorkspaceUploadServletStream.java
index 9a576a2..91b736c 100644
--- a/src/main/java/org/gcube/portlets/widgets/workspaceuploader/server/WorkspaceUploadServletStream.java
+++ b/src/main/java/org/gcube/portlets/widgets/workspaceuploader/server/WorkspaceUploadServletStream.java
@@ -471,26 +471,19 @@ public class WorkspaceUploadServletStream extends HttpServlet implements Servlet
 		if (!destinationItem.isFolder())  {
 			logger.error("Error processing request in upload servlet: The destination is not a folder");
 			saveWorkspaceUploaderStatus(workspaceUploader, UPLOAD_STATUS.FAILED, "An error occurred during upload: "+fileName+". The destination is not a folder", request.getSession());
-			sendError(response, "Internal error: Wrong destination item");
+			sendError(response, "Internal error: Wrong destination item. The destination is not a folder");
 			return;
 		}
 
 		final WorkspaceFolder destinationFolder = (WorkspaceFolder) destinationItem;
 		
-		if(destinationFolder.isShared()) {
-			try {
-				WorkspaceItem rootSharedFolder = workspace.getRootSharedFolder(destinationFolder.getId());
-				
-				//TODO RETRIEVE USERS BELONGING TO SHARE
-				//TODO RETRIEVE ACL
-				
-				if(rootSharedFolder instanceof WorkspaceSharedFolder) {
-					
-				}
-				
-			} catch (Exception e) {
-				e.printStackTrace();
-			}
+		try {
+			workspace.canUserWriteIntoFolder(destinationFolder.getId());
+		} catch (Exception e1) {
+			logger.warn("The user cannot write in the destination folder with id: {}",destinationFolder.getId());
+			saveWorkspaceUploaderStatus(workspaceUploader, UPLOAD_STATUS.FAILED, "You are not authorized to write into folder: "+destinationFolder.getName(), request.getSession());
+			sendError(response, "Internal error: You are not authorized to write into folder: "+destinationFolder.getName());
+			return;
 		}