From d9b9bd9ac68725170db1e0ef6c427e90298e6454 Mon Sep 17 00:00:00 2001
From: Francesco Mangiacrapa <francesco.mangiacrapa@isti.cnr.it>
Date: Fri, 4 May 2018 12:44:41 +0000
Subject: [PATCH] Enhancement on Project Activity #11690 Updated set method

git-svn-id: http://svn.research-infrastructures.eu/public/d4science/gcube/trunk/Common/workspace-task-executor-library@167324 82a268e6-3cf1-43bd-a215-b396298e98cf
---
 .../dataminer/WorkspaceDataMinerTaskExecutor.java           | 6 ++----
 .../common/workspacetaskexecutor/shared/ExecutableItem.java | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/gcube/common/workspacetaskexecutor/dataminer/WorkspaceDataMinerTaskExecutor.java b/src/main/java/org/gcube/common/workspacetaskexecutor/dataminer/WorkspaceDataMinerTaskExecutor.java
index 293f3ca..d9adc84 100644
--- a/src/main/java/org/gcube/common/workspacetaskexecutor/dataminer/WorkspaceDataMinerTaskExecutor.java
+++ b/src/main/java/org/gcube/common/workspacetaskexecutor/dataminer/WorkspaceDataMinerTaskExecutor.java
@@ -257,7 +257,7 @@ public class WorkspaceDataMinerTaskExecutor implements ExecutableTask<TaskConfig
 	 * @see org.gcube.common.workspacetaskexecutor.ConfigurableTask#addTaskConfig(java.lang.Object)
 	 */
 	@Override
-	public Boolean setTaskConfiguration(TaskConfiguration taskConfiguration) throws Exception {
+	public void setTaskConfiguration(TaskConfiguration taskConfiguration) throws Exception {
 		logger.debug("Set task configuration "+taskConfiguration+" starts...");
 		ValidateTaskConfiguration(taskConfiguration);
 		checkOwner();
@@ -267,7 +267,7 @@ public class WorkspaceDataMinerTaskExecutor implements ExecutableTask<TaskConfig
 		List<TaskConfiguration> configurations = getListOfTaskConfigurations(taskConfiguration.getWorkspaceItemId());
 
 		if(configurations==null)
-			configurations = new ArrayList<TaskConfiguration>(1); //It is the first configuration servert-side
+			configurations = new ArrayList<TaskConfiguration>(1); //It is the first configuration server-side
 
 		List<TaskConfiguration> newConfigurations = new ArrayList<TaskConfiguration>(configurations.size());
 
@@ -295,8 +295,6 @@ public class WorkspaceDataMinerTaskExecutor implements ExecutableTask<TaskConfig
 			logger.error("Error on saving Task Configuration: "+taskConfiguration, e);
 			throw new Exception("Error on saving Task Configuration: "+taskConfiguration+", Please retry");
 		}
-
-		return true;
 	}
 
 	/* (non-Javadoc)
diff --git a/src/main/java/org/gcube/common/workspacetaskexecutor/shared/ExecutableItem.java b/src/main/java/org/gcube/common/workspacetaskexecutor/shared/ExecutableItem.java
index 8519345..95e20e6 100644
--- a/src/main/java/org/gcube/common/workspacetaskexecutor/shared/ExecutableItem.java
+++ b/src/main/java/org/gcube/common/workspacetaskexecutor/shared/ExecutableItem.java
@@ -38,7 +38,7 @@ public interface ExecutableItem<T extends BaseTaskConfiguration> {
 	 * @throws ItemNotExecutableException the item not executable exception
 	 * @throws Exception the exception
 	 */
-	Boolean setTaskConfiguration(T config) throws ItemNotExecutableException, Exception;
+	void setTaskConfiguration(T config) throws ItemNotExecutableException, Exception;
 
 
 	/**