Compare commits

..

3 Commits

Author SHA1 Message Date
Francesco Mangiacrapa 5eb595ff9a updated profiles 2024-09-24 12:16:06 +02:00
Francesco Mangiacrapa b42d4a7d3b removed -SNAPSHOT to be released 2024-09-20 11:07:35 +02:00
Francesco Mangiacrapa 70d10388d5 - Fixed `acl.getPricipal()` as `acl.getPrincipal()`
- Moved to maven-portal-bom 4.0.0{-SNAPSHOT}
2024-09-19 17:11:52 +02:00
6 changed files with 63 additions and 19 deletions

View File

@ -11,11 +11,13 @@
<attributes> <attributes>
<attribute name="optional" value="true"/> <attribute name="optional" value="true"/>
<attribute name="maven.pomderived" value="true"/> <attribute name="maven.pomderived" value="true"/>
<attribute name="test" value="true"/>
</attributes> </attributes>
</classpathentry> </classpathentry>
<classpathentry excluding="**" kind="src" output="target/test-classes" path="src/test/resources"> <classpathentry excluding="**" kind="src" output="target/test-classes" path="src/test/resources">
<attributes> <attributes>
<attribute name="maven.pomderived" value="true"/> <attribute name="maven.pomderived" value="true"/>
<attribute name="test" value="true"/>
</attributes> </attributes>
</classpathentry> </classpathentry>
<classpathentry kind="con" path="org.maven.ide.eclipse.MAVEN2_CLASSPATH_CONTAINER"> <classpathentry kind="con" path="org.maven.ide.eclipse.MAVEN2_CLASSPATH_CONTAINER">

View File

@ -3,6 +3,9 @@ org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8 org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8
org.eclipse.jdt.core.compiler.compliance=1.7 org.eclipse.jdt.core.compiler.compliance=1.7
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
org.eclipse.jdt.core.compiler.problem.enablePreviewFeatures=disabled
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning
org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures=ignore
org.eclipse.jdt.core.compiler.release=disabled
org.eclipse.jdt.core.compiler.source=1.7 org.eclipse.jdt.core.compiler.source=1.7

View File

@ -1,11 +1,15 @@
# Changelog # Changelog
## [v1.11.0][r5.0.0] - 2021-02-02 ## [v1.12.0] - 2024-09-19
- Fixed `acl.getPricipal()` as `acl.getPrincipal()`
- Moved to maven-portal-bom 4.0.0{-SNAPSHOT}
## [v1.11.0] - 2021-02-02
### Features ### Features
- Updated the set administrator method for VRE folders [#19952] - Updated the set administrator method for VRE folders [#19952]
- Removed social networking library dependency [#26538]

41
pom.xml
View File

@ -5,7 +5,7 @@
<parent> <parent>
<artifactId>maven-parent</artifactId> <artifactId>maven-parent</artifactId>
<groupId>org.gcube.tools</groupId> <groupId>org.gcube.tools</groupId>
<version>1.1.0</version> <version>1.2.0</version>
<relativePath /> <relativePath />
</parent> </parent>
@ -14,7 +14,7 @@
<groupId>org.gcube.portlets.widgets</groupId> <groupId>org.gcube.portlets.widgets</groupId>
<artifactId>workspace-sharing-widget</artifactId> <artifactId>workspace-sharing-widget</artifactId>
<packaging>jar</packaging> <packaging>jar</packaging>
<version>1.11.0</version> <version>1.12.0</version>
<name>gCube Workspace Sharing Widget</name> <name>gCube Workspace Sharing Widget</name>
<description> <description>
Workspace Sharing Widget is a widget that allows the sharing of items present in the D4Science Workspace. Workspace Sharing Widget is a widget that allows the sharing of items present in the D4Science Workspace.
@ -39,12 +39,40 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
</properties> </properties>
<!-- Profiles required for managing SHUB vesion via maven-portal-bom -->
<profiles>
<!-- PROD profile -->
<profile>
<id>workspace-sharing-widget-release-profile</id>
<activation>
<property>
<name>Release</name>
</property>
</activation>
<properties>
<maven-portal-bom>4.0.0</maven-portal-bom>
</properties>
</profile>
<!-- DEV profile -->
<profile>
<id>workspace-sharing-widget-snapshot-profile</id>
<activation>
<property>
<name>!Release</name>
</property>
</activation>
<properties>
<maven-portal-bom>4.0.0-SNAPSHOT</maven-portal-bom>
</properties>
</profile>
</profiles>
<dependencyManagement> <dependencyManagement>
<dependencies> <dependencies>
<dependency> <dependency>
<groupId>org.gcube.distribution</groupId> <groupId>org.gcube.distribution</groupId>
<artifactId>maven-portal-bom</artifactId> <artifactId>maven-portal-bom</artifactId>
<version>3.6.0</version> <version>${maven-portal-bom}</version>
<type>pom</type> <type>pom</type>
<scope>import</scope> <scope>import</scope>
</dependency> </dependency>
@ -143,6 +171,13 @@
<scope>provided</scope> <scope>provided</scope>
</dependency> </dependency>
<dependency>
<groupId>org.gcube.portal</groupId>
<artifactId>social-networking-library</artifactId>
<version>[1.0.0, 2.0.0-SNAPSHOT)</version>
<scope>provided</scope>
</dependency>
<dependency> <dependency>
<groupId>org.gcube.applicationsupportlayer</groupId> <groupId>org.gcube.applicationsupportlayer</groupId>
<artifactId>aslsocial</artifactId> <artifactId>aslsocial</artifactId>

View File

@ -820,18 +820,18 @@ public class GWTWorkspaceSharingBuilder {
List<String> users = aclOwner.get(accessType); List<String> users = aclOwner.get(accessType);
boolean notfound = true; boolean notfound = true;
for (String user : users) { for (String user : users) {
if (user.compareTo(acl.getPricipal()) == 0) { if (user.compareTo(acl.getPrincipal()) == 0) {
notfound = false; notfound = false;
break; break;
} }
} }
if (notfound) { if (notfound) {
users.add(acl.getPricipal()); users.add(acl.getPrincipal());
aclOwner.put(accessType, users); aclOwner.put(accessType, users);
} }
} else { } else {
List<String> users = new ArrayList<String>(); List<String> users = new ArrayList<String>();
users.add(acl.getPricipal()); users.add(acl.getPrincipal());
aclOwner.put(accessType, users); aclOwner.put(accessType, users);
} }
} }

View File

@ -905,10 +905,10 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
List<ACL> acls = folderContainer.getAcls(); List<ACL> acls = folderContainer.getAcls();
for (ACL acl : acls) { for (ACL acl : acls) {
if (acl.getPricipal().compareTo(currentUser) != 0) { if (acl.getPrincipal().compareTo(currentUser) != 0) {
for (AccessType accessType : acl.getAccessTypes()) { for (AccessType accessType : acl.getAccessTypes()) {
if (AccessType.ADMINISTRATOR.compareTo(accessType) == 0) { if (AccessType.ADMINISTRATOR.compareTo(accessType) == 0) {
alreadyAdministrators.add(acl.getPricipal()); alreadyAdministrators.add(acl.getPrincipal());
} }
} }
} }
@ -921,7 +921,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
if (currentUser.compareTo(user) != 0) { if (currentUser.compareTo(user) != 0) {
alreadyShared = false; alreadyShared = false;
for (ACL acl : acls) { for (ACL acl : acls) {
if (user.compareTo(acl.getPricipal()) == 0) { if (user.compareTo(acl.getPrincipal()) == 0) {
alreadyShared = true; alreadyShared = true;
break; break;
} }
@ -982,7 +982,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
} }
} }
if (isAdmin) { if (isAdmin) {
admins.add(acl.getPricipal()); admins.add(acl.getPrincipal());
} }
} }
logger.debug("Retrieved admins list: " + admins); logger.debug("Retrieved admins list: " + admins);
@ -1189,7 +1189,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
if (listACL != null) { if (listACL != null) {
ACL userACL = null; ACL userACL = null;
for (ACL acl : listACL) { for (ACL acl : listACL) {
if (currentUser.compareTo(acl.getPricipal()) == 0) { if (currentUser.compareTo(acl.getPrincipal()) == 0) {
userACL = acl; userACL = acl;
break; break;
} }
@ -1356,7 +1356,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
logger.debug("Retrieved acls: " + acls); logger.debug("Retrieved acls: " + acls);
ACL currentUserACL = null; ACL currentUserACL = null;
for (ACL acl : acls) { for (ACL acl : acls) {
if (acl.getPricipal().compareTo(currentUser) == 0) { if (acl.getPrincipal().compareTo(currentUser) == 0) {
currentUserACL = acl; currentUserACL = acl;
break; break;
} }
@ -1371,7 +1371,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
GCubeGroup vre = listVRE.get(i); GCubeGroup vre = listVRE.get(i);
String vreName = vre.getGroupName(); String vreName = vre.getGroupName();
for (ACL acl : acls) { for (ACL acl : acls) {
String principal = acl.getPricipal(); String principal = acl.getPrincipal();
String rootVO = PortalContext.getConfiguration().getInfrastructureName(); String rootVO = PortalContext.getConfiguration().getInfrastructureName();
if (principal.startsWith(rootVO)) { if (principal.startsWith(rootVO)) {
String tempScope = principal.substring(rootVO.length()); String tempScope = principal.substring(rootVO.length());
@ -1726,7 +1726,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
} }
} }
if (isAdmin) { if (isAdmin) {
admins.add(acl.getPricipal()); admins.add(acl.getPrincipal());
} }
} }
@ -1753,7 +1753,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
logger.trace("\nChecking username: " + username); logger.trace("\nChecking username: " + username);
String fullname = isTestMode() ? username : UserUtil.getUserFullName(username); String fullname = isTestMode() ? username : UserUtil.getUserFullName(username);
for (ACL acl : acls) { for (ACL acl : acls) {
if (acl.getPricipal().compareTo(username) == 0) { if (acl.getPrincipal().compareTo(username) == 0) {
checkAccessType(settingACL, errors, comparator, validLogins, username, fullname, acl); checkAccessType(settingACL, errors, comparator, validLogins, username, fullname, acl);
break; break;
} }
@ -1863,7 +1863,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
List<ACL> acls = folderContainer.getAcls(); List<ACL> acls = folderContainer.getAcls();
boolean isAdmin; boolean isAdmin;
for (ACL acl : acls) { for (ACL acl : acls) {
if (acl.getPricipal().compareTo(currentUser) != 0) { if (acl.getPrincipal().compareTo(currentUser) != 0) {
isAdmin = false; isAdmin = false;
for (AccessType accessType : acl.getAccessTypes()) { for (AccessType accessType : acl.getAccessTypes()) {
if (accessType.compareTo(AccessType.ADMINISTRATOR) == 0) { if (accessType.compareTo(AccessType.ADMINISTRATOR) == 0) {
@ -1873,7 +1873,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
} }
if (!isAdmin) { if (!isAdmin) {
folderContainer = folderContainer.changeAcls(acl.getPricipal(), selectedAccessType); folderContainer = folderContainer.changeAcls(acl.getPrincipal(), selectedAccessType);
} }
} }
} }