ref 13226:StorageHub - Update workspace-sharing-widget to SH

https://support.d4science.org/issues/13226

Fixed share folder with multiple users

git-svn-id: https://svn.d4science.research-infrastructures.eu/gcube/trunk/portlets/widgets/workspace-sharing-widget@179300 82a268e6-3cf1-43bd-a215-b396298e98cf

src/main/java/org/gcube/portlets/widgets/workspacesharingwidget/server/WorkspaceSharingServiceImpl.java

@@ -492,7 +492,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
 						logger.debug("Folder is not shared");
 						Set<String> logins = new HashSet<>(listLogin);
 						logger.debug("Share logins: " + logins);
-						folderContainer=folderContainer.share(logins, getAccessType(acl));
+						folderContainer = folderContainer.share(logins, getAccessType(acl));
 						logger.debug("Shared done");
 						created = true;
 						NotificationsProducer np = getNotificationProducer(this.getThreadLocalRequest());
@@ -717,9 +717,15 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
 	}
 
 	private List<InfoContactModel> retrieveAdminContactsFromACLs(FolderContainer folderContainer) throws Exception {
+		if (folderContainer == null) {
+			logger.debug("FolderContainer is null");
+			return new ArrayList<InfoContactModel>();
+		} else {
+			logger.debug("Retrieve Admins for: " + folderContainer.get());
+			List<String> admins = new ArrayList<>();
+
 			List<ACL> acls = folderContainer.getAcls();
 			logger.debug("Retrieved acls: " + acls);
-		List<String> admins = new ArrayList<>();
 			for (ACL acl : acls) {
 				boolean isAdmin = false;
 				for (AccessType accesstype : acl.getAccessTypes()) {
@@ -736,6 +742,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
 			GWTWorkspaceSharingBuilder builder = new GWTWorkspaceSharingBuilder();
 			return builder.buildGxtInfoContactsFromPortalLogins(admins);
 		}
+	}
 
 	// /**
 	// * DEBUG.
@@ -1088,18 +1095,24 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
 					GWTWorkspaceSharingBuilder builder = new GWTWorkspaceSharingBuilder();
 
 					List<InfoContactModel> listContactsModel = builder.buildGXTListContactsModelFromUserModel(info);
+					boolean ownerFound = false;
 					for (InfoContactModel icm : listContactsModel) {
 						if (icm.getLogin().compareTo(folderItem.getOwner()) == 0) {
-							logger.debug("Retrieved: " + icm);
+							logger.debug("Owner Retrieved: " + icm);
 							owner = icm;
+							ownerFound = true;
+							break;
+
 						}
 					}
+					if (!ownerFound) {
 						logger.debug("Owner not found from user model!");
-					owner = new InfoContactModel(folderItem.getOwner(), folderItem.getOwner(), folderItem.getOwner(),
+						owner = new InfoContactModel(folderItem.getOwner(), folderItem.getOwner(),
-							false);
+								folderItem.getOwner(), false);
+					}
 				} else {
 					logger.debug("Owner not found from item");
-					owner = new InfoContactModel();
+					owner = null;
 				}
 
 				String username = info.getUsername();
@@ -1108,22 +1121,20 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
 					return new AllowAccess(itemId, true, "The folder is already public. Access granted to " + username,
 							null);
 				}
-				logger.info("owner of: " + folderItem.getName() + " is: " + owner);
+				logger.info("The owner of: " + folderItem.getName() + " is: " + owner);
-				logger.info("current context user: " + username);
+				logger.info("The current context user: " + username);
-				if (owner.getLogin().compareToIgnoreCase(username) == 0) {
+				if (owner != null && owner.getLogin().compareToIgnoreCase(username) == 0) {
 					logger.info("Access to Folder Link " + folderItem.getName() + " granted, " + username
 							+ " is the owner of: " + itemId);
 					return new AllowAccess(itemId, true,
 							info.getUserFullName() + " is the owner of: " + folderItem.getName(), null);
 				}
-
 				try {
 					List<InfoContactModel> admins = null;
 
 					if (folderItem.isShared()) {
 						if (folderItem instanceof SharedFolder) {
 							admins = retrieveAdminContactsFromACLs(folderContainer);
-
 						} else {
 							FolderContainer rootSharedFolderContainer = folderContainer.getRootSharedFolder();
 							FolderItem rootSharedFolder = rootSharedFolderContainer.get();
@@ -1142,6 +1153,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
 								"The item requested is not a valid shared folder : [itemId=" + itemId + "]");
 					}
 
+					if (admins != null) {
 						for (InfoContactModel infoContactModel : admins) {
 							if (infoContactModel.getLogin().compareToIgnoreCase(username) == 0) {
 								logger.info("Access to Folder Link " + logger.getName() + " granted, " + username
@@ -1150,6 +1162,11 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
 										info.getUserFullName() + " is the admin of: " + folderItem.getName(), null);
 							}
 						}
+					} else {
+						return new AllowAccess(itemId, false,
+								"You have not permission to get Folder Link, you must be owner or administrator to the folder", "Permission not found");
+					
+					}
 				} catch (Exception e) {
 					return new AllowAccess(itemId, false,
 							"You have not permission to get Folder Link, you must be owner or administrator to the folder",
@@ -1163,9 +1180,7 @@ public class WorkspaceSharingServiceImpl extends RemoteServiceServlet implements
 				return new AllowAccess(itemId, false, "The item is not a folder", null);
 			}
 
-		} catch (
+		} catch (Exception e) {
-
-		Exception e) {
 			logger.error("Error in server FormattedGcubeItemProperties: " + e.getLocalizedMessage(), e);
 			String error = "Error when reading access policy to Folder Link: " + itemId + ", Refresh and try again";
 			throw new Exception(error, e);