fixed bug in reference with empty values

git-svn-id: http://svn.research-infrastructures.eu/public/d4science/gcube/trunk/portlets/user/reports@86277 82a268e6-3cf1-43bd-a215-b396298e98cf
This commit is contained in:
Massimiliano Assante 2013-11-27 13:51:58 +00:00
parent 3d07be06cf
commit 90d4d439dc
10 changed files with 19 additions and 30 deletions

View File

@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<classpath> <classpath>
<classpathentry kind="src" output="target/reports-4.6.6-SNAPSHOT/WEB-INF/classes" path="src/main/java"> <classpathentry kind="src" output="target/reports-4.6.7-SNAPSHOT/WEB-INF/classes" path="src/main/java">
<attributes> <attributes>
<attribute name="optional" value="true"/> <attribute name="optional" value="true"/>
<attribute name="maven.pomderived" value="true"/> <attribute name="maven.pomderived" value="true"/>
@ -31,5 +31,5 @@
</attributes> </attributes>
</classpathentry> </classpathentry>
<classpathentry kind="con" path="com.google.gwt.eclipse.core.GWT_CONTAINER"/> <classpathentry kind="con" path="com.google.gwt.eclipse.core.GWT_CONTAINER"/>
<classpathentry kind="output" path="target/reports-4.6.6-SNAPSHOT/WEB-INF/classes"/> <classpathentry kind="output" path="target/reports-4.6.7-SNAPSHOT/WEB-INF/classes"/>
</classpath> </classpath>

View File

@ -2,6 +2,6 @@
<<<<<<<=.mine <<<<<<<=.mine
>>>>>>>=.r71295 >>>>>>>=.r71295
eclipse.preferences.version=1 eclipse.preferences.version=1
lastWarOutDir=/Users/massi/Documents/workspace/reports/target/reports-4.6.6-SNAPSHOT lastWarOutDir=/Users/massi/Documents/workspace/reports/target/reports-4.6.7-SNAPSHOT
warSrcDir=src/main/webapp warSrcDir=src/main/webapp
warSrcDirIsOutput=false warSrcDirIsOutput=false

View File

@ -12,7 +12,7 @@
<groupId>org.gcube.portlets.user</groupId> <groupId>org.gcube.portlets.user</groupId>
<artifactId>reports</artifactId> <artifactId>reports</artifactId>
<packaging>war</packaging> <packaging>war</packaging>
<version>4.6.6-SNAPSHOT</version> <version>4.6.7-SNAPSHOT</version>
<name>gCube Reports Manager</name> <name>gCube Reports Manager</name>
<description> <description>
gCube Reports Portlet. gCube Reports Portlet.
@ -119,12 +119,7 @@
<dependency> <dependency>
<groupId>com.allen-sauer.gwt.log</groupId> <groupId>com.allen-sauer.gwt.log</groupId>
<artifactId>gwt-log</artifactId> <artifactId>gwt-log</artifactId>
</dependency> </dependency>
<dependency>
<groupId>org.gcube.portlets.widgets</groupId>
<artifactId>user-selection-dialog</artifactId>
<version>[1.0.1-SNAPSHOT, 2.0.0-SNAPSHOT)</version>
</dependency>
<dependency> <dependency>
<groupId>org.gcube.application</groupId> <groupId>org.gcube.application</groupId>
<artifactId>gcube-reporting-modeler</artifactId> <artifactId>gcube-reporting-modeler</artifactId>

View File

@ -463,11 +463,11 @@ public class Headerbar extends Composite{
// optionEncryptedModel.setHTML(EXPORT_ENCRYPTED_REPORT); // optionEncryptedModel.setHTML(EXPORT_ENCRYPTED_REPORT);
// //
importModel.setHTML("Import from Template or Report"); // importModel.setHTML("Import from Template or Report");
importModel.setScheduledCommand(importModelOrReport); // importModel.setScheduledCommand(importModelOrReport);
//
viewMetadata.setHTML("View Metadata"); // viewMetadata.setHTML("View Metadata");
viewMetadata.setScheduledCommand(openMetadata); // viewMetadata.setScheduledCommand(openMetadata);
// discardSection.setHTML("Discard current"); // discardSection.setHTML("Discard current");

View File

@ -5,7 +5,6 @@ import java.util.List;
import org.gcube.portlets.d4sreporting.common.client.uicomponents.richtext.RichTextToolbar; import org.gcube.portlets.d4sreporting.common.client.uicomponents.richtext.RichTextToolbar;
import org.gcube.portlets.d4sreporting.common.shared.BasicSection; import org.gcube.portlets.d4sreporting.common.shared.BasicSection;
import org.gcube.portlets.d4sreporting.common.shared.ComponentType;
import org.gcube.portlets.d4sreporting.common.shared.Metadata; import org.gcube.portlets.d4sreporting.common.shared.Metadata;
import org.gcube.portlets.d4sreporting.common.shared.Model; import org.gcube.portlets.d4sreporting.common.shared.Model;
import org.gcube.portlets.d4sreporting.common.shared.ReportReferences; import org.gcube.portlets.d4sreporting.common.shared.ReportReferences;
@ -62,7 +61,6 @@ import org.gcube.portlets.widgets.exporter.client.event.ExportingCompletedEventH
import org.gcube.portlets.widgets.exporter.client.event.ReportExporterEvent; import org.gcube.portlets.widgets.exporter.client.event.ReportExporterEvent;
import org.gcube.portlets.widgets.exporter.client.event.ReportExporterEventHandler; import org.gcube.portlets.widgets.exporter.client.event.ReportExporterEventHandler;
import org.gcube.portlets.widgets.exporter.shared.TypeExporter; import org.gcube.portlets.widgets.exporter.shared.TypeExporter;
import org.gcube.portlets.widgets.userselection.client.UserSelectionDialog;
import com.extjs.gxt.ui.client.widget.MessageBox; import com.extjs.gxt.ui.client.widget.MessageBox;
import com.google.gwt.core.client.GWT; import com.google.gwt.core.client.GWT;
@ -138,8 +136,6 @@ public class Presenter {
} }
private UserSelectionDialog itemSelectionDialog;
private void handleEvents() { private void handleEvents() {
eventBus.addHandler(SelectedReportEvent.TYPE, new SelectedReportEventHandler() { eventBus.addHandler(SelectedReportEvent.TYPE, new SelectedReportEventHandler() {

View File

@ -8,7 +8,6 @@ import org.gcube.portlets.d4sreporting.common.shared.RepeatableSequence;
import org.gcube.portlets.user.reportgenerator.client.Presenter.Presenter; import org.gcube.portlets.user.reportgenerator.client.Presenter.Presenter;
import org.gcube.portlets.user.reportgenerator.client.model.TemplateComponent; import org.gcube.portlets.user.reportgenerator.client.model.TemplateComponent;
import com.google.gwt.core.client.GWT;
import com.google.gwt.user.client.ui.Composite; import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.VerticalPanel; import com.google.gwt.user.client.ui.VerticalPanel;
@ -99,7 +98,6 @@ public class ClientRepeatableSequence extends Composite implements ClientSequenc
public void add(TemplateComponent toAdd) { public void add(TemplateComponent toAdd) {
if (toAdd.getType() != ComponentType.REPEAT_SEQUENCE_INNER) { if (toAdd.getType() != ComponentType.REPEAT_SEQUENCE_INNER) {
groupedComponents.add(toAdd); groupedComponents.add(toAdd);
GWT.log("ToAdd= getType " + toAdd.getType());
myPanel.add(toAdd.getContent()); myPanel.add(toAdd.getContent());
} }
} }

View File

@ -67,14 +67,13 @@ public class ClientReportReference extends Composite implements ClientSequence {
} }
private boolean isTupleEmpty(Tuple toCheck) { private boolean isTupleEmpty(Tuple toCheck) {
boolean toReturn = false; boolean toReturn = true;
for (BasicComponent bc : toCheck.getGroupedComponents()) { for (BasicComponent bc : toCheck.getGroupedComponents()) {
if (bc.getPossibleContent() == null) if (bc.getPossibleContent() != null)
return true; return false;
} }
return toReturn; return toReturn;
} }
public ArrayList<Tuple> getTupleList() { public ArrayList<Tuple> getTupleList() {

View File

@ -173,7 +173,6 @@ public class SequenceWidget extends Composite {
if (toAdd.getType() != ComponentType.REPEAT_SEQUENCE_INNER) { if (toAdd.getType() != ComponentType.REPEAT_SEQUENCE_INNER) {
owner.getGroupedComponents().add(toAdd); owner.getGroupedComponents().add(toAdd);
seqGroupedComponents.add(toAdd); seqGroupedComponents.add(toAdd);
GWT.log("ToAdd= getType " + toAdd.getType());
myPanel.add(toAdd.getContent()); myPanel.add(toAdd.getContent());
} }
} }

View File

@ -93,7 +93,6 @@ import org.gcube.portlets.user.reportgenerator.shared.VMETypeIdentifier;
import org.gcube.portlets.widgets.exporter.shared.SaveReportFileException; import org.gcube.portlets.widgets.exporter.shared.SaveReportFileException;
import org.gcube.portlets.widgets.exporter.shared.SaveReportFileExistException; import org.gcube.portlets.widgets.exporter.shared.SaveReportFileExistException;
import org.gcube.portlets.widgets.exporter.shared.TypeExporter; import org.gcube.portlets.widgets.exporter.shared.TypeExporter;
import org.gcube.portlets.widgets.userselection.shared.ItemSelectableBean;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -103,8 +102,6 @@ import com.liferay.portal.service.LockLocalServiceUtil;
import com.liferay.portal.service.UserLocalServiceUtil; import com.liferay.portal.service.UserLocalServiceUtil;
import com.liferay.portlet.documentlibrary.model.DLFileEntry; import com.liferay.portlet.documentlibrary.model.DLFileEntry;
import edu.emory.mathcs.backport.java.util.Arrays;
/** /**
@ -376,6 +373,12 @@ public class ReportServiceImpl extends RemoteServiceServlet implements ReportSe
OpenReportLogEntry logEntry = new OpenReportLogEntry(toReturn.getTemplateName(), templateObjectID); OpenReportLogEntry logEntry = new OpenReportLogEntry(toReturn.getTemplateName(), templateObjectID);
log.logEntry(getASLSession().getUsername(), getASLSession().getScopeName(), logEntry); log.logEntry(getASLSession().getUsername(), getASLSession().getScopeName(), logEntry);
try {
ReportsReader.readReportStructure(toReturn);
} catch (Exception e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
return toReturn; return toReturn;
} }
} }

View File

@ -6,7 +6,6 @@
<!-- To Comment out --> <!-- To Comment out -->
<!-- <set-property name="user.agent" value="gecko1_8" /> --> <!-- <set-property name="user.agent" value="gecko1_8" /> -->
<inherits name='org.gcube.portlets.widgets.userselection.UserSelection' />
<inherits <inherits
name='org.gcube.portlets.widgets.lighttree.WorkspacePortletLightTree' /> name='org.gcube.portlets.widgets.lighttree.WorkspacePortletLightTree' />
<inherits name='org.gcube.portlets.user.gcubewidgets.WidgetFactory' /> <inherits name='org.gcube.portlets.user.gcubewidgets.WidgetFactory' />