From 25e2ceab1b37878122f45cec7a46a5e82e9136b0 Mon Sep 17 00:00:00 2001
From: Giancarlo Panichi <giancarlo.panichi@isti.cnr.it>
Date: Tue, 3 Mar 2015 11:46:57 +0000
Subject: [PATCH] Minor Update

git-svn-id: https://svn.d4science.research-infrastructures.eu/gcube/trunk/portlets/user/tabular-data-column-widget@112316 82a268e6-3cf1-43bd-a215-b396298e98cf
---
 .../client/ChangeColumnTypeDialog.java        | 38 ++++++++-----------
 .../client/ChangeColumnTypePanel.java         |  4 +-
 2 files changed, 17 insertions(+), 25 deletions(-)

diff --git a/src/main/java/org/gcube/portlets/user/td/columnwidget/client/ChangeColumnTypeDialog.java b/src/main/java/org/gcube/portlets/user/td/columnwidget/client/ChangeColumnTypeDialog.java
index 3e4f11d..4506b2b 100644
--- a/src/main/java/org/gcube/portlets/user/td/columnwidget/client/ChangeColumnTypeDialog.java
+++ b/src/main/java/org/gcube/portlets/user/td/columnwidget/client/ChangeColumnTypeDialog.java
@@ -1,57 +1,50 @@
 package org.gcube.portlets.user.td.columnwidget.client;
 
-import org.gcube.portlets.user.td.gwtservice.shared.tr.ColumnData;
 import org.gcube.portlets.user.td.widgetcommonevent.shared.TRId;
 
 import com.google.web.bindery.event.shared.EventBus;
 import com.sencha.gxt.widget.core.client.Window;
 import com.sencha.gxt.widget.core.client.event.SelectEvent;
 import com.sencha.gxt.widget.core.client.event.SelectEvent.SelectHandler;
-import com.sencha.gxt.widget.core.client.form.ComboBox;
 
 /**
- * Dialog for Change Column Type 
+ * Dialog for Change Column Type
  * 
- * @author "Giancarlo Panichi" 
- * <a href="mailto:g.panichi@isti.cnr.it">g.panichi@isti.cnr.it</a> 
+ * @author "Giancarlo Panichi" <a
+ *         href="mailto:g.panichi@isti.cnr.it">g.panichi@isti.cnr.it</a>
  *
  */
 public class ChangeColumnTypeDialog extends Window {
-	protected String WIDTH = "650px";
-	protected String HEIGHT = "530px";
-	protected TRId trId;
-	
-	protected String columnName=null;
-	protected ComboBox<ColumnData> combo=null;
+	private static final String WIDTH = "650px";
+	private static final String HEIGHT = "530px";
 	
+
 	public ChangeColumnTypeDialog(TRId trId, EventBus eventBus) {
 		create(trId, null, eventBus);
 	}
 
-	public ChangeColumnTypeDialog(TRId trId, String columnName, EventBus eventBus) {
+	public ChangeColumnTypeDialog(TRId trId, String columnName,
+			EventBus eventBus) {
 		create(trId, columnName, eventBus);
 	}
 
 	protected void create(TRId trId, String columnName, EventBus eventBus) {
-		this.trId=trId;
-		this.columnName=columnName;
 		initWindow();
-		ChangeColumnTypePanel changeColumnTypePanel= new ChangeColumnTypePanel(trId, columnName, eventBus);
+		ChangeColumnTypePanel changeColumnTypePanel = new ChangeColumnTypePanel(
+				trId, columnName, eventBus);
 		add(changeColumnTypePanel);
-		
-		
+
 	}
-	
+
 	protected void initWindow() {
 		setWidth(WIDTH);
 		setHeight(HEIGHT);
 		setBodyBorder(false);
 		setResizable(false);
 		setHeadingText("Change Column Type");
-		//getHeader().setIcon(Resources.IMAGES.side_list());
+		// getHeader().setIcon(Resources.IMAGES.side_list());
 	}
-	
-	
+
 	/**
 	 * {@inheritDoc}
 	 */
@@ -72,6 +65,5 @@ public class ChangeColumnTypeDialog extends Window {
 		hide();
 
 	}
-	
-	
+
 }
diff --git a/src/main/java/org/gcube/portlets/user/td/columnwidget/client/ChangeColumnTypePanel.java b/src/main/java/org/gcube/portlets/user/td/columnwidget/client/ChangeColumnTypePanel.java
index 994ccfa..ba05da6 100644
--- a/src/main/java/org/gcube/portlets/user/td/columnwidget/client/ChangeColumnTypePanel.java
+++ b/src/main/java/org/gcube/portlets/user/td/columnwidget/client/ChangeColumnTypePanel.java
@@ -98,8 +98,8 @@ public class ChangeColumnTypePanel extends FramedPanel implements
 
 	}
 
-	private String WIDTH = "640px";
-	private String HEIGHT = "520px";
+	private static final String WIDTH = "640px";
+	private static final String HEIGHT = "520px";
 	private EventBus eventBus;
 	private ChangeColumnTypeDialog parent;
 	private TRId trId;