gCubeSystem
/
oidc-library-portal
17
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Changed OIDC/UMA refreshing errors log to DEBUG to avoid logs flood (#27536)

This commit is contained in:
Mauro Mugnaini 2024-11-12 11:52:56 +01:00
parent 5cd951d641
commit 3eaf89964e
Signed by: mauro.mugnaini
GPG Key ID: 2440CFD0EB321EA8
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
## [v1.4.0] ## [v1.4.0]
- New handling for missing refresh token and refresh token expired in OIDC token when refreshing it. - New handling for missing refresh token and refresh token expired in OIDC token when refreshing it.
- Changed OIDC related exceptions: the cause exception can be an OpenIdConnectRESTHelperException only. - Changed OIDC related exceptions: the cause exception can be an OpenIdConnectRESTHelperException only.
- Changed OIDC/UMA refreshing errors log to DEBUG to avoid logs flood (#27536)
## [v1.3.2] - 2023-04-18 ## [v1.3.2] - 2023-04-18
- UserSitesToGroupsAndRolesMapper class is now more resilient to Groups that are not found in Liferay and for which the LiferayGroupManager returns -1 as its Id instead of exception throwing (#24831) - UserSitesToGroupsAndRolesMapper class is now more resilient to Groups that are not found in Liferay and for which the LiferayGroupManager returns -1 as its Id instead of exception throwing (#24831)

14
src/main/java/org/gcube/portal/oidc/lr62/OIDCUmaUtil.java
View File

@ -233,10 +233,10 @@ public class OIDCUmaUtil {
} else if (OpenIdConnectRESTHelper.isTokenNotActiveError(e.getResponseString())) { } else if (OpenIdConnectRESTHelper.isTokenNotActiveError(e.getResponseString())) {
log.info("UMA token is no more active, get new one"); log.info("UMA token is no more active, get new one");
} else { } else {
log.error("Other UMA token refresh error", e); log.error("Other unexpected UMA token refresh error", e);
} }
} else { } else {
log.error("Refreshing UMA token on server " + umaToken.getTokenEssentials(), e); log.warn("Refreshing UMA token on server for {}: {}", umaToken.getTokenEssentials(), e.getMessage());
} }
umaToken = null; umaToken = null;
log.debug( log.debug(
@ -381,7 +381,7 @@ public class OIDCUmaUtil {
return; return;
} catch (MissingRefreshTokenException e) { } catch (MissingRefreshTokenException e) {
if (FORCE_LOGOUT_ON_MISSING_OIDC_REFRESH_TOKEN) { if (FORCE_LOGOUT_ON_MISSING_OIDC_REFRESH_TOKEN) {
log.info("Force redirecting to logout URI: {}", e.getMessage()); log.debug("Force redirecting to logout URI: {}", e.getMessage());
forceLogout(response); forceLogout(response);
} else { } else {
log.info(e.getMessage()); log.info(e.getMessage());
@ -407,20 +407,20 @@ public class OIDCUmaUtil {
return; return;
} catch (RefreshException e) { } catch (RefreshException e) {
if (FORCE_LOGOUT_ON_OIDC_REFRESH_ERROR) { if (FORCE_LOGOUT_ON_OIDC_REFRESH_ERROR) {
log.error("Error refreshing OIDC token, force redirect for {} to logout URI: {}", user.getScreenName(), log.debug("Cannot refresh OIDC token, force redirect for {} to logout URI: {}", user.getScreenName(),
e.getCause().getMessage()); e.getCause().getMessage());
forceLogout(response); forceLogout(response);
} else { } else {
log.error("Error refreshing OIDC token: {}", e.getCause().getMessage()); log.warn("Error refreshing OIDC token: {}", e.getCause().getMessage());
} }
return; return;
} catch (InvalidTokenException e) { } catch (InvalidTokenException e) {
if (FORCE_LOGOUT_ON_INVALID_TOKEN) { if (FORCE_LOGOUT_ON_INVALID_TOKEN) {
log.warn("OIDC token is become invalid, forcing redirect to logout URI"); log.debug("OIDC token is become invalid, forcing redirect to logout URI");
forceLogout(response); forceLogout(response);
} else { } else {
log.error("OIDC token is become invalid, cannot continue"); log.warn("OIDC token is become invalid, cannot continue");
} }
return; return;
} catch (NotAuthorizedException e) { } catch (NotAuthorizedException e) {