From 9b2ca36a5db768ed0707260d2b92e49d93751b74 Mon Sep 17 00:00:00 2001
From: Massimiliano Assante <massimiliano.assante@isti.cnr.it>
Date: Fri, 18 Jul 2014 14:57:40 +0000
Subject: [PATCH] Fixed bug that was allowing to like posts even if the user
 had the session expired.

git-svn-id: http://svn.research-infrastructures.eu/public/d4science/gcube/trunk/portlets/user/news-feed@98805 82a268e6-3cf1-43bd-a215-b396298e98cf
---
 distro/changelog.xml                                 |  4 ++++
 .../user/newsfeed/client/panels/NewsFeedPanel.java   | 12 ++++++++++--
 .../user/newsfeed/server/NewsServiceImpl.java        |  5 +++++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/distro/changelog.xml b/distro/changelog.xml
index 3d85ea4..f656a2a 100644
--- a/distro/changelog.xml
+++ b/distro/changelog.xml
@@ -1,4 +1,8 @@
 <ReleaseNotes>
+	<Changeset component="org.gcube.portlets.user.NewsFeed.1-7-1"
+		date="2014-06-04">
+		Fixed bug that was allowing to like posts even if the user had the session expired.
+		</Changeset>
 	<Changeset component="org.gcube.portlets.user.NewsFeed.1-7-0"
 		date="2014-06-04">
 		Fixed bug loosing session when messaging user from the news feed
diff --git a/src/main/java/org/gcube/portlets/user/newsfeed/client/panels/NewsFeedPanel.java b/src/main/java/org/gcube/portlets/user/newsfeed/client/panels/NewsFeedPanel.java
index 7058c13..29eb722 100644
--- a/src/main/java/org/gcube/portlets/user/newsfeed/client/panels/NewsFeedPanel.java
+++ b/src/main/java/org/gcube/portlets/user/newsfeed/client/panels/NewsFeedPanel.java
@@ -766,7 +766,11 @@ public class NewsFeedPanel extends Composite {
 			@Override
 			public void onFailure(Throwable caught) {}
 			@Override
-			public void onSuccess(Boolean result) {	}
+			public void onSuccess(Boolean result) {
+				if (!result) {
+					doShowSessionExpired();
+				}
+			}
 		});		
 	}
 	
@@ -775,7 +779,11 @@ public class NewsFeedPanel extends Composite {
 			@Override
 			public void onFailure(Throwable caught) {}
 			@Override
-			public void onSuccess(Boolean result) {	}
+			public void onSuccess(Boolean result) {	
+				if (!result) {
+					doShowSessionExpired();
+				}
+			}
 		});		
 		
 	}
diff --git a/src/main/java/org/gcube/portlets/user/newsfeed/server/NewsServiceImpl.java b/src/main/java/org/gcube/portlets/user/newsfeed/server/NewsServiceImpl.java
index 1c67be0..e5ab628 100644
--- a/src/main/java/org/gcube/portlets/user/newsfeed/server/NewsServiceImpl.java
+++ b/src/main/java/org/gcube/portlets/user/newsfeed/server/NewsServiceImpl.java
@@ -459,6 +459,11 @@ public class NewsServiceImpl extends RemoteServiceServlet implements NewsService
 	public boolean like(String feedid, String feedText, String feedOwnerId) {
 		boolean likeCommitResult = false;
 		UserInfo user = getUserSettings().getUserInfo();
+		
+		if (user.getUsername().compareTo(TEST_USER) == 0) {
+			return false;
+		}
+		
 		Like toLike = new Like(UUID.randomUUID().toString(), user.getUsername(), 
 				new Date(), feedid, user.getFullName(), user.getAvatarId());
 		try {