From 344273b08f29deb3551f8b67f788014cd1ae540b Mon Sep 17 00:00:00 2001 From: Massimiliano Assante Date: Mon, 13 Oct 2014 13:44:46 +0000 Subject: [PATCH] added invalid char check when searching for hashtags git-svn-id: http://svn.research-infrastructures.eu/public/d4science/gcube/trunk/portlets/user/news-feed@100643 82a268e6-3cf1-43bd-a215-b396298e98cf --- .settings/org.eclipse.wst.common.component | 3 +++ .../user/newsfeed/client/panels/NewsFeedPanel.java | 10 +++++++++- .../user/newsfeed/client/ui/TweetTemplate.java | 5 +---- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/.settings/org.eclipse.wst.common.component b/.settings/org.eclipse.wst.common.component index bf08e59..2e0d87a 100644 --- a/.settings/org.eclipse.wst.common.component +++ b/.settings/org.eclipse.wst.common.component @@ -4,6 +4,9 @@ + + uses + diff --git a/src/main/java/org/gcube/portlets/user/newsfeed/client/panels/NewsFeedPanel.java b/src/main/java/org/gcube/portlets/user/newsfeed/client/panels/NewsFeedPanel.java index 3185873..282c834 100644 --- a/src/main/java/org/gcube/portlets/user/newsfeed/client/panels/NewsFeedPanel.java +++ b/src/main/java/org/gcube/portlets/user/newsfeed/client/panels/NewsFeedPanel.java @@ -275,7 +275,15 @@ public class NewsFeedPanel extends Composite { filterPanel.removeFilterSelected(); } else if (getHashtagParam() != null) { - String hashtag = Encoder.decode(getHashtagParam()); + String hashtag = ""; + try { + Encoder.decode(getHashtagParam()); + } catch (Exception e) { + newsPanel.clear(); + newsPanel.add(new HTML("
" + + "We're sorry, it seems you used an invalid character, please check the hashtag
")); + return; + } GWT.log("Found hashtag " + hashtag); showFeedsByHashtag(hashtag); filterPanel.removeFilterSelected(); diff --git a/src/main/java/org/gcube/portlets/user/newsfeed/client/ui/TweetTemplate.java b/src/main/java/org/gcube/portlets/user/newsfeed/client/ui/TweetTemplate.java index 8c4baff..63f30ce 100644 --- a/src/main/java/org/gcube/portlets/user/newsfeed/client/ui/TweetTemplate.java +++ b/src/main/java/org/gcube/portlets/user/newsfeed/client/ui/TweetTemplate.java @@ -171,10 +171,7 @@ public class TweetTemplate extends Composite { if (showTimelineSource && feed.getVreid() != null && feed.getVreid().compareTo("") != 0) { String vreName = feed.getVreid().substring(feed.getVreid().lastIndexOf("/")+1); vreSource.setHTML("[" +vreName + "]"); - } else { - vreSource.setHTML("[multiple]"); - } - + } //check if the user has his own avatar if (feed.getThumbnailURL().endsWith("img_id=0") || !feed.getThumbnailURL().contains("?")) { //it means no avatar is set avatarImage.setVisible(false);