From 5c187c984240d4f9da116dc1d67a9500244317e3 Mon Sep 17 00:00:00 2001 From: Luca Frosini Date: Fri, 20 Sep 2019 14:46:54 +0200 Subject: [PATCH] Improved code in test --- .../gcube/gcat/persistence/ckan/CKANGroupTest.java | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/test/java/org/gcube/gcat/persistence/ckan/CKANGroupTest.java b/src/test/java/org/gcube/gcat/persistence/ckan/CKANGroupTest.java index 889ee64..2c2b3c3 100644 --- a/src/test/java/org/gcube/gcat/persistence/ckan/CKANGroupTest.java +++ b/src/test/java/org/gcube/gcat/persistence/ckan/CKANGroupTest.java @@ -1,7 +1,6 @@ package org.gcube.gcat.persistence.ckan; -import java.util.ArrayList; -import java.util.Iterator; +import java.util.Arrays; import java.util.List; import org.gcube.gcat.ContextTest; @@ -9,7 +8,6 @@ import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import com.fasterxml.jackson.databind.JsonNode; import com.fasterxml.jackson.databind.ObjectMapper; public class CKANGroupTest extends ContextTest { @@ -34,17 +32,11 @@ public class CKANGroupTest extends ContextTest { } public static List listGroup() throws Exception { - List groupList = new ArrayList<>(); CKANGroup group = new CKANGroup(); String groups = group.list(1000, 0); ObjectMapper objectMapper = new ObjectMapper(); - JsonNode jsonNodeGroups = objectMapper.readTree(groups); - Iterator iterator = jsonNodeGroups.elements(); - while(iterator.hasNext()) { - JsonNode jsonNode = iterator.next(); - groupList.add(jsonNode.asText()); - } - return groupList; + String[] groupArray = objectMapper.readValue(groups, String[].class); + return Arrays.asList(groupArray); } @Test