From c0e136094002535a7042ebcff791929f247d6d05 Mon Sep 17 00:00:00 2001
From: lucio lelii <lucio.lelii@isti.cnr.it>
Date: Wed, 20 Apr 2022 16:25:31 +0200
Subject: [PATCH] Added roles to ExternalServiceInfo constructor

---
 CHANGELOG.md                                         |  5 +++--
 .../library/provider/ExternalServiceInfo.java        | 12 +++++++++++-
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1e0ab45..06caad7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,9 +4,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [v2.5.0-SNAPSHOT]
+## [v2.5.0-SNAPSHOT] - [2022-04-20]
 
-Deprecated AccessTokenProvider, AuthorizationProvider and SecurityTokenProvider [#22871]
+- Deprecated AccessTokenProvider, AuthorizationProvider and SecurityTokenProvider [#22871]
+- Added roles to ExternalService Client info
 
 ## [v2.4.0] - [2021-05-21]
 
diff --git a/src/main/java/org/gcube/common/authorization/library/provider/ExternalServiceInfo.java b/src/main/java/org/gcube/common/authorization/library/provider/ExternalServiceInfo.java
index 47c1b44..1377cf0 100644
--- a/src/main/java/org/gcube/common/authorization/library/provider/ExternalServiceInfo.java
+++ b/src/main/java/org/gcube/common/authorization/library/provider/ExternalServiceInfo.java
@@ -22,10 +22,20 @@ public class ExternalServiceInfo extends ClientInfo{
 	
 	private String generatedBy;
 	
+	private List<String> roles;
+	
 	public ExternalServiceInfo(String id, String generatedBy) {
 		super();
 		this.id = id;
 		this.generatedBy = generatedBy;
+		this.roles = Collections.emptyList();
+	}
+	
+	public ExternalServiceInfo(String id, String generatedBy, List<String> roles) {
+		super();
+		this.id = id;
+		this.generatedBy = generatedBy;
+		this.roles = roles;
 	}
 	
 	protected ExternalServiceInfo() {
@@ -43,7 +53,7 @@ public class ExternalServiceInfo extends ClientInfo{
 
 	@Override
 	public List<String> getRoles() {
-		return Collections.emptyList();
+		return roles;
 	}
 
 	@Override