Compare commits

...

35 Commits

Author SHA1 Message Date
Francesco Mangiacrapa c807442378 removed -SNAPSHOT to be released 2023-12-21 09:06:36 +01:00
Francesco Mangiacrapa 114c753ca4 Including `publication_date` bug fixing [#26166] 2023-12-21 09:06:08 +01:00
Francesco Mangiacrapa 88975d12f4 override the publication_date before calling `uploadFiles` method 2023-12-06 12:18:54 +01:00
Francesco Mangiacrapa 74dcfe6e9c fixing issue #26166 2023-12-06 11:39:13 +01:00
Francesco Mangiacrapa 4eb65dc4ed Fixing `publication_date` issue [#26166] 2023-12-06 09:33:43 +01:00
Francesco Mangiacrapa 6dbc1d8e4c removed -SNAPSHOT to be released 2023-07-28 16:34:56 +02:00
Francesco Mangiacrapa d4ac169d8b Improved DOI data view after uploaded 2023-07-28 14:48:45 +02:00
Francesco Mangiacrapa 6007894177 Added DOI_dv 2023-07-28 14:41:30 +02:00
Francesco Mangiacrapa 7cb6dfb9ff removed setting licenses at null 2023-07-28 11:22:19 +02:00
Francesco Mangiacrapa bd9854a86e using List<String> for licenses 2023-07-28 11:16:23 +02:00
Francesco Mangiacrapa baf76a4e9e setting licenses at null 2023-07-28 10:55:03 +02:00
Francesco Mangiacrapa 62bbe2f751 updated 2023-07-27 16:13:15 +02:00
Francesco Mangiacrapa a5892227ca removed LicenseBean and passed to String #25275 2023-07-27 15:52:22 +02:00
Francesco Mangiacrapa b668e7c5b2 renamed license bean 2023-07-27 15:27:26 +02:00
Francesco Mangiacrapa cb29e33652 fixing #25275 2023-07-27 15:09:39 +02:00
Francesco Mangiacrapa 2d4488703a revisited the set/get licenses code 2023-07-27 14:39:38 +02:00
Francesco Mangiacrapa 04795542f8 zenodoItem setLicenses not null as LicenseBean Snew 2023-07-27 12:49:08 +02:00
Francesco Mangiacrapa 139775a525 zenodoItem setLicenses not null as LicenseBean S new 2023-07-27 12:42:07 +02:00
Francesco Mangiacrapa 1be6d17b84 zenodoItem setLicenses not null as LicenseBean new 2023-07-26 17:40:22 +02:00
Francesco Mangiacrapa a5da7f0f0d zenodoItem setLicenses not null as LicenseBean 2023-07-26 17:25:52 +02:00
Francesco Mangiacrapa 7cd0c9c5e8 implemented licenseToSerializableEnum 2023-07-26 17:00:39 +02:00
Francesco Mangiacrapa 99eedb50c7 zenodoItem setLicenses null 2023-07-26 16:23:27 +02:00
Francesco Mangiacrapa 8a292bde69 set contributors and image at null 2023-07-26 15:54:44 +02:00
Francesco Mangiacrapa a6b3032c78 zenodoItem setting other enums null 2023-07-26 15:35:29 +02:00
Francesco Mangiacrapa 8901e01990 test set access right at null 2023-07-26 15:29:31 +02:00
Francesco Mangiacrapa b24eda4dcc serialization enum at null 2023-07-26 15:06:27 +02:00
Francesco Mangiacrapa 61836c7cd5 zenodoItem setting metadata null 2023-07-26 12:45:29 +02:00
Francesco Mangiacrapa 74073ac6a3 added Serializable to ZenodoContributor 2023-07-26 12:36:11 +02:00
Francesco Mangiacrapa 1b660bcf3f added log 2023-07-25 17:36:54 +02:00
Francesco Mangiacrapa 5761e0cb9b updated 2023-07-25 17:27:08 +02:00
Francesco Mangiacrapa a0d5bd0825 moved to GWT 2.10.0 2023-07-25 15:40:27 +02:00
Francesco Mangiacrapa 6776c075ec added another explicit public constructor 2023-07-25 14:39:08 +02:00
Francesco Mangiacrapa cf0b11f4bc added some public constructors 2023-07-25 14:38:05 +02:00
Francesco Mangiacrapa 7bf08f9d5e updated message in the Changelog 2023-07-25 12:30:42 +02:00
Francesco Mangiacrapa 5048a3d4d7 Increased at 1.1.3-SNAPSHOT for recompiling this component 2023-07-25 12:27:45 +02:00
21 changed files with 711 additions and 502 deletions

View File

@ -4,6 +4,14 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [v1.1.4] - 2023-12-21
- Fixing `publication_date` issue [#26166]
## [v1.1.3] - 2023-07-25
- Fixing `null` issue, recompiling this component [#25275]
## [v1.1.2] - 2022-10-27
**Enhancements**

View File

@ -7,15 +7,14 @@
<parent>
<artifactId>maven-parent</artifactId>
<groupId>org.gcube.tools</groupId>
<version>1.1.0</version>
<version>1.2.0</version>
<relativePath />
</parent>
<groupId>org.gcube.portlets.widgets</groupId>
<artifactId>ckan2zenodo-publisher-widget</artifactId>
<packaging>jar</packaging>
<version>1.1.2</version>
<version>1.1.4</version>
<description>
gCube Ckan2Zenodo Publisher widget allows to publish D4Science catalogue's items on Zenodo
@ -31,7 +30,7 @@
<properties>
<!-- Convenience property to set the GWT version -->
<gwtVersion>2.9.0</gwtVersion>
<gwtVersion>2.10.0</gwtVersion>
<!-- GWT needs at least java 1.6 -->
<maven.compiler.source>1.8</maven.compiler.source>

View File

@ -12,6 +12,7 @@ import org.gcube.portlets.widgets.ckan2zenodopublisher.client.view.FormValidator
import org.gcube.portlets.widgets.ckan2zenodopublisher.client.view.LoaderIcon;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.CatalogueItem;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.ZenodoError;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.DOI_dv;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoItem;
import com.github.gwtbootstrap.client.ui.Alert;
@ -30,6 +31,8 @@ import com.google.gwt.json.client.JSONParser;
import com.google.gwt.json.client.JSONValue;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.HTML;
import com.google.gwt.user.client.ui.VerticalPanel;
import com.google.gwt.user.client.ui.Widget;
@ -97,6 +100,7 @@ public class CkanToZendoPublisherWidget {
@Override
public void onSuccess(ZenodoItem result) {
GWT.log("Zenodo item returned is: "+result);
loader.setVisible(false);
modal.remove(loader);
manager = new Ckan2ZenodoViewManager();
@ -163,7 +167,7 @@ public class CkanToZendoPublisherWidget {
//Submit publish on zenodo.
ZenodoItem zenodoItem = manager.getZenodoItemFromFieldsForm();
GWT.log("Publishing file: "+zenodoItem.getFiles());
ckanToZenodoService.publishOnZenodo(zenodoItem, new AsyncCallback<String>() {
ckanToZenodoService.publishOnZenodo(zenodoItem, new AsyncCallback<DOI_dv>() {
@Override
public void onFailure(Throwable caught) {
@ -179,7 +183,7 @@ public class CkanToZendoPublisherWidget {
}
@Override
public void onSuccess(String doi) {
public void onSuccess(DOI_dv doi_dv) {
buttonPublish.setEnabled(false);
basicTabPanel.getElement().getStyle().setOpacity(1.0);
try {
@ -188,16 +192,28 @@ public class CkanToZendoPublisherWidget {
// TODO: handle exception
}
String msg = "The item has been uploaded to Zenodo correctly";
if(doi!=null)
msg+=" "+doi;
Alert infoLabel = new Alert();
infoLabel.setClose(false);
infoLabel.setType(AlertType.INFO);
infoLabel.setText(msg);
showResults(Arrays.asList(infoLabel.asWidget()));
Modal modal = new Modal(true, true);
modal.setCloseVisible(true);
modal.setTitle("Item uploaded to Zenodo!");
modal.add(infoLabel);
if(doi_dv!=null) {
FlowPanel dF = new FlowPanel();
dF.add(new HTML("DOI: "+doi_dv.getDoi()));
FlowPanel dFU = new FlowPanel();
dFU.add(new HTML("DOI URL: <a href='"+doi_dv.getDoi_url()+"' target='_blank'>"+doi_dv.getDoi_url()+"</a>"));
modal.add(dF);
modal.add(dFU);
}
modal.show();
//showResults(Arrays.asList(infoLabel.asWidget()));
}
});

View File

@ -3,6 +3,7 @@ package org.gcube.portlets.widgets.ckan2zenodopublisher.client;
import java.util.Map;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.CatalogueItem;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.DOI_dv;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoItem;
import com.google.gwt.user.client.rpc.RemoteService;
@ -34,7 +35,7 @@ public interface CkanToZenodoPublisherService extends RemoteService {
* @return the DOI of published Zenodo Item
* @throws Exception the exception
*/
String publishOnZenodo(ZenodoItem zenodoItem) throws Exception;
DOI_dv publishOnZenodo(ZenodoItem zenodoItem) throws Exception;
/**
* Read fields descriptions.

View File

@ -3,6 +3,7 @@ package org.gcube.portlets.widgets.ckan2zenodopublisher.client;
import java.util.Map;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.CatalogueItem;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.DOI_dv;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoItem;
import com.google.gwt.core.client.GWT;
@ -33,7 +34,7 @@ public interface CkanToZenodoPublisherServiceAsync {
void convertToZenodoItem(CatalogueItem item, AsyncCallback<ZenodoItem> callback);
void publishOnZenodo(ZenodoItem zenodoItem, AsyncCallback<String> callback);
void publishOnZenodo(ZenodoItem zenodoItem, AsyncCallback<DOI_dv> callback);
void readFieldsDescriptions(AsyncCallback<Map<String, String>> callback);

View File

@ -258,6 +258,8 @@ public class BasicInformationView extends Composite implements FormValidator {
field_description.setValue(zenodoItem.getMetadata().getDescription());
InfoTextAndLabels.addTooltipForFieldKey("description", cl_description);
field_doi.setValue(zenodoItem.getDoi());
GWT.log("Filling form with: "+zenodoItem.getMetadata());
ZenodoMetadata zMeta = zenodoItem.getMetadata();
if (zMeta != null) {
@ -327,20 +329,19 @@ public class BasicInformationView extends Composite implements FormValidator {
InfoTextAndLabels.addTooltipForFieldKey("access_conditions", cl_access_conditions);
// License
if (zMeta.getLicenses() != null) {
List<String> listLicensesIds = null;
List<String> selectedLicensesId = FieldUtil.toZenodoIds(zMeta.getLicenses().getSelectedValues());
if(zMeta.getLicenses().getSelectableValues()!=null) {
listLicensesIds = FieldUtil.toZenodoIds(zMeta.getLicenses().getSelectableValues());
FieldUtil.addValuesToListBox(field_license, listLicensesIds);
if (zMeta.getLicenseIDs() != null) {
//List<String> listLicensesIds = null;
List<String> selectedLicensesId = FieldUtil.toZenodoIds(zMeta.getLicenseIDs());
if(selectedLicensesId!=null) {
FieldUtil.addValuesToListBox(field_license, selectedLicensesId);
field_license.setEnabled(true);
}else {
//Exception case on missing list of selectable license ids
FieldUtil.addValuesToListBox(field_license, selectedLicensesId);
//FieldUtil.addValuesToListBox(field_license, selectedLicensesId);
field_license.setEnabled(false); //only one license id is available
}
FieldUtil.selectValueToListBox(field_license, selectedLicensesId);
//FieldUtil.selectValueToListBox(field_license, selectedLicensesId);
}else
field_license.setEnabled(false);

View File

@ -8,7 +8,6 @@ import java.util.List;
import org.gcube.portlets.widgets.ckan2zenodopublisher.client.ui.BasicTabPanel;
import org.gcube.portlets.widgets.ckan2zenodopublisher.client.ui.basicinformation.BasicInformationView;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.SerializableEnum;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.LicenseBean;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoContributor;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoCreator;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoFile;
@ -124,6 +123,9 @@ public class Ckan2ZenodoViewManager {
meta.setDescription(basicForm.getField_description().getValue());
meta.setKeywords(basicForm.getTags()); // these are the keywords
//Setting publication date fxing #26166
meta.setPublication_date(basicForm.getField_publication_date().getValue());
List<ZenodoCreator> creators = basicForm.getListOfCreators();
GWT.log("Read creators from FORM: "+creators);
meta.setCreators(creators);
@ -162,8 +164,11 @@ public class Ckan2ZenodoViewManager {
//license
String licenseId = basicForm.getField_license().getSelectedValue();
if(licenseId!=null) {
LicenseBean licenseBean = new LicenseBean(licenseId, null, null);
meta.setLicenses(new SerializableEnum<LicenseBean>(Arrays.asList(licenseBean),null));
//LicenseDTO licenseBean = new LicenseDTO(licenseId, null, null);
List<String> licenses = new ArrayList<String>();
licenses.add(licenseId);
meta.setLicenseIDs(licenses);
//meta.setLicenses(Arrays.asList(licenseBean));
}
//embargo date

View File

@ -3,9 +3,6 @@ package org.gcube.portlets.widgets.ckan2zenodopublisher.client.view;
import java.util.ArrayList;
import java.util.List;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.ZenodoLicense;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.LicenseBean;
import com.github.gwtbootstrap.client.ui.ControlGroup;
import com.github.gwtbootstrap.client.ui.ListBox;
import com.github.gwtbootstrap.client.ui.TextBox;
@ -98,17 +95,18 @@ public class FieldUtil {
/**
* To zenodo ids.
* TODO Must passed an object License
*
* @param listLicenses the list licenses
* @return the list
*/
public static List<String> toZenodoIds(List<LicenseBean> listLicenses){
public static List<String> toZenodoIds(List<String> listLicenses){
if(listLicenses==null)
return null;
List<String> licenses = new ArrayList<String>(listLicenses.size());
for (ZenodoLicense zenodoLicense : listLicenses) {
licenses.add(zenodoLicense.getId());
for (String zenodoLicense : listLicenses) {
licenses.add(zenodoLicense);
}
return licenses;

View File

@ -1,5 +1,6 @@
package org.gcube.portlets.widgets.ckan2zenodopublisher.server;
import java.util.Date;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
@ -25,6 +26,7 @@ import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.CatalogueItem;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.ItemTranslateError;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.ItemTranslateError.ERROR_TYPE;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.ZenodoError;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.DOI_dv;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoFile;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoItem;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoMetadata;
@ -39,27 +41,32 @@ import com.liferay.portal.service.UserLocalServiceUtil;
*
* @author Francesco Mangiacrapa at ISTI-CNR (francesco.mangiacrapa@isti.cnr.it)
*
* Jan 15, 2020
* Jan 15, 2020
*/
@SuppressWarnings("serial")
public class CkanToZenodoPublisherServiceImpl extends RemoteServiceServlet implements CkanToZenodoPublisherService {
private static Logger LOG = LoggerFactory.getLogger(CkanToZenodoPublisherServiceImpl.class);
/* (non-Javadoc)
* @see org.gcube.portlets.widgets.ckan2zenodopublisher.client.CkanToZenodoPublisherService#publishOnZenodo(org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoItem)
/*
* (non-Javadoc)
*
* @see org.gcube.portlets.widgets.ckan2zenodopublisher.client.
* CkanToZenodoPublisherService#publishOnZenodo(org.gcube.portlets.widgets.
* ckan2zenodopublisher.shared.wrapped.ZenodoItem)
*/
@Override
public String publishOnZenodo(ZenodoItem zenodoItem) throws Exception {
public DOI_dv publishOnZenodo(ZenodoItem zenodoItem) throws Exception {
LOG.info("publishOnZenodo called");
try {
if(isOutFromPortal()) {
if (isOutFromPortal()) {
PortalUtils.getCurrentContext(this.getThreadLocalRequest(), true);
PortalUtils.getCurrentToken(this.getThreadLocalRequest(), true);
}
LOG.debug("publishOnZenodo called with metadata: "+zenodoItem.getMetadata());
Ckan2Zenodo client = new Ckan2ZenodoImpl();
// Get the item representation
CkanItemDescriptor itemDescr = client.read(zenodoItem.getName());
@ -71,97 +78,119 @@ public class CkanToZenodoPublisherServiceImpl extends RemoteServiceServlet imple
LOG.info("Using forceTranslation for: " + itemDescr.getItemUrl());
zenodoDepositionPreview = client.forceTranslation(itemDescr);
}
//(EVENTUALLY) UPDATING BASIC INFO CHANGED BY FORM ON CLIENT-SIDE
//Basic info
// (EVENTUALLY) UPDATING BASIC INFO CHANGED BY FORM ON CLIENT-SIDE
// Basic info
zenodoDepositionPreview.setTitle(zenodoItem.getTitle());
//Updating Deposition Metadata potentially changed on client-side
// Updating Deposition Metadata potentially changed on client-side
ZenodoMetadata metadata = zenodoItem.getMetadata();
DepositionMetadata depositionMetadata = zenodoDepositionPreview.getMetadata();
depositionMetadata = ItemToZenodoConverter.updateMetadataInfoOfDepositionMetadata(metadata, depositionMetadata);
depositionMetadata = ItemToZenodoConverter.updateMetadataInfoOfDepositionMetadata(metadata,
depositionMetadata);
zenodoDepositionPreview.setMetadata(depositionMetadata);
//Loading Filtered resources according to VRE policies
// Loading Filtered resources according to VRE policies
List<CkanResource> filteredResources = loadFilterResources(zenodoItem.getName());
HashSet<CkanResource> toUpload = new HashSet<CkanResource>();
//Adding for publishing only the resources selected on clien-side
if(zenodoItem.getFiles()!=null) {
// Adding for publishing only the resources selected on clien-side
if (zenodoItem.getFiles() != null) {
for (ZenodoFile zf : zenodoItem.getFiles()) {
for (CkanResource ckanResource : filteredResources) {
if(zf.getId().compareTo(ckanResource.getId())==0 && zf.getIsAlreadyPublished()==false) {
if(CkanToZenodoUtil.isNotEmpty(zf.getFilename())) {
ckanResource.setName(zf.getFilename()); //only the filename can be changed on clien-side
if (zf.getId().compareTo(ckanResource.getId()) == 0 && zf.getIsAlreadyPublished() == false) {
if (CkanToZenodoUtil.isNotEmpty(zf.getFilename())) {
ckanResource.setName(zf.getFilename()); // only the filename can be changed on
// clien-side
toUpload.add(ckanResource);
}
}
}
}
}
//Actually publish to zenodo :
// Actually publish to zenodo :
// Step 1 : metadata
client= new Ckan2ZenodoImpl();
LOG.debug("Calling updatedMetadata for: "+zenodoDepositionPreview);
client = new Ckan2ZenodoImpl();
LOG.debug("Calling updatedMetadata for: " + zenodoDepositionPreview);
//fixing issue #26166
Date thePublicationDate = zenodoDepositionPreview.getMetadata().getPublication_date();
LOG.debug("Publication_Date before update is: " + thePublicationDate);
zenodoDepositionPreview = client.updatedMetadata(zenodoDepositionPreview);
//Step 2 : publish Resources
if(toUpload.size()>0) {
LOG.debug("Trying to publish the set of CKAN resources: "+toUpload.toString());
Future<ZenodoDeposition> future_Dep=client.uploadFiles(toUpload, zenodoDepositionPreview);
while(!future_Dep.isDone()) {
LOG.debug("Waiting for completed future computation (publishing of resources on Zenodo)...");
Thread.sleep(2000);
// Step 2 : publish Resources
if (toUpload.size() > 0) {
LOG.debug("Trying to publish the set of CKAN resources: " + toUpload.toString());
//fixing issue #26166
zenodoDepositionPreview.getMetadata().setPublication_date(thePublicationDate);
LOG.debug("Publication_Date before uploadFiles is: " + zenodoDepositionPreview.getMetadata().getPublication_date());
Future<ZenodoDeposition> future_Dep = client.uploadFiles(toUpload, zenodoDepositionPreview);
while (!future_Dep.isDone()) {
LOG.debug("Waiting for completed future computation (publishing of resources on Zenodo)...");
Thread.sleep(2000);
}
zenodoDepositionPreview = future_Dep.get(600,TimeUnit.SECONDS);
zenodoDepositionPreview = future_Dep.get(600, TimeUnit.SECONDS);
}
// Get the item representation
CkanItemDescriptor item=client.read(zenodoItem.getName());
//Finalize
LOG.debug("Calling publish on Zenodo for: "+zenodoDepositionPreview);
CkanItemDescriptor item = client.read(zenodoItem.getName());
//fixing issue #26166
LOG.debug("Publication_Date before publish is: " + thePublicationDate);
zenodoDepositionPreview.getMetadata().setPublication_date(thePublicationDate);
// Finalize
LOG.debug("Calling publish on Zenodo for: " + zenodoDepositionPreview);
zenodoDepositionPreview = client.publish(zenodoDepositionPreview, item);
return zenodoDepositionPreview.getDoi();
//throw new ZenodoException();
}catch (TimeoutException e) {
return new DOI_dv(zenodoDepositionPreview.getDoi(), zenodoDepositionPreview.getDoi_url());
// throw new ZenodoException();
} catch (TimeoutException e) {
String error = "I'm waiting too time to upload the files to Zenodo. Check by yourself the result later";
LOG.error(error, e);
String clientError = String.format("%s", error);
throw new Exception(clientError);
} catch (ZenodoException e) {
String error = ZenodoException.class.getName()+" during upload to Zenodo the catalogue item: "+zenodoItem.getName();
String error = ZenodoException.class.getName() + " during upload to Zenodo the catalogue item: "
+ zenodoItem.getName();
LOG.error(error, e);
//String clientError = String.format("%s", e.getRemoteMessage());
// String clientError = String.format("%s", e.getRemoteMessage());
ZenodoError zenodoError = new ZenodoError(e);
zenodoError.setRemoteMessage(e.getRemoteMessage());
zenodoError.setResponseHTTPCode(e.getResponseHTTPCode());
throw zenodoError;
} catch (Exception e) {
String error = "Error during upload to Zenodo the catalogue item: "+zenodoItem.getName();
String error = "Error during upload to Zenodo the catalogue item: " + zenodoItem.getName();
LOG.error(error, e);
String clientError = String.format("%s. %s", error, e.getMessage());
throw new Exception(clientError);
}
}
/* (non-Javadoc)
* @see org.gcube.portlets.widgets.ckan2zenodopublisher.client.CkanToZenodoPublisherService#convertToZenodoItem(org.gcube.portlets.widgets.ckan2zenodopublisher.shared.CatalogueItem)
/*
* (non-Javadoc)
*
* @see org.gcube.portlets.widgets.ckan2zenodopublisher.client.
* CkanToZenodoPublisherService#convertToZenodoItem(org.gcube.portlets.widgets.
* ckan2zenodopublisher.shared.CatalogueItem)
*/
@Override
public ZenodoItem convertToZenodoItem(CatalogueItem item) throws Exception {
LOG.info("convertToZenodoItem called");
try {
if(isOutFromPortal()) {
if (isOutFromPortal()) {
PortalUtils.getCurrentContext(this.getThreadLocalRequest(), true);
PortalUtils.getCurrentToken(this.getThreadLocalRequest(), true);
}
Ckan2Zenodo client = new Ckan2ZenodoImpl();
// Get the item representation
CkanItemDescriptor itemDescr = client.read(item.getItemId());
@ -170,69 +199,77 @@ public class CkanToZenodoPublisherServiceImpl extends RemoteServiceServlet imple
ItemTranslateError itemTrError = null;
try {
zdDeposition = client.translate(itemDescr);
} catch (ConfigurationException e) {
} catch (ConfigurationException | TransformationException e) {
LOG.info(ConfigurationException.class.getSimpleName() + " thrown, trying to use forceTranslation for: "
+ itemDescr.getName());
itemTrError = new ItemTranslateError(e.getMessage(), ERROR_TYPE.INFO);
zdDeposition = client.forceTranslation(itemDescr);
}
//Loading Filtered resources according to VRE policies
List<CkanResource> filteredResources = loadFilterResources(item.getItemId());
LOG.debug("Loaded filtered resources: "+filteredResources);
LOG.debug("Loaded filtered resources: " + filteredResources);
//Converting ZenodoDeposition to ZenodoItem
// Converting ZenodoDeposition to ZenodoItem
ZenodoItem zenodoItem = ItemToZenodoConverter.toZenodoItem(zdDeposition);
//Adding ItemTranslateError eventually occurred by calling client.translate
// Adding ItemTranslateError eventually occurred by calling client.translate
zenodoItem.setTranslateError(itemTrError);
//Adding the filtered resources
// Adding the filtered resources
List<ZenodoFile> resources = ItemToZenodoConverter.toZenodoFiles(filteredResources, false);
zenodoItem.addFiles(resources);
//I'M SETTING THE ID BECAUSE THE NAME IS NULL INTO BEAN PASSED FROM PORTLET SIDE
//TODO I'M WAITING FOR itemName retrieved from ckan2zenodo library
// I'M SETTING THE ID BECAUSE THE NAME IS NULL INTO BEAN PASSED FROM PORTLET
// SIDE
// TODO I'M WAITING FOR itemName retrieved from ckan2zenodo library
zenodoItem.setName(item.getItemId());
LOG.debug("zenodoItem getLicenses as list: " + zenodoItem.getMetadata().getLicenseIDs());
//LOG.debug("setting licenses at null");
//zenodoItem.getMetadata().setLicenseIDs(null);
LOG.debug("Returning item: "+zenodoItem);
LOG.debug("Returning item: " + zenodoItem);
return zenodoItem;
} catch (ZenodoException e) {
String error = ZenodoException.class.getName()+" on converting the catalogue item with id: "+item.getItemId();
String error = ZenodoException.class.getName() + " on converting the catalogue item with id: "
+ item.getItemId();
LOG.error(error, e);
//String clientError = String.format("%s. %s", error, e.getRemoteMessage());
// String clientError = String.format("%s. %s", error, e.getRemoteMessage());
ZenodoError zenodoError = new ZenodoError(e);
zenodoError.setRemoteMessage(e.getRemoteMessage());
zenodoError.setResponseHTTPCode(e.getResponseHTTPCode());
throw zenodoError;
} catch (Exception e) {
String error = "Error on converting the catalogue item with id: "+item.getItemId();
String error = "Error on converting the catalogue item with id: " + item.getItemId();
LOG.error(error, e);
String clientError = String.format("%s. %s", error, e.getMessage());
throw new Exception(clientError);
}
}
/* (non-Javadoc)
* @see org.gcube.portlets.widgets.ckan2zenodopublisher.client.CkanToZenodoPublisherService#convertToZenodoItem(org.gcube.portlets.widgets.ckan2zenodopublisher.shared.CatalogueItem)
/*
* (non-Javadoc)
*
* @see org.gcube.portlets.widgets.ckan2zenodopublisher.client.
* CkanToZenodoPublisherService#convertToZenodoItem(org.gcube.portlets.widgets.
* ckan2zenodopublisher.shared.CatalogueItem)
*/
@Override
public Map<String, String> readFieldsDescriptions() throws Exception {
LOG.info("readFieldsDescriptions called");
try {
if(isOutFromPortal()) {
if (isOutFromPortal()) {
PortalUtils.getCurrentContext(this.getThreadLocalRequest(), true);
PortalUtils.getCurrentToken(this.getThreadLocalRequest(), true);
}
return ZenodoFieldsDescriptionsReader.readProperties();
} catch (Exception e) {
String error = "Unable to read the file of properties with the fields desciptions";
LOG.error(error, e);
@ -241,23 +278,23 @@ public class CkanToZenodoPublisherServiceImpl extends RemoteServiceServlet imple
}
}
@Override
public Boolean checkZenodoEnvironment() {
LOG.info("checkZenodoEnvironment called");
boolean isZenodoConfigured = false;
try {
if(isOutFromPortal()) {
if (isOutFromPortal()) {
PortalUtils.getCurrentContext(this.getThreadLocalRequest(), true);
PortalUtils.getCurrentToken(this.getThreadLocalRequest(), true);
}
LOG.info("readFieldsDescriptions called");
Ckan2Zenodo client = new Ckan2ZenodoImpl();
EnvironmentReport report = client.checkEnvironment();
LOG.info("EnvironmentReport returned: "+report);
LOG.info("EnvironmentReport returned: " + report);
isZenodoConfigured = report.isok();
} catch (Exception e) {
LOG.error("Error occurred during checkEnvironment: ", e);
@ -272,19 +309,20 @@ public class CkanToZenodoPublisherServiceImpl extends RemoteServiceServlet imple
*
* @param itemName the item name
* @return the list
* @throws GcatException the gcat exception
* @throws ConfigurationException the configuration exception
* @throws GcatException the gcat exception
* @throws ConfigurationException the configuration exception
* @throws TransformationException the transformation exception
*/
private List<CkanResource> loadFilterResources(String itemName) throws GcatException, ConfigurationException, TransformationException {
private List<CkanResource> loadFilterResources(String itemName)
throws GcatException, ConfigurationException, TransformationException {
Ckan2Zenodo client = new Ckan2ZenodoImpl();
// Get the item representation
CkanItemDescriptor itemDescr=client.read(itemName);
//Filter resources according to VRE policies
CkanItemDescriptor itemDescr = client.read(itemName);
// Filter resources according to VRE policies
return client.filterResources(itemDescr);
}
/**
* Online or in development mode?.
*
@ -294,11 +332,10 @@ public class CkanToZenodoPublisherServiceImpl extends RemoteServiceServlet imple
try {
UserLocalServiceUtil.getService();
return false;
}
catch (com.liferay.portal.kernel.bean.BeanLocatorException ex) {
} catch (com.liferay.portal.kernel.bean.BeanLocatorException ex) {
LOG.debug("Development Mode ON");
return true;
}
}
}

View File

@ -4,7 +4,6 @@ import java.util.ArrayList;
import java.util.List;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.SerializableEnum;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.ZenodoLicense;
/**
@ -48,20 +47,6 @@ public class CkanToZenodoUtil {
return new SerializableEnum<String>(selectedValues, values);
}
/**
* To serializable enum.
*
* @param <E> the element type
* @param selectedLicense the selected license
* @param allLicenses the all licenses
* @return the serializable enum
*/
public static <E extends ZenodoLicense> SerializableEnum<E> toSerializableEnum(List<E> selectedLicense, List<E> allLicenses) {
return new SerializableEnum<E>(selectedLicense, allLicenses);
}
/**
* Checks if is not empty.
*

View File

@ -1,7 +1,6 @@
package org.gcube.portlets.widgets.ckan2zenodopublisher.server.converter;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Date;
import java.util.List;
@ -23,7 +22,6 @@ import org.gcube.data.publishing.ckan2zenodo.model.zenodo.Subject;
import org.gcube.data.publishing.ckan2zenodo.model.zenodo.ZenodoDeposition;
import org.gcube.portlets.widgets.ckan2zenodopublisher.server.CkanToZenodoUtil;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.SerializableEnum;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.LicenseBean;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoAuthor;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoCommunity;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoContributor;
@ -37,18 +35,17 @@ import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped.ZenodoSubj
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* The Class ItemToZenodoConverter.
*
* @author Francesco Mangiacrapa at ISTI-CNR (francesco.mangiacrapa@isti.cnr.it)
*
* Dec 10, 2019
* Dec 10, 2019
*/
public class ItemToZenodoConverter {
private static Logger LOG = LoggerFactory.getLogger(ItemToZenodoConverter.class);
/**
* **
*
@ -58,8 +55,7 @@ public class ItemToZenodoConverter {
* @param zenodoDeposition the zenodo deposition
* @return the zenodo item
*/
/**
* To zenodo item.
*
@ -67,112 +63,108 @@ public class ItemToZenodoConverter {
* @return the zenodo item
*/
public static ZenodoItem toZenodoItem(ZenodoDeposition zenodoDeposition) {
if(zenodoDeposition==null)
if (zenodoDeposition == null)
return null;
LOG.debug("Converting item: "+zenodoDeposition);
LOG.debug("Converting item: " + zenodoDeposition);
ZenodoItem zi = new ZenodoItem();
zi.setId(zenodoDeposition.getId());
zi.setDoi(zenodoDeposition.getDoi());
zi.setCreated(zenodoDeposition.getCreated());
//Add files already published in the deposition
List<ZenodoFile> files = toZenodoFiles(zenodoDeposition.getFiles(),true);
// Add files already published in the deposition
List<ZenodoFile> files = toZenodoFiles(zenodoDeposition.getFiles(), true);
zi.addFiles(files);
zi.setModified(zenodoDeposition.getModified());
zi.setOwner(zenodoDeposition.getOwner());
zi.setRecord_id(zenodoDeposition.getRecord_id());
zi.setRecord_url(zenodoDeposition.getRecord_url()!=null?zenodoDeposition.getRecord_url().toString():null);
zi.setRecord_url(zenodoDeposition.getRecord_url() != null ? zenodoDeposition.getRecord_url().toString() : null);
zi.setState(zenodoDeposition.getState());
zi.setSubmitted(zenodoDeposition.getSubmitted());
zi.setTitle(zenodoDeposition.getTitle());
zi.setMetadata(toZenodoMetadata(zenodoDeposition.getMetadata()));
LOG.debug("Converted item: "+zi);
LOG.debug("Converted item: " + zi);
return zi;
}
/**
* Adds the files.
*
* @param files the files
* @param files the files
* @param filesAlreadyPublished the files already published
* @return the list
*/
private static List<ZenodoFile> toZenodoFiles(ArrayList<FileDeposition> files, boolean filesAlreadyPublished) {
if(files==null)
if (files == null)
return null;
List<ZenodoFile> listOfFiles = new ArrayList<ZenodoFile>(files.size());
for (FileDeposition fileDeposition : files) {
listOfFiles.add(toZenodoFile(fileDeposition, filesAlreadyPublished));
}
return listOfFiles;
}
/**
* To zenodo files.
*
* @param filteredResources the filtered resources
* @param filteredResources the filtered resources
* @param filesAlreadyPublished the files already published
* @return the list
*/
public static List<ZenodoFile> toZenodoFiles(List<CkanResource> filteredResources, boolean filesAlreadyPublished) {
if(filteredResources==null)
if (filteredResources == null)
return null;
List<ZenodoFile> listOfFiles = new ArrayList<ZenodoFile>(filteredResources.size());
for (CkanResource ckanResource : filteredResources) {
listOfFiles.add(toZenodoFile(ckanResource,filesAlreadyPublished));
listOfFiles.add(toZenodoFile(ckanResource, filesAlreadyPublished));
}
return listOfFiles;
}
/**
* To zenodo file.
*
* @param fileDeposition the file deposition
* @param fileDeposition the file deposition
* @param fileAlreadyPublished the file already published
* @return the zenodo file
*/
public static ZenodoFile toZenodoFile(FileDeposition fileDeposition, boolean fileAlreadyPublished) {
if(fileDeposition==null)
if (fileDeposition == null)
return null;
ZenodoFile zf = new ZenodoFile();
zf.setId(fileDeposition.getId());
zf.setFilename(fileDeposition.getFilename());
zf.setFilesize(fileDeposition.getFilesize()+"");
zf.setFilesize(fileDeposition.getFilesize() + "");
zf.setChecksum(fileDeposition.getChecksum());
zf.setIsAlreadyPublished(fileAlreadyPublished);
return zf;
}
/**
* To zenodo file.
*
* @param ckanResource the ckan resource
* @param ckanResource the ckan resource
* @param fileAlreadyPublished the file already published
* @return the zenodo file
*/
public static ZenodoFile toZenodoFile(CkanResource ckanResource, boolean fileAlreadyPublished) {
if(ckanResource==null)
if (ckanResource == null)
return null;
ZenodoFile zf = new ZenodoFile();
zf.setId(ckanResource.getId());
zf.setFilename(ckanResource.getName());
@ -184,67 +176,72 @@ public class ItemToZenodoConverter {
zf.setIsAlreadyPublished(fileAlreadyPublished);
return zf;
}
/**
* To zenodo metadata.
*
* @param depositionMetadata the deposition metadata
* @return the zenodo metadata
*/
public static ZenodoMetadata toZenodoMetadata(DepositionMetadata depositionMetadata){
if(depositionMetadata==null)
public static ZenodoMetadata toZenodoMetadata(DepositionMetadata depositionMetadata) {
if (depositionMetadata == null)
return null;
ZenodoMetadata zm = new ZenodoMetadata();
zm.setAccess_conditions(depositionMetadata.getAccess_conditions());
zm.setDescription(depositionMetadata.getDescription());
//Access Type
// fixing bug #26165 on publication_date = null
zm.setPublication_date(depositionMetadata.getPublication_date());
// Access Type
AccessRights[] accessRight = null;
if(depositionMetadata.getAccess_right()!=null) {
if (depositionMetadata.getAccess_right() != null) {
AccessRights[] theAccessRight = { depositionMetadata.getAccess_right() };
accessRight = theAccessRight;
}
zm.setAccess_right(CkanToZenodoUtil.toSerializableEnum(accessRight, AccessRights.values()));
//Upload Type
// Upload Type
UploadType[] uploadType = null;
if(depositionMetadata.getUpload_type()!=null) {
if (depositionMetadata.getUpload_type() != null) {
UploadType[] theUploadType = { depositionMetadata.getUpload_type() };
uploadType = theUploadType;
}
zm.setUpload_type(CkanToZenodoUtil.toSerializableEnum(uploadType, UploadType.values()));
//Publication Type
// Publication Type
PublicationType[] publicationType = null;
if(depositionMetadata.getPublication_type()!=null) {
if (depositionMetadata.getPublication_type() != null) {
PublicationType[] thepublicationType = { depositionMetadata.getPublication_type() };
publicationType = thepublicationType;
}
zm.setPublication_type(CkanToZenodoUtil.toSerializableEnum(publicationType, PublicationType.values()));
//Image Type
// Image Type
ImageType[] imageType = null;
if(depositionMetadata.getImage_type()!=null) {
if (depositionMetadata.getImage_type() != null) {
ImageType[] theImageType = { depositionMetadata.getImage_type() };
imageType = theImageType;
}
zm.setImage_type(CkanToZenodoUtil.toSerializableEnum(imageType, ImageType.values()));
//Licenses
List<LicenseBean> selectedLicenses = null;
if(depositionMetadata.getLicense()!=null) {
selectedLicenses = Arrays.asList(new LicenseBean(depositionMetadata.getLicense(),depositionMetadata.getLicense(), null));
// Licenses
List<String> selectedLicenses = null;
if (depositionMetadata.getLicense() != null) {
selectedLicenses = new ArrayList<String>();
selectedLicenses.add(depositionMetadata.getLicense()); // NEED TO ADD ALL LICENSES
}
zm.setLicenses(CkanToZenodoUtil.toSerializableEnum(selectedLicenses, null)); //NEED TO ADD ALL LICENSES
if(depositionMetadata.getEmbargo_date()!=null) {
if (selectedLicenses != null) {
zm.setLicenseIDs(selectedLicenses);
}
if (depositionMetadata.getEmbargo_date() != null) {
}
zm.setKeywords(depositionMetadata.getKeywords());
zm.setCommunities(toZenodoCommunities(depositionMetadata.getCommunities()));
zm.setConference_acronym(depositionMetadata.getConference_acronym());
@ -254,12 +251,12 @@ public class ItemToZenodoConverter {
zm.setConference_session_part(depositionMetadata.getConference_session_part());
zm.setConference_title(depositionMetadata.getConference_title());
zm.setConference_url(depositionMetadata.getConference_url());
zm.setContributors(toZenodoContributors(depositionMetadata.getContributors()));
//to manage empty or null contributors from mapping
// to manage empty or null contributors from mapping
zm.setContributorsTypes(CkanToZenodoUtil.toSerializableEnum(null, Contributor.Type.values()));
zm.setCreators(toZenodoCreators(depositionMetadata.getCreators()));
zm.setDates(toZenodoDateIntervals(depositionMetadata.getDates()));
zm.setEmbargo_date(depositionMetadata.getEmbargo_date());
@ -270,11 +267,10 @@ public class ItemToZenodoConverter {
zm.setTitle(depositionMetadata.getTitle());
zm.setVersion(depositionMetadata.getVersion());
zm.setNotes(depositionMetadata.getNotes());
return zm;
}
/**
* To zenodo subjects.
*
@ -282,15 +278,15 @@ public class ItemToZenodoConverter {
* @return the list
*/
private static List<ZenodoSubject> toZenodoSubjects(List<Subject> subjects) {
if(subjects==null)
if (subjects == null)
return null;
List<ZenodoSubject> list = new ArrayList<ZenodoSubject>(subjects.size());
for (Subject sub : subjects) {
ZenodoSubject zs = new ZenodoSubject(sub.getTerm(), sub.getIdentifier(), sub.getScheme());
list.add(zs);
}
return list;
}
@ -301,22 +297,21 @@ public class ItemToZenodoConverter {
* @return the list
*/
private static List<ZenodoRelatedIdentifier> toRelatedIdentifiers(List<RelatedIdentifier> related_identifiers) {
if(related_identifiers==null)
if (related_identifiers == null)
return null;
List<ZenodoRelatedIdentifier> list = new ArrayList<ZenodoRelatedIdentifier>(related_identifiers.size());
for (RelatedIdentifier relatedIdentifier : related_identifiers) {
Relation[] rel = { relatedIdentifier.getRelation() };
SerializableEnum<String> sEnum = CkanToZenodoUtil.toSerializableEnum(rel, Relation.values());
SerializableEnum<String> sEnum = CkanToZenodoUtil.toSerializableEnum(rel, Relation.values());
ZenodoRelatedIdentifier zdi = new ZenodoRelatedIdentifier(relatedIdentifier.getIdentifier(), sEnum);
list.add(zdi);
}
return list;
}
/**
* To zenodo date intervals.
*
@ -324,21 +319,22 @@ public class ItemToZenodoConverter {
* @return the list
*/
private static List<ZenodoDateInterval> toZenodoDateIntervals(List<DateInterval> dateIntervals) {
if(dateIntervals==null)
if (dateIntervals == null)
return null;
List<ZenodoDateInterval> list = new ArrayList<ZenodoDateInterval>(dateIntervals.size());
for (DateInterval dateInterval : dateIntervals) {
SerializableEnum<String> types = null;
if(dateInterval.getType()!=null) {
if (dateInterval.getType() != null) {
DateInterval.Type[] rel = { dateInterval.getType() };
types = CkanToZenodoUtil.toSerializableEnum(rel, DateInterval.Type.values());
}
list.add(new ZenodoDateInterval(dateInterval.getStart(), dateInterval.getEnd(), types, dateInterval.getDescription()));
list.add(new ZenodoDateInterval(dateInterval.getStart(), dateInterval.getEnd(), types,
dateInterval.getDescription()));
}
return list;
}
@ -349,18 +345,18 @@ public class ItemToZenodoConverter {
* @return the list
*/
public static List<ZenodoCommunity> toZenodoCommunities(List<Community> communities) {
if(communities==null)
if (communities == null)
return null;
List<ZenodoCommunity> list = new ArrayList<ZenodoCommunity>(communities.size());
for (Community community : communities) {
list.add(new ZenodoCommunity(community.getIdentifier()));
}
return list;
}
/**
* To zenodo contributors.
*
@ -368,10 +364,10 @@ public class ItemToZenodoConverter {
* @return the list
*/
public static List<ZenodoContributor> toZenodoContributors(List<Contributor> contributors) {
if(contributors==null)
if (contributors == null)
return null;
List<ZenodoContributor> list = new ArrayList<ZenodoContributor>(contributors.size());
for (Contributor contr : contributors) {
ZenodoContributor zc = new ZenodoContributor();
@ -380,17 +376,17 @@ public class ItemToZenodoConverter {
zc.setName(contr.getName());
zc.setOrcid(contr.getOrcid());
SerializableEnum<String> types = null;
if(contr.getType()!=null) {
if (contr.getType() != null) {
Contributor.Type[] rel = { contr.getType() };
types = CkanToZenodoUtil.toSerializableEnum(rel, Contributor.Type.values());
}
zc.setType(types);
list.add(zc);
}
return list;
}
/**
* To zenodo creators.
*
@ -398,10 +394,10 @@ public class ItemToZenodoConverter {
* @return the list
*/
public static List<ZenodoCreator> toZenodoCreators(List<Creator> creators) {
if(creators==null)
if (creators == null)
return null;
List<ZenodoCreator> list = new ArrayList<ZenodoCreator>(creators.size());
for (Creator contr : creators) {
ZenodoCreator zc = new ZenodoCreator();
@ -411,11 +407,10 @@ public class ItemToZenodoConverter {
zc.setOrcid(contr.getOrcid());
list.add(zc);
}
return list;
}
/**
* To service file deposition.
*
@ -423,204 +418,203 @@ public class ItemToZenodoConverter {
* @return the file deposition
*/
public static FileDeposition toServiceFileDeposition(ZenodoFile zenodoFile) {
if(zenodoFile==null)
if (zenodoFile == null)
return null;
FileDeposition fileDep = new FileDeposition();
fileDep.setId(zenodoFile.getId());
fileDep.setFilename(zenodoFile.getFilename());
try {
fileDep.setFilesize(Integer.parseInt(zenodoFile.getFilesize()));
}catch (Exception e) {
} catch (Exception e) {
// TODO: handle exception
}
fileDep.setChecksum(zenodoFile.getChecksum());
return fileDep;
}
/**
* Update metadata info of deposition metadata.
*
* @param metadata the metadata
* @param metadata the metadata
* @param depositionMetadata the deposition metadata
* @return the deposition metadata
*/
public static DepositionMetadata updateMetadataInfoOfDepositionMetadata(ZenodoMetadata metadata, DepositionMetadata depositionMetadata) {
//description
public static DepositionMetadata updateMetadataInfoOfDepositionMetadata(ZenodoMetadata metadata,
DepositionMetadata depositionMetadata) {
// description
String description = metadata.getDescription();
LOG.debug("Read description: "+description);
if(description!=null) {
LOG.debug("Read description: " + description);
if (description != null) {
depositionMetadata.setDescription(description);
}
//upload type
// upload type
SerializableEnum<String> uploadType = metadata.getUpload_type();
LOG.debug("Read upload type: "+uploadType);
if(uploadType!=null && uploadType.getSelectedValues()!=null) {
LOG.debug("Read upload type: " + uploadType);
if (uploadType != null && uploadType.getSelectedValues() != null) {
String theUploadTypeValue = uploadType.getSelectedValues().get(0);
LOG.debug("Set upload type: "+theUploadTypeValue);
LOG.debug("Set upload type: " + theUploadTypeValue);
depositionMetadata.setUpload_type(UploadType.valueOf(theUploadTypeValue));
}
//access right
// access right
SerializableEnum<String> accessRight = metadata.getAccess_right();
LOG.debug("Read access type: "+accessRight);
if(accessRight!=null && accessRight.getSelectedValues()!=null) {
LOG.debug("Read access type: " + accessRight);
if (accessRight != null && accessRight.getSelectedValues() != null) {
try {
String theAccessRightValue = accessRight.getSelectedValues().get(0);
LOG.debug("Set access right: "+theAccessRightValue);
LOG.debug("Set access right: " + theAccessRightValue);
depositionMetadata.setAccess_right(AccessRights.valueOf(theAccessRightValue));
}catch (Exception e) {
LOG.warn("Set access right error: ",e);
} catch (Exception e) {
LOG.warn("Set access right error: ", e);
}
}
//publication type
// publication type
SerializableEnum<String> publicationType = metadata.getPublication_type();
LOG.debug("Read publication type: "+publicationType);
if(publicationType!=null && publicationType.getSelectedValues()!=null) {
LOG.debug("Read publication type: " + publicationType);
if (publicationType != null && publicationType.getSelectedValues() != null) {
try {
String thePublicationTypeValue = publicationType.getSelectedValues().get(0);
LOG.debug("Set publication type: "+thePublicationTypeValue);
LOG.debug("Set publication type: " + thePublicationTypeValue);
depositionMetadata.setPublication_type(PublicationType.valueOf(thePublicationTypeValue));
}catch (Exception e) {
LOG.warn("Set publication type error: ",e);
} catch (Exception e) {
LOG.warn("Set publication type error: ", e);
}
}
//image type
// image type
SerializableEnum<String> imageType = metadata.getImage_type();
LOG.debug("Read image type: "+imageType);
if(imageType!=null && imageType.getSelectedValues()!=null) {
LOG.debug("Read image type: " + imageType);
if (imageType != null && imageType.getSelectedValues() != null) {
try {
String imageTypeValue = imageType.getSelectedValues().get(0);
LOG.debug("Set image type: "+imageTypeValue);
LOG.debug("Set image type: " + imageTypeValue);
depositionMetadata.setImage_type(ImageType.valueOf(imageTypeValue));
}catch (Exception e) {
LOG.warn("Set image type error: ",e);
} catch (Exception e) {
LOG.warn("Set image type error: ", e);
}
}
//embargo_date
// embargo_date
Date embargoDate = metadata.getEmbargo_date();
LOG.debug("Read embargo date: "+imageType);
if(embargoDate!=null) {
LOG.debug("Read embargo date: " + imageType);
if (embargoDate != null) {
try {
LOG.debug("Set embargo date: "+embargoDate);
LOG.debug("Set embargo date: " + embargoDate);
depositionMetadata.setEmbargo_date(embargoDate);
}catch (Exception e) {
LOG.warn("Set embargo date error: ",e);
} catch (Exception e) {
LOG.warn("Set embargo date error: ", e);
}
}
//access conditions
// access conditions
String accessConditions = metadata.getAccess_conditions();
LOG.debug("Read access conditions: "+accessConditions);
if(accessConditions!=null) {
LOG.debug("Set access conditions: "+accessConditions);
LOG.debug("Read access conditions: " + accessConditions);
if (accessConditions != null) {
LOG.debug("Set access conditions: " + accessConditions);
depositionMetadata.setAccess_conditions(accessConditions);
}
//license
SerializableEnum<LicenseBean> licenses = metadata.getLicenses();
LOG.debug("Read licenses: "+licenses);
if(licenses!=null) {
// license
List<String> licenses = metadata.getLicenseIDs();
LOG.debug("Read licenses: " + licenses);
if (licenses != null && licenses.size() > 0) {
try {
LicenseBean lB = licenses.getSelectedValues().get(0);
LOG.debug("Set license: "+lB);
depositionMetadata.setLicense(lB.getId());
}catch (Exception e) {
LOG.warn("Set license error: ",e);
String lB = licenses.get(0);
LOG.debug("Set license: " + lB);
depositionMetadata.setLicense(lB);
} catch (Exception e) {
LOG.warn("Set license error: ", e);
}
}
//creators
// creators
List<Creator> creators = null;
List<? extends ZenodoAuthor> zenodoCreators = metadata.getCreators();
LOG.debug("Read Creators: "+zenodoCreators);
if(zenodoCreators!=null) {
LOG.debug("Read Creators: " + zenodoCreators);
if (zenodoCreators != null) {
creators = toCreators(zenodoCreators);
}
LOG.debug("Set Creators: "+creators);
LOG.debug("Set Creators: " + creators);
depositionMetadata.setCreators(creators);
//contributors
// contributors
List<Contributor> contributors = null;
List<? extends ZenodoAuthor> zenodoContributors = metadata.getContributors();
LOG.debug("Read Contributors: "+zenodoContributors);
if(zenodoContributors!=null) {
LOG.debug("Read Contributors: " + zenodoContributors);
if (zenodoContributors != null) {
contributors = toContributors(zenodoContributors);
}
if(LOG.isDebugEnabled()) {
if (LOG.isDebugEnabled()) {
for (Contributor contributor : contributors) {
LOG.debug("Set contributor: name "+contributor.getName() + " type "+contributor.getType());
LOG.debug("Set contributor: name " + contributor.getName() + " type " + contributor.getType());
}
}
depositionMetadata.setContributors(contributors);
//keywords
// keywords
depositionMetadata.setKeywords(metadata.getKeywords());
return depositionMetadata;
}
/**
* To creators.
*
* @param zenodoCreators the zenodo creators
* @return the list
*/
public static List<Creator> toCreators(List<? extends ZenodoAuthor> zenodoCreators){
if(zenodoCreators==null)
public static List<Creator> toCreators(List<? extends ZenodoAuthor> zenodoCreators) {
if (zenodoCreators == null)
return null;
List<Creator> listOfCreators = new ArrayList<>(zenodoCreators.size());
for (ZenodoAuthor zenodoAuthor : zenodoCreators) {
Creator creator = new Creator();
creator.setName(zenodoAuthor.getName());
if(CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getAffiliation())) {
if (CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getAffiliation())) {
creator.setAffiliation(zenodoAuthor.getAffiliation());
}
if(CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getGnd())) {
if (CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getGnd())) {
creator.setGnd(zenodoAuthor.getGnd());
}
if(CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getOrcid())) {
if (CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getOrcid())) {
creator.setOrcid(zenodoAuthor.getOrcid());
}
listOfCreators.add(creator);
}
return listOfCreators;
}
/**
* To contributors.
*
* @param zenodoContributors the zenodo contributors
* @return the list
*/
public static List<Contributor> toContributors(List<? extends ZenodoAuthor> zenodoContributors){
if(zenodoContributors==null)
public static List<Contributor> toContributors(List<? extends ZenodoAuthor> zenodoContributors) {
if (zenodoContributors == null)
return null;
List<Contributor> listOfContributors = new ArrayList<Contributor>(zenodoContributors.size());
for (ZenodoAuthor zenodoAuthor : zenodoContributors) {
Contributor contributor = new Contributor();
contributor.setName(zenodoAuthor.getName());
if(CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getAffiliation())) {
if (CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getAffiliation())) {
contributor.setAffiliation(zenodoAuthor.getAffiliation());
}
if(CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getGnd())) {
if (CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getGnd())) {
contributor.setGnd(zenodoAuthor.getGnd());
}
if(CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getOrcid())) {
if (CkanToZenodoUtil.isNotEmpty(zenodoAuthor.getOrcid())) {
contributor.setOrcid(zenodoAuthor.getOrcid());
}
Type type = null;
@ -628,16 +622,14 @@ public class ItemToZenodoConverter {
try {
theType = zenodoAuthor.getType().getSelectedValues().get(0);
type = Type.valueOf(theType);
}catch (Exception e) {
LOG.error("I'm not able to convert "+theType + " as value of "+Type.class.getName());
} catch (Exception e) {
LOG.error("I'm not able to convert " + theType + " as value of " + Type.class.getName());
}
contributor.setType(type);
listOfContributors.add(contributor);
}
return listOfContributors;
}
}

View File

@ -32,7 +32,7 @@ public class ItemTranslateError implements Serializable {
/**
* Instantiates a new zenodo translate error.
*/
ItemTranslateError() {
public ItemTranslateError() {
}
/**

View File

@ -1,34 +0,0 @@
package org.gcube.portlets.widgets.ckan2zenodopublisher.shared;
/**
* The Interface ZenodoLicense.
*
* @author Francesco Mangiacrapa at ISTI-CNR (francesco.mangiacrapa@isti.cnr.it)
*
* Jan 21, 2020
*/
public interface ZenodoLicense {
/**
* Gets the id.
*
* @return the id
*/
String getId();
/**
* Gets the title.
*
* @return the title
*/
String getTitle();
/**
* Gets the url.
*
* @return the url
*/
String getUrl();
}

View File

@ -0,0 +1,92 @@
package org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped;
import java.io.Serializable;
/**
* The Class DOI_dv.
*
* @author Francesco Mangiacrapa at ISTI-CNR francesco.mangiacrapa@isti.cnr.it
*
* Jul 28, 2023
*/
public class DOI_dv implements Serializable {
/**
*
*/
private static final long serialVersionUID = 1L;
private String doi;
private String doi_url;
/**
* Instantiates a new DO I dv.
*/
public DOI_dv() {
}
/**
* Instantiates a new DO I dv.
*
* @param doi the doi
* @param doi_url the doi url
*/
public DOI_dv(String doi, String doi_url) {
super();
this.doi = doi;
this.doi_url = doi_url;
}
/**
* Gets the doi.
*
* @return the doi
*/
public String getDoi() {
return doi;
}
/**
* Gets the doi url.
*
* @return the doi url
*/
public String getDoi_url() {
return doi_url;
}
/**
* Sets the doi.
*
* @param doi the new doi
*/
public void setDoi(String doi) {
this.doi = doi;
}
/**
* Sets the doi url.
*
* @param doi_url the new doi url
*/
public void setDoi_url(String doi_url) {
this.doi_url = doi_url;
}
/**
* To string.
*
* @return the string
*/
@Override
public String toString() {
StringBuilder builder = new StringBuilder();
builder.append("DOI_dv [doi=");
builder.append(doi);
builder.append(", doi_url=");
builder.append(doi_url);
builder.append("]");
return builder.toString();
}
}

View File

@ -1,98 +0,0 @@
package org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped;
import java.io.Serializable;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.ZenodoLicense;
/**
* A license bean like the ckan's one.
*
* @author Francesco Mangiacrapa at ISTI-CNR (francesco.mangiacrapa@isti.cnr.it)
*
* Jan 13, 2020
*/
public class LicenseBean implements Serializable, ZenodoLicense{
/**
*
*/
private static final long serialVersionUID = 6618784269251750489L;
private String id;
private String title;
private String url;
/**
* Instantiates a new license bean.
*/
public LicenseBean() {
super();
}
/**
* Instantiates a new license bean.
*
* @param id the id
* @param title the title
* @param url the url
*/
public LicenseBean(String id, String title, String url) {
super();
this.id = id;
this.title = title;
this.url = url;
}
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public String getUrl() {
return url;
}
public void setUrl(String url) {
this.url = url;
}
public String getId() {
return id;
}
public void setId(String id) {
this.id = id;
}
/* (non-Javadoc)
* @see java.lang.Object#equals(java.lang.Object)
*/
@Override
public boolean equals(Object obj) {
return obj.getClass().equals(this.getClass()) && ((LicenseBean)obj).getTitle().equals(this.title);
}
@Override
public String toString() {
StringBuilder builder = new StringBuilder();
builder.append("LicenseBean [id=");
builder.append(id);
builder.append(", title=");
builder.append(title);
builder.append(", url=");
builder.append(url);
builder.append("]");
return builder.toString();
}
}

View File

@ -0,0 +1,71 @@
//package org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped;
//
//import java.io.Serializable;
//
///**
// * A license bean like the ckan's one.
// *
// * @author Francesco Mangiacrapa at ISTI-CNR (francesco.mangiacrapa@isti.cnr.it)
// *
// * Jan 13, 2020
// */
//public class LicenseDTO implements Serializable {
//
// /**
// *
// */
// private static final long serialVersionUID = 8796338619448833841L;
// private String id;
// private String title;
// private String url;
//
// /**
// * Instantiates a new license bean.
// */
// public LicenseDTO() {
// }
//
// public LicenseDTO(String id, String title, String url) {
// this.id = id;
// this.title = title;
// this.url = url;
// }
//
// public String getId() {
// return id;
// }
//
// public String getTitle() {
// return title;
// }
//
// public String getUrl() {
// return url;
// }
//
// public void setId(String id) {
// this.id = id;
// }
//
// public void setTitle(String title) {
// this.title = title;
// }
//
// public void setUrl(String url) {
// this.url = url;
// }
//
// @Override
// public String toString() {
// StringBuilder builder = new StringBuilder();
// builder.append("LicenseDTO [id=");
// builder.append(id);
// builder.append(", title=");
// builder.append(title);
// builder.append(", url=");
// builder.append(url);
// builder.append("]");
// return builder.toString();
// }
//
//}

View File

@ -1,5 +1,7 @@
package org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped;
import java.io.Serializable;
import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.SerializableEnum;
@ -10,7 +12,7 @@ import org.gcube.portlets.widgets.ckan2zenodopublisher.shared.SerializableEnum;
*
* Jan 15, 2020
*/
public class ZenodoContributor extends ZenodoCreator{
public class ZenodoContributor extends ZenodoCreator implements Serializable {
/**
*

View File

@ -28,7 +28,7 @@ public class ZenodoDateInterval implements Serializable {
/**
* Instantiates a new zenodo date interval.
*/
ZenodoDateInterval() {
public ZenodoDateInterval() {
}
/**

View File

@ -0,0 +1,34 @@
//package org.gcube.portlets.widgets.ckan2zenodopublisher.shared.wrapped;
//
//
///**
// * The Interface ZenodoLicense.
// *
// * @author Francesco Mangiacrapa at ISTI-CNR (francesco.mangiacrapa@isti.cnr.it)
// *
// * Jan 21, 2020
// */
//public interface ZenodoLicense {
//
// /**
// * Gets the id.
// *
// * @return the id
// */
// String getId();
//
// /**
// * Gets the title.
// *
// * @return the title
// */
// String getTitle();
//
// /**
// * Gets the url.
// *
// * @return the url
// */
// String getUrl();
//
//}

View File

@ -77,7 +77,9 @@ public class ZenodoMetadata implements Serializable {
private List<ZenodoDateInterval> dates;
private String method; // TODO html
private SerializableEnum<LicenseBean> licenses;
// private SerializableEnum<String> licenseIDs;
private List<String> licenseIDs;
/**
* Instantiates a new zenodo metadata.
@ -103,10 +105,20 @@ public class ZenodoMetadata implements Serializable {
this.upload_type = upload_type;
}
/**
* Gets the contributors types.
*
* @return the contributors types
*/
public SerializableEnum<String> getContributorsTypes() {
return contributorsTypes;
}
/**
* Sets the contributors types.
*
* @param contributorsTypes the new contributors types
*/
public void setContributorsTypes(SerializableEnum<String> contributorsTypes) {
this.contributorsTypes = contributorsTypes;
}
@ -868,23 +880,28 @@ public class ZenodoMetadata implements Serializable {
}
/**
* Sets the licenses.
* Sets the license IDs.
*
* @param licenses the new licenses
* @param licensesIDs the new license IDs
*/
public void setLicenses(SerializableEnum<LicenseBean> licenses) {
this.licenses = licenses;
public void setLicenseIDs(List<String> licensesIDs) {
this.licenseIDs = licensesIDs;
}
/**
* Gets the licenses.
* Gets the license IDs.
*
* @return the licenses
* @return the license IDs
*/
public SerializableEnum<LicenseBean> getLicenses() {
return licenses;
public List<String> getLicenseIDs() {
return licenseIDs;
}
/**
* To string.
*
* @return the string
*/
@Override
public String toString() {
StringBuilder builder = new StringBuilder();
@ -974,8 +991,8 @@ public class ZenodoMetadata implements Serializable {
builder.append(dates);
builder.append(", method=");
builder.append(method);
builder.append(", licenses=");
builder.append(licenses);
builder.append(", licenseIDs=");
builder.append(licenseIDs);
builder.append("]");
return builder.toString();
}

View File

@ -1,20 +1,102 @@
package org.gcube.portlets.widgets.ckan2zenodopublisher.client;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.time.Instant;
import java.util.Date;
import javax.ws.rs.client.Entity;
import org.gcube.data.publishing.ckan2zenodo.Fixer;
import org.gcube.data.publishing.ckan2zenodo.model.faults.ZenodoException;
import org.gcube.data.publishing.ckan2zenodo.model.zenodo.DepositionMetadata;
import org.gcube.data.publishing.ckan2zenodo.model.zenodo.ZenodoDeposition;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature;
public class Tester {
public static String expression = "^\\/dataset(\\?([a-zA-Z0-9_.-]*.+))*";
public static String toMatch = "/dataset?systemtype=E39_Actor&groups=huma_num___nakala";
private static ObjectMapper mapper = new ObjectMapper();
static {
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,false);
mapper.configure(SerializationFeature.WRITE_EMPTY_JSON_ARRAYS, false);
mapper.setSerializationInclusion(Include.NON_NULL);
// mapper.configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false);
}
// public static void main(String[] args) {
// Pattern p = Pattern.compile(expression);
// Matcher m = p.matcher(toMatch);
// boolean b = m.matches();
//
// System.out.println(b);
//
// }
public static void main(String[] args) {
Pattern p = Pattern.compile(expression);
Matcher m = p.matcher(toMatch);
boolean b = m.matches();
System.out.println(b);
//ObjectMapper mapper = new ObjectMapper();
ZenodoDeposition zed = new ZenodoDeposition();
DepositionMetadata metadata = new DepositionMetadata();
metadata.setPublication_date(Date.from(Instant.now()));
//zed.setMetadata(metadata);
String serialized;
try {
System.out.println("init json: "+mapper.writeValueAsString(metadata));
serialized = "{\"metadata\":"+Fixer.fixIncoming(mapper.writeValueAsString(metadata))+"}";
System.out.println("serialized: "+serialized);
Entity<String> JSON = Entity.json(serialized);
System.out.println("JSON: "+JSON);
ZenodoDeposition object = mapper.readValue(Fixer.fixIncoming(serialized), ZenodoDeposition.class);
System.out.println("ZenodoDeposition: "+object);
} catch (Exception e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
//System.out.println(metadata.getPublication_date());
// try {
// updateMetadata(metadata);
// } catch (ZenodoException e) {
// // TODO Auto-generated catch block
// e.printStackTrace();
// }
}
private static ZenodoDeposition updateMetadata(DepositionMetadata meta) throws ZenodoException {
try{
String serialized="{\"metadata\":"+Fixer.fixIncoming(mapper.writeValueAsString(meta))+"}";
System.out.println("serialized: "+serialized);
try {
// Response resp = getWebClient().target(credentials.getBaseUrl()).
// path(DEPOSITION_BASE_URL).path(depositionId+"").
// queryParam(ACCESS_TOKEN, credentials.getKey()).request(CONTENT_TYPE)
// .put(Entity.json(serialized));
// return check(resp,ZenodoDeposition.class);
Entity<String> JSON = Entity.json(serialized);
System.out.println("JSON: "+JSON);
return mapper.readValue(Fixer.fixIncoming(serialized), ZenodoDeposition.class);
}catch(Throwable t) {
System.out.println("Error while tryin to update "+serialized);
return null;
}
}catch(JsonProcessingException e) {
System.out.println("Error while parsing "+meta + " " +e);
throw new ZenodoException("Internal error.",e);
}
}
}