From 922607256f428676dc2a2ebead010e705b6f5def Mon Sep 17 00:00:00 2001 From: "francesco.mangiacrapa" Date: Tue, 20 Feb 2024 15:19:36 +0100 Subject: [PATCH] Added final to some properties. Added logs. Hiding reset button on update facility --- .../client/ui/form/CreateDatasetForm.java | 4 ++-- .../client/ui/form/UpdateDatasetForm.java | 3 +++ .../server/CKANPublisherServicesImpl.java | 6 ++++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/client/ui/form/CreateDatasetForm.java b/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/client/ui/form/CreateDatasetForm.java index 25cf383..2f0933b 100644 --- a/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/client/ui/form/CreateDatasetForm.java +++ b/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/client/ui/form/CreateDatasetForm.java @@ -688,7 +688,7 @@ public class CreateDatasetForm extends Composite { * When the organization name is changed we need to retrieve the list of * profiles and groups */ - private void organizationsListboxChangeHandlerBody(OPERATION operation) { + private void organizationsListboxChangeHandlerBody(final OPERATION operation) { // remove any other product profiles metadataTypeListbox.clear(); @@ -811,7 +811,7 @@ public class CreateDatasetForm extends Composite { * * @param receivedBean */ - private void prepareMetadataList(final DatasetBean receivedBean, OPERATION operation) { + private void prepareMetadataList(final DatasetBean receivedBean, final OPERATION operation) { List profiles = receivedBean.getMetadataList(); diff --git a/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/client/ui/form/UpdateDatasetForm.java b/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/client/ui/form/UpdateDatasetForm.java index f41e7a7..e1d8f3a 100644 --- a/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/client/ui/form/UpdateDatasetForm.java +++ b/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/client/ui/form/UpdateDatasetForm.java @@ -407,6 +407,9 @@ public class UpdateDatasetForm extends Composite { continueButton.setEnabled(false); resetButton.setEnabled(false); addResourcesButtonStep1.setEnabled(false); + + // hide reset button + resetButton.setVisible(false); // hide tags panel tagsPanel.setVisible(false); diff --git a/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/server/CKANPublisherServicesImpl.java b/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/server/CKANPublisherServicesImpl.java index 6f4c314..214d98e 100644 --- a/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/server/CKANPublisherServicesImpl.java +++ b/src/main/java/org/gcube/portlets/widgets/ckandatapublisherwidget/server/CKANPublisherServicesImpl.java @@ -1052,8 +1052,10 @@ public class CKANPublisherServicesImpl extends RemoteServiceServlet implements C try { String scopeFromOrgName = getScopeFromOrgName(datasetBean.getSelectedOrganization()); - logger.debug("Going to delete dataset with name: {}", datasetBean.getCkanName()); - return getCatalogue(scopeFromOrgName).deleteDataset(datasetBean.getCkanName()); + logger.info("Going to delete dataset with name: {}", datasetBean.getCkanName()); + boolean deleted = getCatalogue(scopeFromOrgName).deleteDataset(datasetBean.getCkanName()); + logger.info("Dataset {} deleted? ", datasetBean.getCkanName(), deleted); + return deleted; } catch (Exception e) { logger.error("Unable to check if such a dataset id already exists", e); throw new Exception("Unable to check if such a dataset id already exists " + e.getMessage());