From e0273618e5486eda64e4cabe4e8fa139b92ec6c6 Mon Sep 17 00:00:00 2001
From: dcore94 <m.lettere@gmail.com>
Date: Fri, 23 Jun 2023 14:44:08 +0200
Subject: [PATCH] added accessor for loglines, removed unuseful scritp and
 added some margin

---
 ccp/js/executionhistorycontroller.js | 5 +++--
 ccp/js/logterminalcontroller.js      | 6 +++++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/ccp/js/executionhistorycontroller.js b/ccp/js/executionhistorycontroller.js
index 323b3eb..bb7fc12 100644
--- a/ccp/js/executionhistorycontroller.js
+++ b/ccp/js/executionhistorycontroller.js
@@ -38,7 +38,6 @@ class CCPExecutionHistory extends HTMLElement {
     this.#rootdoc.innerHTML = `
       <link rel="stylesheet" href="https://cdn.dev.d4science.org/ccp/css/common.css"></link>
       <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@4.0.0/dist/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">
-      <script src="https://cdn.dev.d4science.org/ccp-dev/js/logterminalcontroller.js"></script>
       <style>
         .lxd{
           background-color: #dd4814;
@@ -112,7 +111,9 @@ class CCPExecutionHistory extends HTMLElement {
                       <span style="text-overflow:ellipsis" class="badge badge-light text-info border border-info" name="infrastructure" alt="Infrastructure" title="Infrastructure"></span>
                       <span class="badge" name="runtime" alt="Runtime" title="Runtime"></span>
                     </div>
-                    <d4s-ccp-logterminal maxlines="10"></d4s-ccp-logterminal>
+                    <div style="margin:5px 0 5px 0">
+                      <d4s-ccp-logterminal maxlines="10"></d4s-ccp-logterminal>
+                    </div>
                     <ul>
                       <li></li>
                     </ul>
diff --git a/ccp/js/logterminalcontroller.js b/ccp/js/logterminalcontroller.js
index b11b964..50f8418 100644
--- a/ccp/js/logterminalcontroller.js
+++ b/ccp/js/logterminalcontroller.js
@@ -15,6 +15,10 @@ class LogTerminal extends HTMLElement {
       
   }
   
+  get lines(){
+    return this.#lines
+  }
+  
   render(){
     this.#rootdoc.innerHTML = `
       <link href="https://fonts.googleapis.com/css2?family=VT323&display=swap" rel="stylesheet">
@@ -63,7 +67,7 @@ class LogTerminal extends HTMLElement {
     in : ()=>this,
     recurse : {
       target : "div.line",
-      in: d=>d.#lines,
+      in: d=>d.lines,
       apply: (e,d,i)=>{
         if(d.source === "stderr") e.classList.add("error");
         e.innerHTML = `<span>${d.line}</span>`