From 72ea4d1314027b06a85333d530bed3b0c14c5908 Mon Sep 17 00:00:00 2001
From: Giancarlo Panichi <g.panichi@isti.cnr.it>
Date: Thu, 1 Apr 2021 10:14:06 +0200
Subject: [PATCH] Refs #21013: Migrate accounting-manager to postgresql
 persistence

Updated GetSpaces
---
 .../command/AccountingCommandGetSpaces.java   | 31 ++++++++-----------
 1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/src/main/java/org/gcube/portlets/admin/accountingmanager/server/amservice/command/AccountingCommandGetSpaces.java b/src/main/java/org/gcube/portlets/admin/accountingmanager/server/amservice/command/AccountingCommandGetSpaces.java
index 7d3503e..67d50be 100644
--- a/src/main/java/org/gcube/portlets/admin/accountingmanager/server/amservice/command/AccountingCommandGetSpaces.java
+++ b/src/main/java/org/gcube/portlets/admin/accountingmanager/server/amservice/command/AccountingCommandGetSpaces.java
@@ -12,14 +12,12 @@ import org.slf4j.LoggerFactory;
 
 /**
  * 
-  * @author Giancarlo Panichi
+ * @author Giancarlo Panichi
  *
  *
  */
-public class AccountingCommandGetSpaces implements
-		AccountingCommand<Spaces> {
-	private static final Logger logger = LoggerFactory
-			.getLogger(AccountingCommandGetSpaces.class);
+public class AccountingCommandGetSpaces implements AccountingCommand<Spaces> {
+	private static final Logger logger = LoggerFactory.getLogger(AccountingCommandGetSpaces.class);
 
 	public AccountingCommandGetSpaces() {
 	}
@@ -29,21 +27,20 @@ public class AccountingCommandGetSpaces implements
 		try {
 			logger.debug("getSpaces()");
 			SortedSet<String> keys = null;
-			AccountingPersistenceQuery apq = AccountingPersistenceQueryFactory
-					.getInstance();
-			
+			AccountingPersistenceQuery apq = AccountingPersistenceQueryFactory.getInstance();
+
 			keys = apq.getSpaceProvidersIds();
 
 			logger.debug("AccountingPersistenceQuery.getSpaces: " + keys);
-			if (keys == null || keys.isEmpty()) {
-				return null;
-			}
-
 			ArrayList<String> spaceList = new ArrayList<>();
 
-			for (String key : keys) {
-				if (key != null && !key.isEmpty()) {
-					spaceList.add(key);
+			if (keys == null || keys.isEmpty()) {
+				logger.error("Spaces have not keys: {}", keys);
+			} else {
+				for (String key : keys) {
+					if (key != null && !key.isEmpty()) {
+						spaceList.add(key);
+					}
 				}
 			}
 			Spaces categories = new Spaces(spaceList);
@@ -52,9 +49,7 @@ public class AccountingCommandGetSpaces implements
 
 			return categories;
 		} catch (Throwable e) {
-			logger.error("Error in AccountingCommandGetSpaces(): "
-					+ e.getLocalizedMessage());
-			e.printStackTrace();
+			logger.error("Error in AccountingCommandGetSpaces(): {}", e.getLocalizedMessage(), e);
 			throw new ServiceException("No spaces available!");
 
 		}