feature/21176 #1

Merged
roberto.cirillo merged 10 commits from feature/21176 into master 2 years ago
Owner

see: #21176

see: #21176
manuele.simi was assigned by roberto.cirillo 2 years ago
roberto.cirillo added 9 commits 2 years ago
manuele.simi requested changes 2 years ago
manuele.simi left a comment

Few minor changes, see comments.

Few minor changes, see comments.
Jenkinsfile Outdated
@ -13,0 +16,4 @@
environment {
AGENT_ROOT_FOLDER = "${agent_root_folder}"
PIPELINE_BUILD_NUMBER = "${env.BUILD_NUMBER}"
WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.md"
  1. I'd use PIPELINE_BUILD_NUMBER instead of inputProject to make the notes' filename unique.
  2. I don't see any markdown formatting in the report, I'd change the extension to .txt.
1. I'd use `PIPELINE_BUILD_NUMBER` instead of `inputProject` to make the notes' filename unique. 2. I don't see any markdown formatting in the report, I'd change the extension to `.txt`.
Poster
Owner

Thanks Manuele for your feedback!

  1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers.
    In order to preserve an unique filename as you suggest, I can add to the current filename, the PIPELINE_BUILD_NUMBER.

WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"

  1. you're absolutely right. I'm going to change it:

WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"

Thanks Manuele for your feedback! 1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers. In order to preserve an unique filename as you suggest, I can add to the current filename, the `PIPELINE_BUILD_NUMBER`. `WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"` 2. you're absolutely right. I'm going to change it: `WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"`

Thanks Manuele for your feedback!

  1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers.
    In order to preserve an unique filename as you suggest, I can add to the current filename, the PIPELINE_BUILD_NUMBER.

Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename.

Neverthlees, adding the pipeline number will make it unique.

WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"

  1. you're absolutely right. I'm going to change it:

WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"

> Thanks Manuele for your feedback! > > 1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers. > In order to preserve an unique filename as you suggest, I can add to the current filename, the `PIPELINE_BUILD_NUMBER`. Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename. Neverthlees, adding the pipeline number will make it unique. > > `WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"` > > 2. you're absolutely right. I'm going to change it: > > `WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"`
Poster
Owner

Thanks Manuele for your feedback!

  1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers.
    In order to preserve an unique filename as you suggest, I can add to the current filename, the PIPELINE_BUILD_NUMBER.

Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename.

OK I'm going to remove the component name from the filename

> > Thanks Manuele for your feedback! > > > > 1. I think it's more useful to have the component name specified in the filename rather than the build number: in this way is more easily to identify the component to which it refers. > > In order to preserve an unique filename as you suggest, I can add to the current filename, the `PIPELINE_BUILD_NUMBER`. > > Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename. OK I'm going to remove the component name from the filename
manuele.simi marked this conversation as resolved
@ -72,0 +105,4 @@
subject: "[JenkinsDependenciesWalker D4S] build ${currentBuild.fullDisplayName} failed for component ${inputProject}",
body: "Something is wrong with ${env.BUILD_URL}"
}
}

Nice post block, it looks familiar...

Nice post block, it looks familiar...
manuele.simi marked this conversation as resolved
@ -147,1 +186,4 @@
}
def appendNotes(report) {
sh("""#!/bin/bash

You don't need the shebang here.

You don't need the shebang here.
Poster
Owner

Are you referring to the bash shell?

I've used the bash shell otherwise the echo -e option doesn't work.

Is there an easier way to do that?

Are you referring to the bash shell? I've used the bash shell otherwise the `echo -e` option doesn't work. Is there an easier way to do that?

echo (without -e) works for sure without the shebang.

But if it does work for you, leave like that. It's a detail.

`echo` (without -e) works for sure without the shebang. But if it does work for you, leave like that. It's a detail.
Poster
Owner

echo (without -e) works for sure without the shebang.

But if it does work for you, leave like that. It's a detail.

Yes it works but without the "-e" option the backslashes are not escapes. The result is an unreadable file.

> `echo` (without -e) works for sure without the shebang. > > But if it does work for you, leave like that. It's a detail. > Yes it works but without the "-e" option the backslashes are not escapes. The result is an unreadable file.
manuele.simi marked this conversation as resolved
roberto.cirillo added 1 commit 2 years ago
roberto.cirillo changed title from feature/21176 to WIP: feature/21176 2 years ago
Poster
Owner

Sprry for the delay.
Changes done. I'm going to merge it into master

Sprry for the delay. Changes done. I'm going to merge it into master
roberto.cirillo changed title from WIP: feature/21176 to feature/21176 2 years ago
roberto.cirillo merged commit e1d7dfb658 into master 2 years ago

Reviewers

manuele.simi requested changes 2 years ago
The pull request has been merged as e1d7dfb658.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b feature/21176 master
git pull origin feature/21176

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff feature/21176
git push origin master
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gCubeCI/gCubeDepsWalker#1
Loading…
There is no content yet.