feature/21176
#1
Merged
roberto.cirillo
merged 10 commits from feature/21176
into master
2 years ago
Loading…
Reference in New Issue
There is no content yet.
Delete Branch 'feature/21176'
Deleting a branch is permanent. It CANNOT be undone. Continue?
see: #21176
Few minor changes, see comments.
@ -13,0 +16,4 @@
environment {
AGENT_ROOT_FOLDER = "${agent_root_folder}"
PIPELINE_BUILD_NUMBER = "${env.BUILD_NUMBER}"
WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.md"
PIPELINE_BUILD_NUMBER
instead ofinputProject
to make the notes' filename unique..txt
.Thanks Manuele for your feedback!
In order to preserve an unique filename as you suggest, I can add to the current filename, the
PIPELINE_BUILD_NUMBER
.WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.md"
WALKER_NOTES = "${agent_root_folder}/walker_notes.${inputProject}.${PIPELINE_BUILD_NUMBER}.txt"
Well, it's a filename attached to an email with a subject related to the component. I mean, the filename should not really matter. And you could have issues with the component name in the filename.
Neverthlees, adding the pipeline number will make it unique.
OK I'm going to remove the component name from the filename
@ -72,0 +105,4 @@
subject: "[JenkinsDependenciesWalker D4S] build ${currentBuild.fullDisplayName} failed for component ${inputProject}",
body: "Something is wrong with ${env.BUILD_URL}"
}
}
Nice post block, it looks familiar...
@ -147,1 +186,4 @@
}
def appendNotes(report) {
sh("""#!/bin/bash
You don't need the shebang here.
Are you referring to the bash shell?
I've used the bash shell otherwise the
echo -e
option doesn't work.Is there an easier way to do that?
echo
(without -e) works for sure without the shebang.But if it does work for you, leave like that. It's a detail.
Yes it works but without the "-e" option the backslashes are not escapes. The result is an unreadable file.
feature/21176to WIP: feature/21176 2 years agoSprry for the delay.
Changes done. I'm going to merge it into master
WIP: feature/21176to feature/21176 2 years agoe1d7dfb658
into master 2 years agoReviewers
e1d7dfb658
.Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Gitea.