diff --git a/dmp-backend/data/src/main/java/eu/eudat/data/dao/entities/DatasetDaoImpl.java b/dmp-backend/data/src/main/java/eu/eudat/data/dao/entities/DatasetDaoImpl.java index 81f5646e1..2ee7fb626 100644 --- a/dmp-backend/data/src/main/java/eu/eudat/data/dao/entities/DatasetDaoImpl.java +++ b/dmp-backend/data/src/main/java/eu/eudat/data/dao/entities/DatasetDaoImpl.java @@ -63,8 +63,7 @@ public class DatasetDaoImpl extends DatabaseAccess implements DatasetDa public QueryableList getAuthenticated(QueryableList query, UserInfo principal) { if (principal.getId() == null) query.where((builder, root) -> builder.equal(root.get("isPublic"), true)); else { - query.where((builder, root) -> builder.or(builder.equal(root.get("dmp").get("creator"), principal), builder.isMember(principal, root.get("dmp").get("users")) - , builder.equal(root.get("isPublic"), true))); + query.where((builder, root) -> builder.or(builder.equal(root.get("dmp").get("creator"), principal), builder.isMember(principal, root.get("dmp").get("users")))); } return query; } diff --git a/dmp-backend/data/src/main/java/eu/eudat/data/entities/Dataset.java b/dmp-backend/data/src/main/java/eu/eudat/data/entities/Dataset.java index 0f803007c..3a555cdf1 100644 --- a/dmp-backend/data/src/main/java/eu/eudat/data/entities/Dataset.java +++ b/dmp-backend/data/src/main/java/eu/eudat/data/entities/Dataset.java @@ -44,7 +44,7 @@ public class Dataset implements DataEntity { private static final Set hints = new HashSet<>(Arrays.asList("datasetListingModel")); public enum Status { - SAVED((short) 0), FINALISED((short) 1), WITHDRAWN((short) 2), DELETED((short) 99); + SAVED((short) 0), FINALISED((short) 1), DELETED((short) 99); private short value; @@ -62,8 +62,6 @@ public class Dataset implements DataEntity { return SAVED; case 1: return FINALISED; - case 2: - return WITHDRAWN; case 99: return DELETED; default: diff --git a/dmp-backend/data/src/main/java/eu/eudat/data/query/items/table/dataset/DatasetPublicTableRequest.java b/dmp-backend/data/src/main/java/eu/eudat/data/query/items/table/dataset/DatasetPublicTableRequest.java index a77d85be2..41498d65a 100644 --- a/dmp-backend/data/src/main/java/eu/eudat/data/query/items/table/dataset/DatasetPublicTableRequest.java +++ b/dmp-backend/data/src/main/java/eu/eudat/data/query/items/table/dataset/DatasetPublicTableRequest.java @@ -1,6 +1,7 @@ package eu.eudat.data.query.items.table.dataset; import eu.eudat.data.dao.criteria.DatasetPublicCriteria; +import eu.eudat.data.entities.DMP; import eu.eudat.data.entities.Dataset; import eu.eudat.data.query.definition.TableQuery; import eu.eudat.queryable.QueryableList; @@ -19,6 +20,8 @@ public class DatasetPublicTableRequest extends TableQuery applyCriteria() { QueryableList query = this.getQuery(); + query.where((builder, root) -> builder.equal(root.get("dmp").get("status"), DMP.DMPStatus.FINALISED.getValue())); + query.where((builder, root) -> builder.equal(root.get("status"), Dataset.Status.FINALISED.getValue())); query.initSubQuery(String.class).where((builder, root) -> builder.equal(root.get("dmp").get("version"), query.subQueryMax((builder1, externalRoot, nestedRoot) -> builder1.equal(externalRoot.get("dmp").get("groupId"), nestedRoot.get("dmp").get("groupId")), Arrays.asList(new SelectionField(FieldSelectionType.COMPOSITE_FIELD, "dmp:version")), String.class))); diff --git a/dmp-backend/web/src/main/java/eu/eudat/logic/managers/DataManagementPlanManager.java b/dmp-backend/web/src/main/java/eu/eudat/logic/managers/DataManagementPlanManager.java index 6f6d9ac3c..b153291eb 100644 --- a/dmp-backend/web/src/main/java/eu/eudat/logic/managers/DataManagementPlanManager.java +++ b/dmp-backend/web/src/main/java/eu/eudat/logic/managers/DataManagementPlanManager.java @@ -172,12 +172,6 @@ public class DataManagementPlanManager { .asQueryable().where((builder, root) -> root.get("id").in(dataManagementPlan.getDatasets() .stream().map(x -> UUID.fromString(x.getId())).collect(Collectors.toList()))) .update(root -> root.get("status"), Dataset.Status.FINALISED.getValue()); - apiContext.getOperationsContext().getDatabaseRepository().getDatasetDao() - .asQueryable().where((builder, root) -> builder.and( - builder.equal(root.get("dmp").get("id"), dataManagementPlan.getId()), - builder.not(root.get("id").in(dataManagementPlan.getDatasets().stream().map(x -> UUID.fromString(x.getId())).collect(Collectors.toList()))), - builder.equal(root.get("status"), Dataset.Status.SAVED.getValue()))) - .update(root -> root.get("status"), Dataset.Status.WITHDRAWN.getValue()); } if (dataManagementPlan.getAssociatedUsers().stream().filter(item -> item.getId() == principal.getId()).collect(Collectors.toList()).size() == 0) assignUser(newDmp, user, apiContext); diff --git a/dmp-backend/web/src/main/java/eu/eudat/logic/managers/DatasetManager.java b/dmp-backend/web/src/main/java/eu/eudat/logic/managers/DatasetManager.java index 4c0524142..405b12265 100644 --- a/dmp-backend/web/src/main/java/eu/eudat/logic/managers/DatasetManager.java +++ b/dmp-backend/web/src/main/java/eu/eudat/logic/managers/DatasetManager.java @@ -344,7 +344,6 @@ public class DatasetManager { eu.eudat.data.entities.Dataset dataset = datasetDao.find(id); if (dataset.getStatus() != eu.eudat.data.entities.Dataset.Status.FINALISED.getValue()) throw new Exception("You cannot make public a Dataset That Has not Been Finalised"); - dataset.setPublic(true); datasetDao.createOrUpdate(dataset); } diff --git a/dmp-frontend/src/app/datasets/dataset-public/dataset-public-listing.component.html b/dmp-frontend/src/app/datasets/dataset-public/dataset-public-listing.component.html index 71525dab2..451b50bf3 100644 --- a/dmp-frontend/src/app/datasets/dataset-public/dataset-public-listing.component.html +++ b/dmp-frontend/src/app/datasets/dataset-public/dataset-public-listing.component.html @@ -35,12 +35,6 @@ {{row.profile}} - - - {{'DATASET-LISTING.COLUMNS.STATUS' | translate}} - {{row.status}} - - - - {{'DATASET-LISTING.COLUMNS.NAME' | translate}} - {{row.label}} - + + + {{'DATASET-LISTING.COLUMNS.NAME' | translate}} + {{row.label}} + - - - {{'DATASET-LISTING.COLUMNS.PROJECT' | - translate}} - {{row.project}} - + + + {{'DATASET-LISTING.COLUMNS.PROJECT' | + translate}} + {{row.project}} + - - - {{'DATASET-LISTING.COLUMNS.DMP' | - translate}} - {{row.dmp}} - + + + {{'DATASET-LISTING.COLUMNS.DMP' | + translate}} + {{row.dmp}} + - - - {{'DATASET-LISTING.COLUMNS.PROFILE' | - translate}} - {{row.profile}} - + + + {{'DATASET-LISTING.COLUMNS.PROFILE' | + translate}} + {{row.profile}} + - - - {{'DATASET-LISTING.COLUMNS.STATUS' | translate}} - {{this.utilities.convertFromDatasetStatus(row.status)}} - + + + {{'DATASET-LISTING.COLUMNS.STATUS' | translate}} + {{this.utilities.convertFromDatasetStatus(row.status)}} + - - + - - + - - + - - + - - - {{'DATASET-LISTING.COLUMNS.DESCRIPTION' | translate}} - {{row.description}} - + + + {{'DATASET-LISTING.COLUMNS.DESCRIPTION' | translate}} + {{row.description}} + - - - {{'DATASET-LISTING.COLUMNS.CREATED' | translate}} - {{row.created | date:'shortDate'}} - + + + {{'DATASET-LISTING.COLUMNS.CREATED' | translate}} + {{row.created | date:'shortDate'}} + - - - {{'DATASET-LISTING.COLUMNS.ACTIONS' | translate}} - - - - + + + - - - - + + + + - - - - - - - - - - - + + diff --git a/dmp-frontend/src/app/datasets/listing/dataset-listing.component.ts b/dmp-frontend/src/app/datasets/listing/dataset-listing.component.ts index a5d0eb122..69ecbafe2 100644 --- a/dmp-frontend/src/app/datasets/listing/dataset-listing.component.ts +++ b/dmp-frontend/src/app/datasets/listing/dataset-listing.component.ts @@ -35,7 +35,7 @@ export class DatasetListingComponent implements OnInit, IBreadCrumbComponent { breadCrumbs: Observable; dataSource: DatasetDataSource | null; - displayedColumns: String[] = ['label', 'project', 'dmp', 'profile', 'status', 'description', 'created', 'actions']; + displayedColumns: String[] = ['label', 'project', 'dmp', 'profile', 'status', 'description', 'created']; pageEvent: PageEvent; titlePrefix: String; dmpId: string; diff --git a/dmp-frontend/src/app/models/datasets/DatasetWizardModel.ts b/dmp-frontend/src/app/models/datasets/DatasetWizardModel.ts index 390d90882..3905e1c14 100644 --- a/dmp-frontend/src/app/models/datasets/DatasetWizardModel.ts +++ b/dmp-frontend/src/app/models/datasets/DatasetWizardModel.ts @@ -17,7 +17,6 @@ import { TagModel } from '../tags/TagModel'; export enum DatasetStatus { Draft = 0, Finalised = 1, - WithDrawn = 2, Deleted = 99 } diff --git a/dmp-frontend/src/app/utilities/utilities.ts b/dmp-frontend/src/app/utilities/utilities.ts index 16c7771f4..393e4d9f3 100644 --- a/dmp-frontend/src/app/utilities/utilities.ts +++ b/dmp-frontend/src/app/utilities/utilities.ts @@ -39,7 +39,6 @@ export class Utilities { switch (status) { case DatasetStatus.Draft: return this.language.instant('TYPES.DATASET-STATUS.DRAFT'); case DatasetStatus.Finalised: return this.language.instant('TYPES.DATASET-STATUS.FINALISED'); - case DatasetStatus.WithDrawn: return this.language.instant('TYPES.DATASET-STATUS.WITHDRAWN'); } } diff --git a/dmp-frontend/src/assets/lang/en.json b/dmp-frontend/src/assets/lang/en.json index 5f4b97f82..b12fbfd79 100644 --- a/dmp-frontend/src/assets/lang/en.json +++ b/dmp-frontend/src/assets/lang/en.json @@ -285,8 +285,7 @@ }, "DATASET-STATUS": { "DRAFT": "Draft", - "FINALISED": "Finalised", - "WITHDRAWN": "Withdrawn" + "FINALISED": "Finalised" }, "EXTERNAL-DATASET-TYPE": { "SOURCE": "Source",