From ca80fbba5687fa1ad7f925a58bab9c0362396874 Mon Sep 17 00:00:00 2001
From: Sofia Papacharalampous <spapacharalampous@cite.gr>
Date: Mon, 1 Jul 2024 15:29:06 +0300
Subject: [PATCH] bug fix

---
 .../ui/description/editor/description-editor.component.html  | 4 ++--
 .../ui/description/editor/description-editor.component.ts    | 2 +-
 .../ui/dmp/dmp-editor-blueprint/dmp-editor.component.html    | 2 +-
 .../app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.ts  | 5 +++++
 4 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/dmp-frontend/src/app/ui/description/editor/description-editor.component.html b/dmp-frontend/src/app/ui/description/editor/description-editor.component.html
index 6aa96e43a..a072f3dbd 100644
--- a/dmp-frontend/src/app/ui/description/editor/description-editor.component.html
+++ b/dmp-frontend/src/app/ui/description/editor/description-editor.component.html
@@ -157,9 +157,9 @@
 										</button>
 									</div>
 								</div>
-								<div class="row mb-4 mt-4">
+								<div class="row mb-4 mt-4" *ngIf="formGroup && !viewOnly">
 									<div class="col-12">
-										<app-form-progress-indication class="mt-2" *ngIf="formGroup && !viewOnly" [formGroup]="formGroup" [checkVisibility]="true"></app-form-progress-indication>
+										<app-form-progress-indication class="mt-2" [formGroup]="formGroup" [checkVisibility]="true"></app-form-progress-indication>
 									</div>
 								</div>
 							</div>
diff --git a/dmp-frontend/src/app/ui/description/editor/description-editor.component.ts b/dmp-frontend/src/app/ui/description/editor/description-editor.component.ts
index 5940693ab..4fc6c4da9 100644
--- a/dmp-frontend/src/app/ui/description/editor/description-editor.component.ts
+++ b/dmp-frontend/src/app/ui/description/editor/description-editor.component.ts
@@ -242,7 +242,7 @@ export class DescriptionEditorComponent extends BaseEditor<DescriptionEditorMode
 		this.descriptionEditorService.setValidationErrorModel(this.editorModel.validationErrorModel);
 		if (this.editorModel.status == DescriptionStatus.Finalized || this.isDeleted || !this.canEdit) {
 			this.viewOnly = true;
-			this.isFinalized = true;
+			this.isFinalized = this.editorModel.status == DescriptionStatus.Finalized;
 			this.formGroup.disable();
 		} else {
 			this.viewOnly = false;
diff --git a/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.html b/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.html
index 42b47b15e..177cb7613 100644
--- a/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.html
+++ b/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.html
@@ -188,7 +188,7 @@
 										</div>
 									</div>
 								</div>
-								<div class="row" *ngIf="this.step !== 0">
+								<div class="row" *ngIf="this.step !== 0 && formGroup && !viewOnly && canEdit">
 									<div class="col-12">
 										<app-dmp-form-progress-indication class="col-12" *ngIf="formGroup && !formGroup.disabled && !lockStatus" [formGroup]="formGroup"></app-dmp-form-progress-indication>
 									</div>
diff --git a/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.ts b/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.ts
index 3b7d318ed..ef2ce7650 100644
--- a/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.ts
+++ b/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.ts
@@ -68,6 +68,7 @@ export class DmpEditorComponent extends BaseEditor<DmpEditorModel, Dmp> implemen
 	isNew = true;
 	isDeleted = false;
 	isFinalized = false;
+	viewOnly = false;
 	item: Dmp;
 	selectedBlueprint: DmpBlueprint;
 	step: number = 0;
@@ -260,7 +261,11 @@ export class DmpEditorComponent extends BaseEditor<DmpEditorModel, Dmp> implemen
 		this.sectionToFieldsMap = this.prepareErrorIndication();
 
 		if (this.editorModel.status == DmpStatus.Finalized || this.isDeleted) {
+			this.viewOnly = true;
+			this.isFinalized = this.editorModel.status == DmpStatus.Finalized;
 			this.formGroup.disable();
+		} else {
+			this.viewOnly = false;
 		}
 	}