From c2343defabcf6272948a139538c19681e4273b3c Mon Sep 17 00:00:00 2001 From: amentis Date: Thu, 11 Jul 2024 12:22:42 +0300 Subject: [PATCH] frontend code clean up --- ...late-editor-radio-box-field.component.html | 6 ------ ...emplate-editor-upload-field.component.html | 1 - ...ption-template-editor-field.component.html | 8 ------- ...ate-editor-section-fieldset.component.html | 1 - ...description-template-editor.component.html | 21 ------------------- ...te-table-of-contents-internal-section.html | 1 - ...escription-template-listing.component.html | 4 +--- .../user/listing/user-listing.component.html | 4 ---- .../annotation-dialog.component.html | 21 ------------------- .../app/ui/dashboard/dashboard.component.scss | 1 - .../recent-edited-activity.component.scss | 2 -- .../plan-listing-item.component.scss | 1 - .../overview/plan-overview.component.html | 4 ++-- frontend/src/assets/scss/core/_forms.scss | 4 ---- .../src/assets/scss/core/_responsive.scss | 5 ----- .../scss/core/_sidebar-and-main-panel.scss | 2 -- frontend/src/assets/scss/core/_tooltip.scss | 1 - frontend/src/assets/scss/core/_variables.scss | 1 - .../assets/scss/core/variables/_layout.scss | 1 - ...on-template-listing-filters.component.html | 1 - ...otification-listing-filters.component.html | 1 - 21 files changed, 3 insertions(+), 88 deletions(-) delete mode 100644 frontend/src/assets/scss/core/variables/_layout.scss diff --git a/frontend/src/app/ui/admin/description-template/editor/components/field-type/radio-box/description-template-editor-radio-box-field.component.html b/frontend/src/app/ui/admin/description-template/editor/components/field-type/radio-box/description-template-editor-radio-box-field.component.html index 7a83a3f66..93deb4a65 100644 --- a/frontend/src/app/ui/admin/description-template/editor/components/field-type/radio-box/description-template-editor-radio-box-field.component.html +++ b/frontend/src/app/ui/admin/description-template/editor/components/field-type/radio-box/description-template-editor-radio-box-field.component.html @@ -9,12 +9,6 @@ {{form.get('data').get('options').getError('backendError').message}} - -
diff --git a/frontend/src/app/ui/admin/description-template/editor/components/field-type/upload/description-template-editor-upload-field.component.html b/frontend/src/app/ui/admin/description-template/editor/components/field-type/upload/description-template-editor-upload-field.component.html index 0b1879cbc..fab81c081 100644 --- a/frontend/src/app/ui/admin/description-template/editor/components/field-type/upload/description-template-editor-upload-field.component.html +++ b/frontend/src/app/ui/admin/description-template/editor/components/field-type/upload/description-template-editor-upload-field.component.html @@ -1,4 +1,3 @@ -
{{'DESCRIPTION-TEMPLATE-EDITOR.STEPS.FORM.FIELD.FIELDS.FIELD-UPLOAD-TITLE' | translate}}
diff --git a/frontend/src/app/ui/admin/description-template/editor/components/field/description-template-editor-field.component.html b/frontend/src/app/ui/admin/description-template/editor/components/field/description-template-editor-field.component.html index 06860bf21..8e3f2e5f3 100644 --- a/frontend/src/app/ui/admin/description-template/editor/components/field/description-template-editor-field.component.html +++ b/frontend/src/app/ui/admin/description-template/editor/components/field/description-template-editor-field.component.html @@ -15,9 +15,6 @@ {{'GENERAL.VALIDATION.URL.LABEL' | translate}} -
  • delete
  • @@ -117,8 +114,6 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}} {{form.get('data').get('fieldType').getError('backendError').message}} - -
    @@ -162,9 +157,6 @@

    {{'DESCRIPTION-TEMPLATE-EDITOR.STEPS.FORM.FIELD.FIELDS.RULES-TITLE' | translate}}

    -
    diff --git a/frontend/src/app/ui/admin/description-template/editor/components/section-fieldset/description-template-editor-section-fieldset.component.html b/frontend/src/app/ui/admin/description-template/editor/components/section-fieldset/description-template-editor-section-fieldset.component.html index 6f032a357..bca3ed2dd 100644 --- a/frontend/src/app/ui/admin/description-template/editor/components/section-fieldset/description-template-editor-section-fieldset.component.html +++ b/frontend/src/app/ui/admin/description-template/editor/components/section-fieldset/description-template-editor-section-fieldset.component.html @@ -56,7 +56,6 @@ [ngClass]="{'field-container-active': fieldset.get('id').value === selectedFieldSetId}"> - drag_indicator
    1.2 {{'DESCRIPTION-TEMPLATE-EDITOR.STEPS.GENERAL-INFO.DESCRIPTION-TEMPLATE-DESCRIPTION'| translate}} *
    -
    {{'DESCRIPTION-TEMPLATE-EDITOR.STEPS.GENERAL-INFO.DESCRIPTION-TEMPLATE-DESCRIPTION-HINT'| translate}}
    @@ -118,9 +117,6 @@
    - {{'DESCRIPTION-TEMPLATE-EDITOR.STEPS.GENERAL-INFO.DESCRIPTION-TEMPLATE-USERS' | translate}} @@ -128,27 +124,10 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
    - -
    - - -
    diff --git a/frontend/src/app/ui/admin/description-template/editor/table-of-contents/table-of-contents-internal-section/description-template-table-of-contents-internal-section.html b/frontend/src/app/ui/admin/description-template/editor/table-of-contents/table-of-contents-internal-section/description-template-table-of-contents-internal-section.html index ee4d54980..bbacdf14d 100644 --- a/frontend/src/app/ui/admin/description-template/editor/table-of-contents/table-of-contents-internal-section/description-template-table-of-contents-internal-section.html +++ b/frontend/src/app/ui/admin/description-template/editor/table-of-contents/table-of-contents-internal-section/description-template-table-of-contents-internal-section.html @@ -148,7 +148,6 @@ -
    diff --git a/frontend/src/app/ui/admin/user/listing/user-listing.component.html b/frontend/src/app/ui/admin/user/listing/user-listing.component.html index 370bc1ca6..46928983e 100644 --- a/frontend/src/app/ui/admin/user/listing/user-listing.component.html +++ b/frontend/src/app/ui/admin/user/listing/user-listing.component.html @@ -62,10 +62,6 @@
    -
    diff --git a/frontend/src/app/ui/annotations/annotation-dialog-component/annotation-dialog.component.html b/frontend/src/app/ui/annotations/annotation-dialog-component/annotation-dialog.component.html index e2bfb9d3b..0f4def83c 100644 --- a/frontend/src/app/ui/annotations/annotation-dialog-component/annotation-dialog.component.html +++ b/frontend/src/app/ui/annotations/annotation-dialog-component/annotation-dialog.component.html @@ -30,10 +30,6 @@ {{'ANNOTATION-DIALOG.THREADS.NEW-THREAD' | translate}} - {{threadFormGroup.get('text').getError('backendError')?.message}} {{'COMMONS.VALIDATION.REQUIRED' | translate}} @@ -120,20 +116,6 @@ - @@ -175,9 +157,6 @@ {{'ANNOTATION-DIALOG.THREADS.REPLY' | translate}} -
    diff --git a/frontend/src/app/ui/dashboard/dashboard.component.scss b/frontend/src/app/ui/dashboard/dashboard.component.scss index ecf938041..ffd354d3a 100644 --- a/frontend/src/app/ui/dashboard/dashboard.component.scss +++ b/frontend/src/app/ui/dashboard/dashboard.component.scss @@ -150,7 +150,6 @@ .plan-card, .description-card { min-width: 712px; - /* min-height: 308px; */ background: #ffffff 0% 0% no-repeat padding-box; box-shadow: 0px 3px 6px #0000001a; border-radius: 4px; diff --git a/frontend/src/app/ui/dashboard/recent-edited-activity/recent-edited-activity.component.scss b/frontend/src/app/ui/dashboard/recent-edited-activity/recent-edited-activity.component.scss index 183b977f0..78c073734 100644 --- a/frontend/src/app/ui/dashboard/recent-edited-activity/recent-edited-activity.component.scss +++ b/frontend/src/app/ui/dashboard/recent-edited-activity/recent-edited-activity.component.scss @@ -26,8 +26,6 @@ input[type="text"] { .icon-align { display: inline-flex; vertical-align: middle; - /* line-height: .9em; */ - /* padding-bottom: 0.4rem; */ } .description-card-actions, diff --git a/frontend/src/app/ui/plan/listing/listing-item/plan-listing-item.component.scss b/frontend/src/app/ui/plan/listing/listing-item/plan-listing-item.component.scss index c345fc90e..34b563de3 100644 --- a/frontend/src/app/ui/plan/listing/listing-item/plan-listing-item.component.scss +++ b/frontend/src/app/ui/plan/listing/listing-item/plan-listing-item.component.scss @@ -109,7 +109,6 @@ p { .plan-card, .description-card { min-width: 712px; - /* min-height: 308px; */ background: #ffffff 0% 0% no-repeat padding-box; box-shadow: 0px 3px 6px #0000001a; border-radius: 4px; diff --git a/frontend/src/app/ui/plan/overview/plan-overview.component.html b/frontend/src/app/ui/plan/overview/plan-overview.component.html index 57c23c966..82dffe521 100644 --- a/frontend/src/app/ui/plan/overview/plan-overview.component.html +++ b/frontend/src/app/ui/plan/overview/plan-overview.component.html @@ -5,12 +5,12 @@
    - +
    diff --git a/frontend/src/assets/scss/core/_forms.scss b/frontend/src/assets/scss/core/_forms.scss index 094862d6e..b5f8d28f9 100644 --- a/frontend/src/assets/scss/core/_forms.scss +++ b/frontend/src/assets/scss/core/_forms.scss @@ -270,7 +270,6 @@ select { } textarea{ - // height: auto !important; resize: none; line-height: $bmd-line-height !important; } @@ -376,13 +375,10 @@ form .ng-valid{ &.mat-focused .mat-form-field-label, .mat-focused .mat-form-field-label, .mat-form-field-label{ - // color: #4caf50; } .mat-input-underline{ - // background-color: #4caf50; height: 2px; .mat-input-ripple{ - // background-color: #4caf50; } } diff --git a/frontend/src/assets/scss/core/_responsive.scss b/frontend/src/assets/scss/core/_responsive.scss index 89812e01b..91af707ce 100644 --- a/frontend/src/assets/scss/core/_responsive.scss +++ b/frontend/src/assets/scss/core/_responsive.scss @@ -75,7 +75,6 @@ display: block; height: 1px; margin-left: 15px; - // background-color: #e5e5e5; } &:last-child { @@ -412,7 +411,6 @@ box-shadow: none; .sidebar-wrapper{ - // padding-bottom: 60px; top: 80px; } @@ -822,9 +820,6 @@ display: none; } } - // .navbar { - // width: calc(100% - 260px); - // } } .nav-mobile-menu, diff --git a/frontend/src/assets/scss/core/_sidebar-and-main-panel.scss b/frontend/src/assets/scss/core/_sidebar-and-main-panel.scss index 50ed2203a..db9ab84ae 100644 --- a/frontend/src/assets/scss/core/_sidebar-and-main-panel.scss +++ b/frontend/src/assets/scss/core/_sidebar-and-main-panel.scss @@ -49,7 +49,6 @@ overflow: auto; width: 260px; z-index: 4; - // padding-bottom: 10px; display: flex; flex-direction: column; top: 80px; @@ -123,7 +122,6 @@ } .nav { - //margin-top: 20px; display: block; .caret { diff --git a/frontend/src/assets/scss/core/_tooltip.scss b/frontend/src/assets/scss/core/_tooltip.scss index 4d2594a80..ca3dcf302 100644 --- a/frontend/src/assets/scss/core/_tooltip.scss +++ b/frontend/src/assets/scss/core/_tooltip.scss @@ -10,7 +10,6 @@ } .tooltip, .tooltip.in { - //opacity: 1; } .tooltip.in{ opacity: 1; diff --git a/frontend/src/assets/scss/core/_variables.scss b/frontend/src/assets/scss/core/_variables.scss index 5445fe383..defd1563a 100644 --- a/frontend/src/assets/scss/core/_variables.scss +++ b/frontend/src/assets/scss/core/_variables.scss @@ -27,7 +27,6 @@ $enable-flex: true; // fully adopt flexbox layouts $enable-shadows: true; // enable shadows, set to false to turn off shadows -@import "variables/layout"; @import "variables/menu"; @import "variables/drawer"; @import "variables/snackbar"; diff --git a/frontend/src/assets/scss/core/variables/_layout.scss b/frontend/src/assets/scss/core/variables/_layout.scss deleted file mode 100644 index 7cbf784ab..000000000 --- a/frontend/src/assets/scss/core/variables/_layout.scss +++ /dev/null @@ -1 +0,0 @@ -// Layout variables - evidently nothing to see here...remove now? diff --git a/frontend/src/notification-service/ui/admin/notification-template/listing/filters/notification-template-listing-filters.component.html b/frontend/src/notification-service/ui/admin/notification-template/listing/filters/notification-template-listing-filters.component.html index 9a061466f..079c56a08 100644 --- a/frontend/src/notification-service/ui/admin/notification-template/listing/filters/notification-template-listing-filters.component.html +++ b/frontend/src/notification-service/ui/admin/notification-template/listing/filters/notification-template-listing-filters.component.html @@ -77,5 +77,4 @@
    -
    diff --git a/frontend/src/notification-service/ui/admin/notification/filters/notification-listing-filters.component.html b/frontend/src/notification-service/ui/admin/notification/filters/notification-listing-filters.component.html index 4dd876f75..e8eaaadac 100644 --- a/frontend/src/notification-service/ui/admin/notification/filters/notification-listing-filters.component.html +++ b/frontend/src/notification-service/ui/admin/notification/filters/notification-listing-filters.component.html @@ -109,5 +109,4 @@ -